Pin sign in attempts to the current session

This makes it way more difficult to brute-force a magic link.

Original implementation by udiudi. Ref: https://github.com/udiudi/fizzy/pull/1/files

Discussion: https://github.com/basecamp/fizzy/discussions/1981

Co-Authored-By: Udi <udi@udi.codes>
This commit is contained in:
Stanko K.R.
2025-12-11 17:18:47 +01:00
parent ef3c49d9ad
commit b6edb93c47
5 changed files with 41 additions and 4 deletions
@@ -107,8 +107,20 @@ module Authentication
end
end
def email_address_pending_authentication_matches?(email_address)
pending_email_address = session.fetch(:email_address_pending_authentication, "")
if ActiveSupport::SecurityUtils.secure_compare(email_address, pending_email_address)
session.delete(:email_address_pending_authentication)
true
else
false
end
end
def redirect_to_session_magic_link(magic_link, return_to: nil)
serve_development_magic_link(magic_link)
session[:email_address_pending_authentication] = magic_link.identity.email_address if magic_link
session[:return_to_after_authenticating] = return_to if return_to
redirect_to session_magic_link_url(script_name: nil)
end