Extract events loading from overloaded UsersController

This commit is contained in:
David Heinemeier Hansson
2025-11-02 17:31:28 +01:00
parent 6a62df470c
commit bced7405df
6 changed files with 66 additions and 31 deletions
+1 -16
View File
@@ -1,14 +1,9 @@
class UsersController < ApplicationController
include FilterScoped
require_access_without_a_user only: %i[ new create ]
before_action :set_join_code, only: %i[ new create]
before_action :ensure_join_code_is_valid, only: %i[ new create ]
before_action :set_join_code, :ensure_join_code_is_valid, only: %i[ new create ]
before_action :set_user, only: %i[ show edit update destroy ]
before_action :ensure_permission_to_change_user, only: %i[ update destroy ]
before_action :set_filter, only: %i[ edit show ]
before_action :set_user_filtering, only: %i[ edit show]
def new
end
@@ -25,8 +20,6 @@ class UsersController < ApplicationController
end
def show
@filter = Current.user.filters.new(creator_ids: [ @user.id ])
@day_timeline = Current.user.timeline_for(day_param, filter: @filter)
end
def update
@@ -58,14 +51,6 @@ class UsersController < ApplicationController
head :forbidden unless Current.user.can_change?(@user)
end
def day_param
if params[:day].present?
Time.zone.parse(params[:day])
else
Time.current
end
end
def user_params
params.expect(user: [ :name, :avatar ])
end