From bd36e433487af76d531bc9b0c4889a38f697787c Mon Sep 17 00:00:00 2001 From: Jason Zimdars Date: Thu, 28 Aug 2025 20:56:40 -0500 Subject: [PATCH] Engagement status interferes with stages filter I'm not entirely sure why `engagement_status` is even present here but it ends up being inherited by the Recently Closed section because @closed doesn't explicityly set its status.That makes the cards in closed disappear when filtering by stage becaue they return true for `engagement_status = doing`. --- app/views/cards/index/_workflow_filter.html.erb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/cards/index/_workflow_filter.html.erb b/app/views/cards/index/_workflow_filter.html.erb index d48ba88e0..3f1dad724 100644 --- a/app/views/cards/index/_workflow_filter.html.erb +++ b/app/views/cards/index/_workflow_filter.html.erb @@ -13,11 +13,11 @@ In stage(s)… <%= form_with url: cards_path, method: :get, class: "popup__list", data: { controller: "form" } do |form| %> - <% filter.as_params.except(:stage_ids).each do |key, value| %> + <% filter.as_params.except(:stage_ids, :engagement_status).each do |key, value| %> <%= filter_hidden_field_tag key, value %> <% end %> - <%= link_to cards_path(filter.as_params.except(:stage_ids)), class: "popup__item btn" do %> + <%= link_to cards_path(filter.as_params.except(:stage_ids, :engagement_status)), class: "popup__item btn" do %> All stages <% end %>