Add more tests and fix failing ones

test/models/command/ai/parser_test.rb

@@ -14,10 +14,9 @@ class Command::Ai::ParserTest < ActionDispatch::IntegrationTest
   end
 
   test "resolve filter string params as ids" do
-    result = parse_command "cards assigned to kevin, tagged with #web, in the collection writebook"
-    assert_equal 1, result.commands.size
+    command = parse_command "cards assigned to kevin, tagged with #web, in the collection writebook"
 
-    url = result.commands.first.url
+    url = command.url
     query_string = URI.parse(url).query
     params = Rack::Utils.parse_nested_query(query_string).with_indifferent_access
 

test/models/command/ai/translator_test.rb

@@ -3,6 +3,8 @@ require "test_helper"
 class Command::Ai::TranslatorTest < ActionDispatch::IntegrationTest
   include VcrTestHelper
 
+  vcr_record!
+
   setup do
     @user = users(:david)
   end
@@ -89,7 +91,7 @@ class Command::Ai::TranslatorTest < ActionDispatch::IntegrationTest
 
   test "combine commands and filters" do
     assert_command(
-      { context: { card_ids: [ 176, 170 ] }, commands: [ "/do", "/assign david", "/stage Investigating" ] },
+      { context: { card_ids: [ 176, 170 ] }, commands: [ "/do", "/assign #{users(:david).to_gid}", "/stage Investigating" ] },
       "Move 176 and 170 to doing, assign to me and set the stage to Investigating")
     assert_command(
       { context: { assignee_ids: [ "jz" ], tag_ids: [ "design" ] }, commands: [ "/assign andy", "/tag #v2" ] },
@@ -129,8 +131,7 @@ class Command::Ai::TranslatorTest < ActionDispatch::IntegrationTest
 
   test "closing soon and falling back soon" do
     assert_command({ context: { indexed_by: "falling_back_soon" } }, "cards to be reconsidered soon")
-    assert_command({ context: { indexed_by: "falling_back_soon" } }, "cards to be reconsidered soon")
-    assert_command({ context: { assignee_ids: [ "david" ], indexed_by: "closing_soon" } }, "my cards that are going to be auto closed")
+    assert_command({ context: { assignee_ids: [ users(:david).to_gid.to_s ], indexed_by: "closing_soon" } }, "my cards that are going to be auto closed")
   end
 
   test "view users profiles" do

test/models/command/go_to_card_test.rb

@@ -18,10 +18,9 @@ class Command::GoToCardTest < ActionDispatch::IntegrationTest
   test "result in a regular search if the card does not exist" do
     command = parse_command "123"
 
-    visit_command = command.commands.first
-    assert visit_command.valid?
+    assert command.valid?
 
-    result = visit_command.execute
+    result = command.execute
     assert_equal cards_path(terms: [ "123" ]), result.url
   end
 end

test/models/command/parser/context_test.rb

@@ -5,6 +5,7 @@ class Command::Parser::ContextTest < ActiveSupport::TestCase
 
   setup do
     @user = users(:david)
+    @context = Command::Parser::Context.new(@user, url: cards_path)
 
     Card.find_each(&:reindex)
     Comment.find_each(&:reindex)
@@ -49,4 +50,66 @@ class Command::Parser::ContextTest < ActiveSupport::TestCase
 
     assert_empty context.cards
   end
+
+  test "find_user by handle" do
+    assert_equal users(:david), @context.find_user("david")
+    assert_equal users(:david), @context.find_user("@david")
+    assert_equal users(:jz), @context.find_user("jz")
+    assert_equal users(:kevin), @context.find_user("kevin")
+    assert_nil @context.find_user("nonexistent")
+  end
+
+  test "find_user by GID" do
+    david_gid = users(:david).to_gid.to_s
+    assert_equal users(:david), @context.find_user(david_gid)
+
+    jz_gid = users(:jz).to_gid.to_s
+    assert_equal users(:jz), @context.find_user(jz_gid)
+
+    assert_nil @context.find_user("invalid-gid")
+  end
+
+  test "find_workflow_stage" do
+    card_context = Command::Parser::Context.new(@user, url: card_path(cards(:logo)))
+
+    assert_equal workflow_stages(:qa_triage), card_context.find_workflow_stage("triage")
+    assert_equal workflow_stages(:qa_in_progress), card_context.find_workflow_stage("in progress")
+    assert_equal workflow_stages(:qa_on_hold), card_context.find_workflow_stage("on hold")
+    assert_equal workflow_stages(:qa_review), card_context.find_workflow_stage("review")
+
+    assert_equal workflow_stages(:qa_in_progress), card_context.find_workflow_stage("progress")
+
+    assert_nil card_context.find_workflow_stage("nonexistent")
+  end
+
+  test "find_tag with title" do
+    assert_equal tags(:web), @context.find_tag("web")
+    assert_equal tags(:web), @context.find_tag("#web")
+    assert_equal tags(:mobile), @context.find_tag("mobile")
+
+    assert_nil @context.find_tag("nonexistent")
+  end
+
+  test "find_tag by GID" do
+    web_gid = tags(:web).to_gid.to_s
+    assert_equal tags(:web), @context.find_tag(web_gid)
+
+    mobile_gid = tags(:mobile).to_gid.to_s
+    assert_equal tags(:mobile), @context.find_tag(mobile_gid)
+
+    assert_nil @context.find_tag("invalid-gid")
+  end
+
+  test "find_collection" do
+    assert_equal collections(:writebook), @context.find_collection("Writebook")
+    assert_equal collections(:writebook), @context.find_collection("writebook")
+
+    assert_equal collections(:private), @context.find_collection("Private collection")
+    assert_equal collections(:private), @context.find_collection("private collection")
+
+    assert_equal collections(:writebook), @context.find_collection("write")
+    assert_equal collections(:private), @context.find_collection("private")
+
+    assert_nil @context.find_collection("nonexistent")
+  end
 end