From cb0196643988dcdc5dbfb9de3a41fe7b18a3abf9 Mon Sep 17 00:00:00 2001 From: Rosa Gutierrez Date: Thu, 18 Dec 2025 15:52:05 +0100 Subject: [PATCH] Remove unused `Card.published_or_drafted_by` scope As the tests for it could lead to confusion where it seems drafted cards are not accessible to someone with access to the board and with the direct drafted card URL. --- app/models/card/statuses.rb | 2 -- test/models/card/statuses_test.rb | 16 ---------------- 2 files changed, 18 deletions(-) diff --git a/app/models/card/statuses.rb b/app/models/card/statuses.rb index 5311c211e..2dc235c1e 100644 --- a/app/models/card/statuses.rb +++ b/app/models/card/statuses.rb @@ -6,8 +6,6 @@ module Card::Statuses before_save :mark_if_just_published after_create -> { track_event :published }, if: :published? - - scope :published_or_drafted_by, ->(user) { where(status: :published).or(where(status: :drafted, creator: user)) } end attr_accessor :was_just_published diff --git a/test/models/card/statuses_test.rb b/test/models/card/statuses_test.rb index 2f9ba95ca..ad8a2a708 100644 --- a/test/models/card/statuses_test.rb +++ b/test/models/card/statuses_test.rb @@ -11,22 +11,6 @@ class Card::StatusesTest < ActiveSupport::TestCase assert card.drafted? end - test "cards are only visible to the creator when drafted" do - card = boards(:writebook).cards.create! creator: users(:kevin), title: "Drafted Card" - card.drafted! - - assert_includes Card.published_or_drafted_by(users(:kevin)), card - assert_not_includes Card.published_or_drafted_by(users(:jz)), card - end - - test "cards are visible to everyone when published" do - card = boards(:writebook).cards.create! creator: users(:kevin), title: "Published Card" - card.published! - - assert_includes Card.published_or_drafted_by(users(:kevin)), card - assert_includes Card.published_or_drafted_by(users(:jz)), card - end - test "an event is created when a card is created in the published state" do assert_no_difference(-> { Event.count }) do boards(:writebook).cards.create! creator: users(:kevin), title: "Draft Card"