From ce1d6469e72575be682a4ff2b2221cad641d22eb Mon Sep 17 00:00:00 2001 From: "Stanko K.R." Date: Mon, 15 Sep 2025 20:14:31 +0200 Subject: [PATCH] Rename methods for clarity --- app/models/webhook/delinquency_tracker.rb | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/app/models/webhook/delinquency_tracker.rb b/app/models/webhook/delinquency_tracker.rb index 4fb2d174a..6ae40eb4a 100644 --- a/app/models/webhook/delinquency_tracker.rb +++ b/app/models/webhook/delinquency_tracker.rb @@ -1,6 +1,6 @@ class Webhook::DelinquencyTracker < ApplicationRecord DELINQUENCY_THRESHOLD = 10 - CHECK_INTERVAL = 1.hour + DELINQUENCY_DURATION = 1.hour belongs_to :webhook @@ -25,14 +25,18 @@ class Webhook::DelinquencyTracker < ApplicationRecord end def delinquent? - enough_time_passed? && (consecutive_failures_count >= DELINQUENCY_THRESHOLD) + failing_for_too_long? && too_many_consecutive_failures? end - def enough_time_passed? + def failing_for_too_long? if first_failure_at - first_failure_at.before?(CHECK_INTERVAL.ago) + first_failure_at.before?(DELINQUENCY_DURATION.ago) else false end end + + def too_many_consecutive_failures? + consecutive_failures_count >= DELINQUENCY_THRESHOLD + end end