From d689f560b4f4a0ef15e7b801502d6bbfb887c71f Mon Sep 17 00:00:00 2001 From: Adrien Maston Date: Thu, 5 Feb 2026 17:04:03 +0100 Subject: [PATCH 1/4] Show "Go to" board button in card perma --- app/helpers/boards_helper.rb | 11 +++++++++-- app/views/cards/container/_closure_buttons.html.erb | 2 +- app/views/cards/show.html.erb | 2 +- 3 files changed, 11 insertions(+), 4 deletions(-) diff --git a/app/helpers/boards_helper.rb b/app/helpers/boards_helper.rb index 5f12b9259..9ffa01941 100644 --- a/app/helpers/boards_helper.rb +++ b/app/helpers/boards_helper.rb @@ -1,6 +1,13 @@ module BoardsHelper - def link_back_to_board(board) - back_link_to board.name, board, "keydown.left@document->hotkey#click keydown.esc@document->hotkey#click click->turbo-navigation#backIfSamePath" + def link_back_to_board(board, bridged = false) + back_link_to board.name, + board, + "keydown.left@document->hotkey#click keydown.esc@document->hotkey#click click->turbo-navigation#backIfSamePath", + data: ({ + bridge__buttons_target: "button", + bridge_icon_url: bridge_icon("board"), + bridge_title: "Go to #{board.name}" + } if bridged) end def link_to_edit_board(board) diff --git a/app/views/cards/container/_closure_buttons.html.erb b/app/views/cards/container/_closure_buttons.html.erb index 05e292315..990a17982 100644 --- a/app/views/cards/container/_closure_buttons.html.erb +++ b/app/views/cards/container/_closure_buttons.html.erb @@ -1,6 +1,6 @@
<%= link_to edit_card_path(card), class: "btn btn--circle-mobile borderless", - data: { controller: "hotkey", action: "keydown.e@document->hotkey#click", bridge__buttons_target: "button", bridge_title: "Edit", bridge_icon_url: bridge_icon("pencil"), turbo_frame: dom_id(card, :edit) } do %> + data: { controller: "hotkey", action: "keydown.e@document->hotkey#click", bridge__overflow_menu_target: "item", bridge_title: "Edit", turbo_frame: dom_id(card, :edit) } do %> <%= icon_tag "pencil", class: "icon--mobile-only" %> Edit e diff --git a/app/views/cards/show.html.erb b/app/views/cards/show.html.erb index bfaa9c676..b114c43df 100644 --- a/app/views/cards/show.html.erb +++ b/app/views/cards/show.html.erb @@ -7,7 +7,7 @@ <% content_for :header do %>
- <%= link_back_to_board(@card.board) %> + <%= link_back_to_board(@card.board, bridged: true) %>
<% end %> From 626b8aa8a6868eec49e55696edcfae30ab72adf7 Mon Sep 17 00:00:00 2001 From: Adrien Maston Date: Thu, 5 Feb 2026 17:31:37 +0100 Subject: [PATCH 2/4] Revert "Show "Go to" board button in card perma" This reverts commit d689f560b4f4a0ef15e7b801502d6bbfb887c71f. --- app/helpers/boards_helper.rb | 11 ++--------- app/views/cards/container/_closure_buttons.html.erb | 2 +- app/views/cards/show.html.erb | 2 +- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/app/helpers/boards_helper.rb b/app/helpers/boards_helper.rb index 9ffa01941..5f12b9259 100644 --- a/app/helpers/boards_helper.rb +++ b/app/helpers/boards_helper.rb @@ -1,13 +1,6 @@ module BoardsHelper - def link_back_to_board(board, bridged = false) - back_link_to board.name, - board, - "keydown.left@document->hotkey#click keydown.esc@document->hotkey#click click->turbo-navigation#backIfSamePath", - data: ({ - bridge__buttons_target: "button", - bridge_icon_url: bridge_icon("board"), - bridge_title: "Go to #{board.name}" - } if bridged) + def link_back_to_board(board) + back_link_to board.name, board, "keydown.left@document->hotkey#click keydown.esc@document->hotkey#click click->turbo-navigation#backIfSamePath" end def link_to_edit_board(board) diff --git a/app/views/cards/container/_closure_buttons.html.erb b/app/views/cards/container/_closure_buttons.html.erb index 990a17982..05e292315 100644 --- a/app/views/cards/container/_closure_buttons.html.erb +++ b/app/views/cards/container/_closure_buttons.html.erb @@ -1,6 +1,6 @@
<%= link_to edit_card_path(card), class: "btn btn--circle-mobile borderless", - data: { controller: "hotkey", action: "keydown.e@document->hotkey#click", bridge__overflow_menu_target: "item", bridge_title: "Edit", turbo_frame: dom_id(card, :edit) } do %> + data: { controller: "hotkey", action: "keydown.e@document->hotkey#click", bridge__buttons_target: "button", bridge_title: "Edit", bridge_icon_url: bridge_icon("pencil"), turbo_frame: dom_id(card, :edit) } do %> <%= icon_tag "pencil", class: "icon--mobile-only" %> Edit e diff --git a/app/views/cards/show.html.erb b/app/views/cards/show.html.erb index b114c43df..bfaa9c676 100644 --- a/app/views/cards/show.html.erb +++ b/app/views/cards/show.html.erb @@ -7,7 +7,7 @@ <% content_for :header do %>
- <%= link_back_to_board(@card.board, bridged: true) %> + <%= link_back_to_board(@card.board) %>
<% end %> From fe555f751ecdef0c12351488919dc5eabdebd0bc Mon Sep 17 00:00:00 2001 From: Adrien Maston Date: Thu, 5 Feb 2026 17:33:29 +0100 Subject: [PATCH 3/4] Move "Edit" action to ellipsis menu --- app/views/cards/container/_closure_buttons.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/cards/container/_closure_buttons.html.erb b/app/views/cards/container/_closure_buttons.html.erb index 05e292315..990a17982 100644 --- a/app/views/cards/container/_closure_buttons.html.erb +++ b/app/views/cards/container/_closure_buttons.html.erb @@ -1,6 +1,6 @@
<%= link_to edit_card_path(card), class: "btn btn--circle-mobile borderless", - data: { controller: "hotkey", action: "keydown.e@document->hotkey#click", bridge__buttons_target: "button", bridge_title: "Edit", bridge_icon_url: bridge_icon("pencil"), turbo_frame: dom_id(card, :edit) } do %> + data: { controller: "hotkey", action: "keydown.e@document->hotkey#click", bridge__overflow_menu_target: "item", bridge_title: "Edit", turbo_frame: dom_id(card, :edit) } do %> <%= icon_tag "pencil", class: "icon--mobile-only" %> Edit e From 4072688974df17031e0fb55503822865f74b1aac Mon Sep 17 00:00:00 2001 From: Adrien Maston Date: Thu, 5 Feb 2026 17:36:48 +0100 Subject: [PATCH 4/4] Use a dedicated link to bridge a "go to" board button --- app/helpers/boards_helper.rb | 8 ++++++++ app/views/cards/show.html.erb | 1 + 2 files changed, 9 insertions(+) diff --git a/app/helpers/boards_helper.rb b/app/helpers/boards_helper.rb index 5f12b9259..eae2f3665 100644 --- a/app/helpers/boards_helper.rb +++ b/app/helpers/boards_helper.rb @@ -9,4 +9,12 @@ module BoardsHelper icon_tag("settings") + tag.span("Settings for #{board.name}", class: "for-screen-reader") end end + + def bridged_button_to_board(board) + link_to "Go to #{board.name}", board, hidden: true, data: { + bridge__buttons_target: "button", + bridge_icon_url: bridge_icon("board"), + bridge_title: "Go to #{board.name}" + } + end end diff --git a/app/views/cards/show.html.erb b/app/views/cards/show.html.erb index bfaa9c676..bbbff8275 100644 --- a/app/views/cards/show.html.erb +++ b/app/views/cards/show.html.erb @@ -8,6 +8,7 @@ <% content_for :header do %>
<%= link_back_to_board(@card.board) %> + <%= bridged_button_to_board(@card.board) %>
<% end %>