From d3db752f3900298f3462dd7f6d3b1b615fc9327a Mon Sep 17 00:00:00 2001
From: Andy Smith <andy@37signals.com>
Date: Mon, 21 Jul 2025 13:35:24 -0500
Subject: [PATCH] Remove redundant flex-grow class from popup__items

---
 app/views/cards/assignments/new.html.erb                 | 2 +-
 app/views/cards/display/perma/_collection.html.erb       | 2 +-
 app/views/cards/index/_collections_filter.html.erb       | 6 +++---
 app/views/cards/show/_collections.html.erb               | 6 +++---
 app/views/cards/taggings/new.html.erb                    | 2 +-
 app/views/events/filter/_all_collections_option.html.erb | 4 ++--
 app/views/events/filter/_collection_option.html.erb      | 2 +-
 app/views/events/filter/_tag.html.erb                    | 2 +-
 app/views/events/filter/_user.html.erb                   | 2 +-
 9 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/app/views/cards/assignments/new.html.erb b/app/views/cards/assignments/new.html.erb
index 3bcb14047..81d97d412 100644
--- a/app/views/cards/assignments/new.html.erb
+++ b/app/views/cards/assignments/new.html.erb
@@ -16,7 +16,7 @@
       <% @collection.users.active.alphabetically.each do |user| %>
         <li class="popup__group flex align-center full-width" data-filter-target="item" data-navigable-list-target="item">
           <%= button_to card_assignments_path(@card, params: { assignee_id: user.id }), method: :post,
-              class: "popup__item btn flex-item-grow full-width unpad-inline",
+              class: "popup__item btn full-width unpad-inline",
               form_class: "max-width flex-item-grow" do %>
             <span class="overflow-ellipsis flex-item-grow"><%= user.name %></span>
             <%= icon_tag "check", size: 18, class: "checked flex-item-no-shrink flex-item-justify-end", style: "--icon-size: 1em" if @card.assignees.include?(user) %>
diff --git a/app/views/cards/display/perma/_collection.html.erb b/app/views/cards/display/perma/_collection.html.erb
index a5a4648db..94d6a51f8 100644
--- a/app/views/cards/display/perma/_collection.html.erb
+++ b/app/views/cards/display/perma/_collection.html.erb
@@ -23,7 +23,7 @@
           <% Current.user.collections.alphabetically.each do |collection| %>
             <li class="popup__group flex align-center full-width" data-filter-target="item" data-navigable-list-target="item">
               <%= button_to card_collection_path(card, params: { collection_id: collection.id }), method: :patch,
-                  class: "popup__item btn flex-item-grow full-width unpad-inline",
+                  class: "popup__item btn full-width unpad-inline",
                   form_class: "max-width flex-item-grow" do %>
                 <span class="overflow-ellipsis flex-item-grow"><%= collection.name %></span>
                 <%= icon_tag "check", size: 18, class: "checked flex-item-no-shrink flex-item-justify-end", style: "--icon-size: 1em" if card.collection == collection %>
diff --git a/app/views/cards/index/_collections_filter.html.erb b/app/views/cards/index/_collections_filter.html.erb
index ae01635c5..042c1189f 100644
--- a/app/views/cards/index/_collections_filter.html.erb
+++ b/app/views/cards/index/_collections_filter.html.erb
@@ -6,7 +6,7 @@
 
   <% if Current.user.collections.one? %>
     <%= link_to cards_path(filter.as_params.except(:collection_ids)), class: "popup__group flex align-center", data: { filter_target: "item", navigable_list_target: "item" } do %>
-      <%= tag.div class: "popup__item btn flex-item-grow" do %>
+      <%= tag.div class: "popup__item btn" do %>
         <span class="overflow-ellipsis"><%= Current.user.collections.first.name %></span>
         <span class="txt-ink translucent flex-item-no-shrink flex-item-justify-end"><span class="txt-x-small txt-uppercase">GO TO</span> ›</span>
       <% end %>
@@ -21,7 +21,7 @@
         </span>
         <%= icon_tag "check", size: 18, class: "checked" %>
       </label>
-      <%= tag.div class: "popup__item btn flex-item-grow" do %>
+      <%= tag.div class: "popup__item btn" do %>
         <span class="overflow-ellipsis">All collections</span>
         <span class="txt-ink translucent flex-item-no-shrink flex-item-justify-end"><span class="txt-x-small txt-uppercase">GO TO</span> ›</span>
       <% end %>
@@ -42,7 +42,7 @@
           <%= icon_tag "check", size: 18, class: "checked" %>
         </label>
 
-        <%= link_to cards_path(collection_ids: [ collection ]), class: "popup__item btn flex-item-grow" do %>
+        <%= link_to cards_path(collection_ids: [ collection ]), class: "popup__item btn" do %>
           <span class="overflow-ellipsis"><%= collection.name %></span>
           <span class="translucent flex-item-no-shrink flex-item-justify-end"> ›</span>
         <% end %>
diff --git a/app/views/cards/show/_collections.html.erb b/app/views/cards/show/_collections.html.erb
index 13f2d6077..0c7aa375e 100644
--- a/app/views/cards/show/_collections.html.erb
+++ b/app/views/cards/show/_collections.html.erb
@@ -3,7 +3,7 @@
       data: { controller: "form" } do |form| %>
   <% if Current.user.collections.one? %>
     <%= link_to cards_path, class: "popup__group flex align-center", data: { filter_target: "item", navigable_list_target: "item" } do %>
-      <%= tag.div class: "popup__item btn flex-item-grow" do %>
+      <%= tag.div class: "popup__item btn" do %>
         <span class="overflow-ellipsis"><%= Current.user.collections.first.name %></span>
         <span class="txt-ink translucent flex-item-no-shrink flex-item-justify-end"><span class="txt-x-small txt-uppercase">GO TO</span> ›</span>
       <% end %>
@@ -18,7 +18,7 @@
         </span>
         <%= icon_tag "check", size: 18, class: "checked" %>
       </label>
-      <%= tag.div class: "popup__item btn flex-item-grow" do %>
+      <%= tag.div class: "popup__item btn" do %>
         <span class="overflow-ellipsis">All collections</span>
         <span class="txt-ink translucent flex-item-no-shrink flex-item-justify-end"><span class="txt-x-small txt-uppercase">GO TO</span> ›</span>
       <% end %>
@@ -39,7 +39,7 @@
           <%= icon_tag "check", size: 18, class: "checked" %>
         </label>
 
-        <%= link_to cards_path(collection_ids: [ collection ]), class: "popup__item btn flex-item-grow" do %>
+        <%= link_to cards_path(collection_ids: [ collection ]), class: "popup__item btn" do %>
           <span class="overflow-ellipsis"><%= collection.name %></span>
           <span class="translucent flex-item-no-shrink flex-item-justify-end"> ›</span>
         <% end %>
diff --git a/app/views/cards/taggings/new.html.erb b/app/views/cards/taggings/new.html.erb
index 4e78bbbc6..0406c7bfe 100644
--- a/app/views/cards/taggings/new.html.erb
+++ b/app/views/cards/taggings/new.html.erb
@@ -17,7 +17,7 @@
       <% @tags.each do |tag| %>
         <li class="popup__group flex align-center full-width" data-filter-target="item" data-navigable-list-target="item">
           <%= button_to card_taggings_path(@card, params: { tag_title: tag.title }), method: :post,
-              class: "popup__item btn flex-item-grow full-width unpad-inline",
+              class: "popup__item btn full-width unpad-inline",
               form_class: "max-width flex-item-grow" do %>
             <span class="overflow-ellipsis flex-item-grow"><%= tag.hashtag %></span>
             <%= icon_tag "check", size: 18, class: "checked flex-item-no-shrink flex-item-justify-end", style: "--icon-size: 1em" if @card.tagged_with?(tag) %>
diff --git a/app/views/events/filter/_all_collections_option.html.erb b/app/views/events/filter/_all_collections_option.html.erb
index dd2cb650b..d8b71a62d 100644
--- a/app/views/events/filter/_all_collections_option.html.erb
+++ b/app/views/events/filter/_all_collections_option.html.erb
@@ -1,6 +1,6 @@
 <% if Current.user.collections.one? %>
   <%= link_to cards_path(filter.as_params.except(:collection_ids)), class: "popup__group flex align-center", data: { filter_target: "item", navigable_list_target: "item" } do %>
-    <%= tag.div class: "popup__item btn flex-item-grow" do %>
+    <%= tag.div class: "popup__item btn" do %>
       <span class="overflow-ellipsis"><%= Current.user.collections.first.name %></span>
       <span class="txt-ink translucent flex-item-no-shrink flex-item-justify-end"><span class="txt-x-small txt-uppercase">GO TO</span> ›</span>
     <% end %>
@@ -15,7 +15,7 @@
       <%= icon_tag "check", size: 18, class: "checked" %>
     <% end %>
 
-    <%= link_to cards_path(filter.as_params.except(:collection_ids)), class: "popup__item btn flex-item-grow" do %>
+    <%= link_to cards_path(filter.as_params.except(:collection_ids)), class: "popup__item btn" do %>
       <span class="overflow-ellipsis">All collections</span>
       <span class="txt-ink translucent flex-item-no-shrink flex-item-justify-end"><span class="txt-x-small txt-uppercase">GO TO</span> ›</span>
     <% end %>
diff --git a/app/views/events/filter/_collection_option.html.erb b/app/views/events/filter/_collection_option.html.erb
index 32736b88f..7e898a661 100644
--- a/app/views/events/filter/_collection_option.html.erb
+++ b/app/views/events/filter/_collection_option.html.erb
@@ -12,7 +12,7 @@
     <%= icon_tag "check", size: 18, class: "checked flex-item-justify-end" %>
   </label>
 
-  <%= link_to cards_path(collection_ids: [ collection ]), class: "popup__item btn flex-item-grow" do %>
+  <%= link_to cards_path(collection_ids: [ collection ]), class: "popup__item btn" do %>
     <span class="overflow-ellipsis"><%= collection.name %></span>
     <span class="translucent flex-item-no-shrink flex-item-justify-end"> ›</span>
   <% end %>
diff --git a/app/views/events/filter/_tag.html.erb b/app/views/events/filter/_tag.html.erb
index 27dff6b79..fc925aef4 100644
--- a/app/views/events/filter/_tag.html.erb
+++ b/app/views/events/filter/_tag.html.erb
@@ -1,6 +1,6 @@
 <li class="popup__group flex align-center" data-filter-target="item" data-navigable-list-target="item">
   <%= icon_tag "tag" %>
-  <%= link_to cards_path(tag_ids: [ tag ]), class: "popup__item btn flex-item-grow" do %>
+  <%= link_to cards_path(tag_ids: [ tag ]), class: "popup__item btn" do %>
     <span class="overflow-ellipsis"><%= tag.title %> (<%= tag.cards_count %>)</span>
     <span class="translucent flex-item-no-shrink flex-item-justify-end"> ›</span>
   <% end %>
diff --git a/app/views/events/filter/_user.html.erb b/app/views/events/filter/_user.html.erb
index 6f1631159..c31fca0d9 100644
--- a/app/views/events/filter/_user.html.erb
+++ b/app/views/events/filter/_user.html.erb
@@ -1,6 +1,6 @@
 <li class="popup__group flex align-center" data-filter-target="item" data-navigable-list-target="item">
   <%= icon_tag "person" %>
-  <%= link_to user, class: "popup__item btn flex-item-grow" do %>
+  <%= link_to user, class: "popup__item btn" do %>
     <span class="overflow-ellipsis"><%= user.name %></span>
     <span class="translucent flex-item-no-shrink flex-item-justify-end"> ›</span>
   <% end %>