From dc2205ee79d621b0820cf67c23cb229727c178a5 Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Mon, 21 Apr 2025 09:18:42 +0200 Subject: [PATCH] Cards have a not-null schema and collections destroy all cards on deletion This shouldnt be necessary. Maybe remnant of some previous design? --- app/models/card.rb | 2 +- test/models/card_test.rb | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/app/models/card.rb b/app/models/card.rb index 9c8ce4908..7237e1f58 100644 --- a/app/models/card.rb +++ b/app/models/card.rb @@ -29,6 +29,6 @@ class Card < ApplicationRecord end def cache_key - [ super, collection&.name ].compact.join("/") + [ super, collection.name ].compact.join("/") end end diff --git a/test/models/card_test.rb b/test/models/card_test.rb index 49678bd0c..93f13e565 100644 --- a/test/models/card_test.rb +++ b/test/models/card_test.rb @@ -120,11 +120,4 @@ class CardTest < ActiveSupport::TestCase assert_includes card.cache_key, ApplicationRecord.current_tenant, "cache key must always include the tenant" end - - test "cache key gracefully handles a nil collection" do - card = cards(:logo) - card.update_column :collection_id, Collection.last.id + 1 - - assert_nothing_raised { card.reload.cache_key } - end end