From dc6da76b38e76e7255ea18c4c5a0652d56aafe50 Mon Sep 17 00:00:00 2001 From: Jose Farias Date: Thu, 16 Jan 2025 14:01:25 -0600 Subject: [PATCH] Simplify overlap logic --- app/javascript/controllers/divider_controller.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/javascript/controllers/divider_controller.js b/app/javascript/controllers/divider_controller.js index 0047d252c..2cec61d8c 100644 --- a/app/javascript/controllers/divider_controller.js +++ b/app/javascript/controllers/divider_controller.js @@ -35,12 +35,9 @@ export default class extends Controller { moveDivider(event) { if (event.target.nodeName == DIVIDER_ITEM_NODE_NAME) { const rect = this.dividerTarget.getBoundingClientRect() - const distanceToTop = Math.abs(event.clientY - rect.top) - const distanceToBottom = Math.abs(event.clientY - (rect.top + rect.height)) - const distanceToNearestEdge = Math.min(distanceToTop, distanceToBottom) - const distancePercentage = (distanceToNearestEdge / rect.height) * 100 + const overlap = Math.abs((event.clientY - rect.top) / rect.height) - if (distancePercentage > 50) { + if (overlap > 0.5) { this.#moveDividerTo(this.#items.indexOf(event.target)) } }