From 348808edc26d1eb9f14e1708ae847a0bdedf9014 Mon Sep 17 00:00:00 2001
From: Andy Smith <andy@37signals.com>
Date: Mon, 22 Dec 2025 14:26:03 -0600
Subject: [PATCH 1/2] Replace span with li

---
 app/views/cards/assignments/_user.html.erb | 14 ++++++--------
 app/views/cards/assignments/new.html.erb   |  6 +++---
 2 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/app/views/cards/assignments/_user.html.erb b/app/views/cards/assignments/_user.html.erb
index 0d4eff888..ebec292b9 100644
--- a/app/views/cards/assignments/_user.html.erb
+++ b/app/views/cards/assignments/_user.html.erb
@@ -1,8 +1,6 @@
-<li class="popup__item" data-filter-target="item" data-navigable-list-target="item" aria-checked="<%= card.assignees.include?(user) %>">
-  <%= button_to card_assignments_path(card, params: { assignee_id: user.id }), method: :post,
-        class: "popup__btn btn", form_class: "max-width flex-item-grow" do %>
-    <span class="overflow-ellipsis flex-item-grow"><%= local_assigns.fetch(:user_label, user.name) %></span>
-    <%= yield if block_given? %>
-    <%= icon_tag "check", size: 18, class: "checked flex-item-no-shrink flex-item-justify-end", style: "--icon-size: 1em" %>
-  <% end %>
-</li>
+<%= button_to card_assignments_path(card, params: { assignee_id: user.id }), method: :post,
+      class: "popup__btn btn", form_class: "max-width flex-item-grow" do %>
+  <span class="overflow-ellipsis flex-item-grow"><%= local_assigns.fetch(:user_label, user.name) %></span>
+  <%= yield if block_given? %>
+  <%= icon_tag "check", size: 18, class: "checked flex-item-no-shrink flex-item-justify-end", style: "--icon-size: 1em" %>
+<% end %>
diff --git a/app/views/cards/assignments/new.html.erb b/app/views/cards/assignments/new.html.erb
index 609478550..726d640f0 100644
--- a/app/views/cards/assignments/new.html.erb
+++ b/app/views/cards/assignments/new.html.erb
@@ -23,9 +23,9 @@
       <% end %>
       <%= render collection: @assigned_to, partial: "user", locals: { card: @card } %>
       <% @users.each do |user| %>
-        <span data-assignment-limit-target="unassigned">
-          <%= render "user", card: @card, user: user %>
-        </span>
+        <li class="popup__item" data-filter-target="item" data-navigable-list-target="item" data-assignment-limit-target="unassigned" aria-checked="<%= @card.assignees.include?(user) %>">
+          <%= render "user", card: @card, user: user, data: { assignment_limit_target: "unassigned" } %>
+        </li>
       <% end %>
     </ul>
 

From ea6190739715e885926ad92396efe436b704144b Mon Sep 17 00:00:00 2001
From: Andy Smith <andy@37signals.com>
Date: Mon, 22 Dec 2025 14:43:08 -0600
Subject: [PATCH 2/2] Pass in data attribute to partial

---
 app/views/cards/assignments/_user.html.erb | 14 ++++++++------
 app/views/cards/assignments/new.html.erb   |  4 +---
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/views/cards/assignments/_user.html.erb b/app/views/cards/assignments/_user.html.erb
index ebec292b9..b2e885649 100644
--- a/app/views/cards/assignments/_user.html.erb
+++ b/app/views/cards/assignments/_user.html.erb
@@ -1,6 +1,8 @@
-<%= button_to card_assignments_path(card, params: { assignee_id: user.id }), method: :post,
-      class: "popup__btn btn", form_class: "max-width flex-item-grow" do %>
-  <span class="overflow-ellipsis flex-item-grow"><%= local_assigns.fetch(:user_label, user.name) %></span>
-  <%= yield if block_given? %>
-  <%= icon_tag "check", size: 18, class: "checked flex-item-no-shrink flex-item-justify-end", style: "--icon-size: 1em" %>
-<% end %>
+<li class="popup__item" data-filter-target="item" data-navigable-list-target="item" <%= tag.attributes(data: local_assigns.fetch(:data, {})) %> aria-checked="<%= card.assignees.include?(user) %>">
+  <%= button_to card_assignments_path(card, params: { assignee_id: user.id }), method: :post,
+        class: "popup__btn btn", form_class: "max-width flex-item-grow" do %>
+    <span class="overflow-ellipsis flex-item-grow"><%= local_assigns.fetch(:user_label, user.name) %></span>
+    <%= yield if block_given? %>
+    <%= icon_tag "check", size: 18, class: "checked flex-item-no-shrink flex-item-justify-end", style: "--icon-size: 1em" %>
+  <% end %>
+</li>
diff --git a/app/views/cards/assignments/new.html.erb b/app/views/cards/assignments/new.html.erb
index 726d640f0..9c753fc0a 100644
--- a/app/views/cards/assignments/new.html.erb
+++ b/app/views/cards/assignments/new.html.erb
@@ -23,9 +23,7 @@
       <% end %>
       <%= render collection: @assigned_to, partial: "user", locals: { card: @card } %>
       <% @users.each do |user| %>
-        <li class="popup__item" data-filter-target="item" data-navigable-list-target="item" data-assignment-limit-target="unassigned" aria-checked="<%= @card.assignees.include?(user) %>">
-          <%= render "user", card: @card, user: user, data: { assignment_limit_target: "unassigned" } %>
-        </li>
+        <%= render "user", card: @card, user: user, data: { assignment_limit_target: "unassigned" } %>
       <% end %>
     </ul>