diff --git a/app/controllers/my/passkeys_controller.rb b/app/controllers/my/passkeys_controller.rb index 40ddaca24..f4a645ec3 100644 --- a/app/controllers/my/passkeys_controller.rb +++ b/app/controllers/my/passkeys_controller.rb @@ -5,11 +5,11 @@ class My::PasskeysController < ApplicationController def index @passkeys = Current.identity.passkeys.order(name: :asc, created_at: :desc) - @creation_options = passkey_creation_options(holder: Current.identity) + @registration_options = passkey_registration_options(holder: Current.identity) end def create - passkey = Current.identity.passkeys.register(passkey_creation_params) + passkey = Current.identity.passkeys.register(passkey_registration_params) redirect_to edit_my_passkey_path(passkey, created: true) end diff --git a/app/javascript/lib/action_pack/passkey.js b/app/javascript/lib/action_pack/passkey.js index 41c0d0c2b..bdea35698 100644 --- a/app/javascript/lib/action_pack/passkey.js +++ b/app/javascript/lib/action_pack/passkey.js @@ -1,6 +1,6 @@ // Web components for the ActionPack::Passkey Ruby helpers. // -// — wraps a registration ceremony form +// — wraps a registration ceremony form // — wraps an authentication ceremony form // // The Ruby form helpers render the component markup including the inner form, @@ -92,13 +92,13 @@ class PasskeyButton extends HTMLElement { } } -class PasskeyCreationButton extends PasskeyButton { +class PasskeyRegistrationButton extends PasskeyButton { async perform(options) { return await register(options) } fillForm(passkey) { - fillCreateForm(this.form, passkey) + fillRegistrationForm(this.form, passkey) } } @@ -148,7 +148,7 @@ class PasskeySignInButton extends PasskeyButton { } } -customElements.define("rails-passkey-creation-button", PasskeyCreationButton) +customElements.define("rails-passkey-registration-button", PasskeyRegistrationButton) customElements.define("rails-passkey-sign-in-button", PasskeySignInButton) // -- Shared helpers ---------------------------------------------------------- @@ -176,7 +176,7 @@ async function refreshChallenge(options, challengeUrl) { options.challenge = challenge } -function fillCreateForm(form, passkey) { +function fillRegistrationForm(form, passkey) { form.querySelector('[data-passkey-field="client_data_json"]').value = passkey.client_data_json form.querySelector('[data-passkey-field="attestation_object"]').value = passkey.attestation_object diff --git a/app/views/my/passkeys/index.html.erb b/app/views/my/passkeys/index.html.erb index e0c381b85..fac5be42e 100644 --- a/app/views/my/passkeys/index.html.erb +++ b/app/views/my/passkeys/index.html.erb @@ -18,7 +18,7 @@ <% end %>