Filter draft cards from public closed column (#2667)
The public closed column was showing draft cards because it queried `@board.cards.closed` without a `.published` filter. This adds the missing `.published` scope to match the pattern used elsewhere in the public controllers. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -9,4 +9,14 @@ class Public::Boards::Columns::ClosedsControllerTest < ActionDispatch::Integrati
|
||||
get public_board_columns_closed_path(boards(:writebook).publication.key)
|
||||
assert_response :success
|
||||
end
|
||||
|
||||
test "show excludes draft cards" do
|
||||
draft_card = cards(:buy_domain)
|
||||
draft_card.update!(status: :drafted)
|
||||
Current.set(user: users(:david)) { draft_card.close }
|
||||
|
||||
get public_board_columns_closed_path(boards(:writebook).publication.key)
|
||||
assert_response :success
|
||||
assert_not_includes response.body, draft_card.title
|
||||
end
|
||||
end
|
||||
|
||||
@@ -21,6 +21,16 @@ class Public::BoardsControllerTest < ActionDispatch::IntegrationTest
|
||||
assert_response :not_found
|
||||
end
|
||||
|
||||
test "show excludes draft cards from closed count" do
|
||||
draft_card = cards(:buy_domain)
|
||||
draft_card.update!(status: :drafted)
|
||||
Current.set(user: users(:david)) { draft_card.close }
|
||||
|
||||
get published_board_path(boards(:writebook))
|
||||
assert_response :success
|
||||
assert_select ".cards--closed .cards__expander-count", "1"
|
||||
end
|
||||
|
||||
test "show works without authentication" do
|
||||
sign_out
|
||||
get published_board_path(boards(:writebook))
|
||||
|
||||
Reference in New Issue
Block a user