From e2f608eb71a7106f2c271160cc2d1036e0bc602a Mon Sep 17 00:00:00 2001 From: Jose Farias Date: Thu, 24 Oct 2024 15:47:39 -0600 Subject: [PATCH] Remove *_names accessors for bucket views --- app/models/bucket/view/assignees.rb | 4 ---- app/models/bucket/view/summarized.rb | 4 ++-- app/models/bucket/view/tags.rb | 4 ---- 3 files changed, 2 insertions(+), 10 deletions(-) diff --git a/app/models/bucket/view/assignees.rb b/app/models/bucket/view/assignees.rb index f1fde1570..4cb5128f1 100644 --- a/app/models/bucket/view/assignees.rb +++ b/app/models/bucket/view/assignees.rb @@ -6,10 +6,6 @@ module Bucket::View::Assignees end private - def assignee_names - assignees.map &:name - end - def assignees @assignees ||= account.users.where id: assignee_ids end diff --git a/app/models/bucket/view/summarized.rb b/app/models/bucket/view/summarized.rb index 688b027f6..955c11824 100644 --- a/app/models/bucket/view/summarized.rb +++ b/app/models/bucket/view/summarized.rb @@ -15,10 +15,10 @@ module Bucket::View::Summarized end def assignee_summary - "assigned to #{assignee_names.to_choice_sentence}" if assignee_names.any? + "assigned to #{assignees.map(&:name).to_choice_sentence}" if assignees.any? end def tag_summary - "tagged #{tag_names.to_choice_sentence}" if tag_names.any? + "tagged #{tags.map(&:hashtag).to_choice_sentence}" if tags.any? end end diff --git a/app/models/bucket/view/tags.rb b/app/models/bucket/view/tags.rb index 3bab4501d..0b92d65ff 100644 --- a/app/models/bucket/view/tags.rb +++ b/app/models/bucket/view/tags.rb @@ -6,10 +6,6 @@ module Bucket::View::Tags end private - def tag_names - tags.map &:hashtag - end - def tags @tags ||= account.tags.where id: tag_ids end