From e311d8f52184d30ef01719caabd6cd4ef3b8e3d9 Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Tue, 3 Feb 2026 18:38:39 -0500 Subject: [PATCH] Omit inactive users from board mention picker The board-scoped mention prompt was returning all users with board access, including those marked as inactive. This adds the `.active` scope to match the behavior of the account-wide mention prompt. Fixes https://app.fizzy.do/5986089/cards/3861 --- app/controllers/prompts/boards/users_controller.rb | 2 +- .../prompts/boards/users_controller_test.rb | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/app/controllers/prompts/boards/users_controller.rb b/app/controllers/prompts/boards/users_controller.rb index e5f8775a6..7950531ea 100644 --- a/app/controllers/prompts/boards/users_controller.rb +++ b/app/controllers/prompts/boards/users_controller.rb @@ -2,7 +2,7 @@ class Prompts::Boards::UsersController < ApplicationController include BoardScoped def index - @users = @board.users.alphabetically + @users = @board.users.active.alphabetically if stale? etag: @users render layout: false diff --git a/test/controllers/prompts/boards/users_controller_test.rb b/test/controllers/prompts/boards/users_controller_test.rb index 992df99f0..a49be9920 100644 --- a/test/controllers/prompts/boards/users_controller_test.rb +++ b/test/controllers/prompts/boards/users_controller_test.rb @@ -11,4 +11,16 @@ class Prompts::Boards::UsersControllerTest < ActionDispatch::IntegrationTest assert_response :success assert_select "lexxy-prompt-item", count: 3 end + + test "index excludes inactive users" do + get prompts_board_users_path(@board) + assert_response :success + assert_select "lexxy-prompt-item[search*='David']", count: 1 + + users(:david).update!(active: false) + + get prompts_board_users_path(@board) + assert_response :success + assert_select "lexxy-prompt-item[search*='David']", count: 0 + end end