From 9bdc273c76de3f1eee8cb61bc2e43c0dd56ab611 Mon Sep 17 00:00:00 2001
From: Mike Dalessio <mike@37signals.com>
Date: Thu, 7 Aug 2025 09:44:58 -0400
Subject: [PATCH] Prefer Account#slug to Account.script_name

Caching the script name in a class instance variable seemed like a bug
to me.
---
 app/models/account.rb            | 6 ++----
 app/models/card/promptable.rb    | 2 +-
 app/models/comment/promptable.rb | 2 +-
 test/models/account_test.rb      | 4 ++++
 4 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/app/models/account.rb b/app/models/account.rb
index bae08b9ce..5b193a27b 100644
--- a/app/models/account.rb
+++ b/app/models/account.rb
@@ -3,10 +3,8 @@ class Account < ApplicationRecord
 
   has_many_attached :uploads
 
-  class << self
-    def script_name
-      @script_name ||= "/#{sole.queenbee_id}"
-    end
+  def slug
+    "/#{queenbee_id}"
   end
 
   def setup_basic_template
diff --git a/app/models/card/promptable.rb b/app/models/card/promptable.rb
index bede90953..dc069d131 100644
--- a/app/models/card/promptable.rb
+++ b/app/models/card/promptable.rb
@@ -29,7 +29,7 @@ module Card::Promptable
       * Collection id: #{collection_id}
       * Collection name: #{collection.name}
       * Number of comments: #{comments.count}
-      * Path: #{collection_card_path(collection, self, script_name: Account.script_name)}
+      * Path: #{collection_card_path(collection, self, script_name: Account.sole.slug)}
 
       #{comments.last(MAX_COMMENTS).collect(&:to_prompt).join("\n")}
       END OF CARD #{id}
diff --git a/app/models/comment/promptable.rb b/app/models/comment/promptable.rb
index c8eebc28a..eb11fde80 100644
--- a/app/models/comment/promptable.rb
+++ b/app/models/comment/promptable.rb
@@ -20,7 +20,7 @@ module Comment::Promptable
         * Card title: #{card.title}
         * Created by: #{creator.name}}
         * Created at: #{created_at}}
-        * Path: #{collection_card_path(card.collection, card, anchor: ActionView::RecordIdentifier.dom_id(self), script_name: Account.script_name)}
+        * Path: #{collection_card_path(card.collection, card, anchor: ActionView::RecordIdentifier.dom_id(self), script_name: Account.sole.slug)}
         END OF COMMENT #{id}
       PROMPT
   end
diff --git a/test/models/account_test.rb b/test/models/account_test.rb
index 94d4f83dd..22fdc81dc 100644
--- a/test/models/account_test.rb
+++ b/test/models/account_test.rb
@@ -1,4 +1,8 @@
 require "test_helper"
 
 class AccountTest < ActiveSupport::TestCase
+  test "slug" do
+    account = Account.sole
+    assert_equal "/#{account.queenbee_id}", account.slug
+  end
 end