From e70827b2ca95df4ce61b5006c12ff66d4290fe3d Mon Sep 17 00:00:00 2001 From: Jorge Manrubia Date: Thu, 5 Jun 2025 15:23:15 +0200 Subject: [PATCH] Parametrize method instead of hanving methods hanging around If we need more complex calculations for those we can extract again --- app/models/card/activity_spike/detector.rb | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/app/models/card/activity_spike/detector.rb b/app/models/card/activity_spike/detector.rb index 5044c3fef..6721b946f 100644 --- a/app/models/card/activity_spike/detector.rb +++ b/app/models/card/activity_spike/detector.rb @@ -27,7 +27,7 @@ class Card::ActivitySpike::Detector end end - def multiple_people_commented? + def multiple_people_commented?(minimum_comments: 3, minimum_participants: 2) card.comments .where("created_at >= ?", recent_period.seconds.ago) .group(:card_id) @@ -40,14 +40,6 @@ class Card::ActivitySpike::Detector card.entropy.auto_clean_period * 0.33 end - def minimum_participants - 2 - end - - def minimum_comments - 3 - end - def card_was_just_assigned? card.assigned? && card_was_just?(:assigned) end