bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2683 from basecamp/mobile/bridge-button-slot

Browse Source 
Mobile / Bridge button slot
This commit is contained in:
Jay Ohms
2026-03-17 12:25:36 -04:00
committed by GitHub
parent e65db1897c 2a19bb94a0
commit f029fbfbeb
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/javascript/initializers/bridge/bridge_element.js
+6 -1
View File
@@ -5,7 +5,8 @@ BridgeElement.prototype.getButton = function() {
title: this.title, title: this.title,
icon: this.getIcon(), icon: this.getIcon(),
displayTitle: this.getDisplayTitle(), displayTitle: this.getDisplayTitle(),
displayAsPrimaryAction: this.getDisplayAsPrimaryAction() displayAsPrimaryAction: this.getDisplayAsPrimaryAction(),
slot: this.getSlot()
} }
} }
@@ -26,3 +27,7 @@ BridgeElement.prototype.getDisplayTitle = function() {
BridgeElement.prototype.getDisplayAsPrimaryAction = function() { BridgeElement.prototype.getDisplayAsPrimaryAction = function() {
return !!this.bridgeAttribute("display-as-primary-action") return !!this.bridgeAttribute("display-as-primary-action")
} }
BridgeElement.prototype.getSlot = function () {
return this.bridgeAttribute("slot") ?? "right"
}
app/views/events/index/_add_board_button.html.erb
+1 -1
View File
@@ -1,7 +1,7 @@
<div class="header__actions header__actions--end"> <div class="header__actions header__actions--end">
<div> <div>
<%= link_to new_board_path, class: "btn btn--link btn--circle-mobile", <%= link_to new_board_path, class: "btn btn--link btn--circle-mobile",
data: { controller: "hotkey", action: "keydown.b@document->hotkey#click", bridge__buttons_target: "button", bridge_title: "Add board", bridge_display_title: true, bridge_icon_url: bridge_icon("board") } do %> data: { controller: "hotkey", action: "keydown.b@document->hotkey#click", bridge__buttons_target: "button", bridge_title: "Add board", bridge_display_title: true, bridge_icon_url: bridge_icon("board"), bridge_slot: "left" } do %>
<%= icon_tag "board" %> <%= icon_tag "board" %>
<span class="overflow-ellipsis">Add a board</span> <span class="overflow-ellipsis">Add a board</span>
<kbd class="hide-on-touch">B</kbd> <kbd class="hide-on-touch">B</kbd>