From f5305b2fe61ce3d7af95345a309fec8d5fa3cd65 Mon Sep 17 00:00:00 2001
From: Mike Dalessio <mike@37signals.com>
Date: Fri, 14 Nov 2025 16:31:11 -0500
Subject: [PATCH] Use Card `number` as the model param

instead of the UUID `id`
---
 app/controllers/cards/boards_controller.rb  | 2 +-
 app/controllers/cards/columns_controller.rb | 2 +-
 app/controllers/cards_controller.rb         | 2 +-
 app/controllers/concerns/card_scoped.rb     | 2 +-
 app/controllers/prompts/cards_controller.rb | 2 +-
 app/controllers/public/base_controller.rb   | 2 +-
 app/models/card.rb                          | 4 ++++
 7 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/app/controllers/cards/boards_controller.rb b/app/controllers/cards/boards_controller.rb
index dfbc522a4..4a8e503ab 100644
--- a/app/controllers/cards/boards_controller.rb
+++ b/app/controllers/cards/boards_controller.rb
@@ -16,6 +16,6 @@ class Cards::BoardsController < ApplicationController
 
   private
     def set_card
-      @card = Current.user.accessible_cards.find(params[:card_id])
+      @card = Current.user.accessible_cards.find_by!(number: params[:card_id])
     end
 end
diff --git a/app/controllers/cards/columns_controller.rb b/app/controllers/cards/columns_controller.rb
index 3e32b1cb8..54a69f036 100644
--- a/app/controllers/cards/columns_controller.rb
+++ b/app/controllers/cards/columns_controller.rb
@@ -1,6 +1,6 @@
 class Cards::ColumnsController < ApplicationController
   def edit
-    @card = Current.user.accessible_cards.find(params[:card_id])
+    @card = Current.user.accessible_cards.find_by!(number: params[:card_id])
     @columns = @card.board.columns.sorted
 
     fresh_when etag: [ @card, @columns ]
diff --git a/app/controllers/cards_controller.rb b/app/controllers/cards_controller.rb
index 12d530717..5fa116f39 100644
--- a/app/controllers/cards_controller.rb
+++ b/app/controllers/cards_controller.rb
@@ -39,7 +39,7 @@ class CardsController < ApplicationController
     end
 
     def set_card
-      @card = Current.user.accessible_cards.find params[:id]
+      @card = Current.user.accessible_cards.find_by!(number: params[:id])
     end
 
     def ensure_permission_to_administer_card
diff --git a/app/controllers/concerns/card_scoped.rb b/app/controllers/concerns/card_scoped.rb
index 77496e160..52311809e 100644
--- a/app/controllers/concerns/card_scoped.rb
+++ b/app/controllers/concerns/card_scoped.rb
@@ -7,7 +7,7 @@ module CardScoped
 
   private
     def set_card
-      @card = Current.user.accessible_cards.find(params[:card_id])
+      @card = Current.user.accessible_cards.find_by!(number: params[:card_id])
     end
 
     def set_board
diff --git a/app/controllers/prompts/cards_controller.rb b/app/controllers/prompts/cards_controller.rb
index 25e9a8dde..4bfb36484 100644
--- a/app/controllers/prompts/cards_controller.rb
+++ b/app/controllers/prompts/cards_controller.rb
@@ -30,7 +30,7 @@ class Prompts::CardsController < ApplicationController
     end
 
     def prepending_exact_matches_by_id(cards)
-      if card_by_id = Current.user.accessible_cards.find_by_id(params[:filter])
+      if card_by_id = Current.user.accessible_cards.find_by(number: params[:filter])
         [ card_by_id ] + cards
       else
         cards
diff --git a/app/controllers/public/base_controller.rb b/app/controllers/public/base_controller.rb
index 28a1bf463..b4c33e95b 100644
--- a/app/controllers/public/base_controller.rb
+++ b/app/controllers/public/base_controller.rb
@@ -11,7 +11,7 @@ class Public::BaseController < ApplicationController
     end
 
     def set_card
-      @card = @board.cards.find(params[:id]) if params[:board_id] && params[:id]
+      @card = @board.cards.find_by!(number: params[:id]) if params[:board_id] && params[:id]
     end
 
     def set_public_cache_expiration
diff --git a/app/models/card.rb b/app/models/card.rb
index 37832092e..51b548c19 100644
--- a/app/models/card.rb
+++ b/app/models/card.rb
@@ -47,6 +47,10 @@ class Card < ApplicationRecord
     self
   end
 
+  def to_param
+    number.to_s
+  end
+
   def move_to(new_board)
     transaction do
       card.update!(board: new_board)