From fcbc0dcd59b04daff7bac54a4c781b643b3869c4 Mon Sep 17 00:00:00 2001 From: Jorge Manrubia Date: Thu, 18 Sep 2025 19:33:08 +0200 Subject: [PATCH] Fix: initialize multiselect on connect --- app/javascript/controllers/filter_settings_controller.js | 9 +++------ .../controllers/multi_selection_combobox_controller.js | 1 + 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/app/javascript/controllers/filter_settings_controller.js b/app/javascript/controllers/filter_settings_controller.js index 708f12b13..b763c44d4 100644 --- a/app/javascript/controllers/filter_settings_controller.js +++ b/app/javascript/controllers/filter_settings_controller.js @@ -4,12 +4,11 @@ export default class extends Controller { static classes = ["filtersSet"] static targets = ["field"] - connect() { - this.change() + async connect() { } - change() { - this.#toggleFiltersSetClass() + async fieldTargetConnected(field) { + this.#toggleFiltersSetClass(this.#isFieldSet(field)) } #toggleFiltersSetClass(shouldAdd) { @@ -22,11 +21,9 @@ export default class extends Controller { #isFieldSet(field) { const value = field.value?.trim() - if (!value) return false const defaultValue = this.#defaultValueForField(field) - console.debug("defaultValue", defaultValue); return defaultValue ? value !== defaultValue : true } diff --git a/app/javascript/controllers/multi_selection_combobox_controller.js b/app/javascript/controllers/multi_selection_combobox_controller.js index 75f5329f5..70a853b2b 100644 --- a/app/javascript/controllers/multi_selection_combobox_controller.js +++ b/app/javascript/controllers/multi_selection_combobox_controller.js @@ -14,6 +14,7 @@ export default class extends Controller { connect() { this.labelTarget.textContent = this.#selectedLabel + this.#updateHiddenFields() } change(event) {