From fef9c2dab61de5c10b46834acfbd6f6d46a8999f Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Sat, 8 Nov 2025 16:42:41 +0100 Subject: [PATCH] turbo_frame_tag has built-in dom_id expansion --- app/views/boards/columns/show.html.erb | 2 +- app/views/cards/columns/edit.html.erb | 2 +- app/views/cards/pins/show.html.erb | 2 +- app/views/cards/triage/_columns.html.erb | 2 +- app/views/cards/watches/show.html.erb | 2 +- app/views/my/menus/_accounts.html.erb | 2 +- app/views/notifications/settings/_board.html.erb | 2 +- app/views/public/boards/columns/show.html.erb | 2 +- app/views/sessions/menus/show.html+menu_section.erb | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/app/views/boards/columns/show.html.erb b/app/views/boards/columns/show.html.erb index 4c29f5099..56fca64ff 100644 --- a/app/views/boards/columns/show.html.erb +++ b/app/views/boards/columns/show.html.erb @@ -16,7 +16,7 @@ <% end %>
- <%= turbo_frame_tag dom_id(@column, :cards) do %> + <%= turbo_frame_tag @column, :cards do %> <% if @page.used? %> <%= with_automatic_pagination dom_id(@column, :cards), @page do %> <%= render "boards/columns/list", cards: @page.records, draggable: true %> diff --git a/app/views/cards/columns/edit.html.erb b/app/views/cards/columns/edit.html.erb index ae38fed17..e8061f9d6 100644 --- a/app/views/cards/columns/edit.html.erb +++ b/app/views/cards/columns/edit.html.erb @@ -1,4 +1,4 @@ -<%= turbo_frame_tag dom_id(@card, :columns) do %> +<%= turbo_frame_tag @card, :columns do %>
Choose a column for this card diff --git a/app/views/cards/pins/show.html.erb b/app/views/cards/pins/show.html.erb index c8ac69d7e..37f06232a 100644 --- a/app/views/cards/pins/show.html.erb +++ b/app/views/cards/pins/show.html.erb @@ -1,3 +1,3 @@ -<%= turbo_frame_tag dom_id(@card, :pin) do %> +<%= turbo_frame_tag @card, :pin do %> <%= render "cards/pins/pin_button", card: @card %> <% end %> diff --git a/app/views/cards/triage/_columns.html.erb b/app/views/cards/triage/_columns.html.erb index 591a8e256..5a92a0126 100644 --- a/app/views/cards/triage/_columns.html.erb +++ b/app/views/cards/triage/_columns.html.erb @@ -1 +1 @@ -<%= turbo_frame_tag dom_id(card, :columns), src: edit_card_column_path(card), target: "_top", refresh: "morph" %> +<%= turbo_frame_tag card, :columns, src: edit_card_column_path(card), target: "_top", refresh: "morph" %> diff --git a/app/views/cards/watches/show.html.erb b/app/views/cards/watches/show.html.erb index 44892190d..5c62559bb 100644 --- a/app/views/cards/watches/show.html.erb +++ b/app/views/cards/watches/show.html.erb @@ -1,3 +1,3 @@ -<%= turbo_frame_tag dom_id(@card, :watch) do %> +<%= turbo_frame_tag @card, :watch do %> <%= render "cards/watches/watch_button", card: @card %> <% end %> diff --git a/app/views/my/menus/_accounts.html.erb b/app/views/my/menus/_accounts.html.erb index e8c850907..a1fbe6663 100644 --- a/app/views/my/menus/_accounts.html.erb +++ b/app/views/my/menus/_accounts.html.erb @@ -1,3 +1,3 @@ -<%= turbo_frame_tag dom_id(Current.identity, :account_menu), src: session_menu_url(script_name: nil, menu_section: true, without: ApplicationRecord.current_tenant) do %> +<%= turbo_frame_tag Current.identity, :account_menu, src: session_menu_url(script_name: nil, menu_section: true, without: ApplicationRecord.current_tenant) do %> Loading... <% end %> diff --git a/app/views/notifications/settings/_board.html.erb b/app/views/notifications/settings/_board.html.erb index fe6d5b7d4..a5f485752 100644 --- a/app/views/notifications/settings/_board.html.erb +++ b/app/views/notifications/settings/_board.html.erb @@ -1,4 +1,4 @@ -<%= turbo_frame_tag dom_id(board, :involvement) do %> +<%= turbo_frame_tag board, :involvement do %>

<%= board.name %> diff --git a/app/views/public/boards/columns/show.html.erb b/app/views/public/boards/columns/show.html.erb index 2ebd44e2d..5844926fe 100644 --- a/app/views/public/boards/columns/show.html.erb +++ b/app/views/public/boards/columns/show.html.erb @@ -1,4 +1,4 @@ -<%= turbo_frame_tag dom_id(@column, :cards) do %> +<%= turbo_frame_tag @column, :cards do %> <% if @page.used? %> <%= with_automatic_pagination dom_id(@column, :cards), @page do %> <%= render "public/boards/columns/list", cards: @page.records %> diff --git a/app/views/sessions/menus/show.html+menu_section.erb b/app/views/sessions/menus/show.html+menu_section.erb index 6a0a41346..ed72443cc 100644 --- a/app/views/sessions/menus/show.html+menu_section.erb +++ b/app/views/sessions/menus/show.html+menu_section.erb @@ -1,4 +1,4 @@ -<%= turbo_frame_tag dom_id(Current.identity, :account_menu) do %> +<%= turbo_frame_tag Current.identity, :account_menu do %> <% cache [ Current.identity, @memberships ] do %> <%= collapsible_nav_section "Accounts" do %> <% @memberships.each do |membership| %>