Commit Graph

2304 Commits

Author SHA1 Message Date
Jorge Manrubia 08c5abfbdb Extract common method to query when entropy is cleaned
We were always quering auto_close_at
https://37s.fizzy.37signals.com/collections/2/cards/743
2025-06-02 18:04:14 +02:00
Jorge Manrubia a3866348fd Aria selected is a better fit here 2025-06-02 13:37:29 +02:00
Jorge Manrubia db9ee1b3b2 Merge pull request #564 from basecamp/auto-link-render
Autolink emails and URLs at rendering time
2025-06-02 12:12:39 +02:00
Jorge Manrubia d7c06702e3 Add controller to retarget links
So that internal links can skip turbo frames, and external links
open in new pages
2025-06-02 12:04:43 +02:00
Jorge Manrubia e973df97e2 Use more complete regexp
https://github.com/basecamp/fizzy/pull/564/files#r2119855866
2025-06-02 11:43:07 +02:00
Mike Dalessio 28ed744d0c refactor: Extract a Card::Entropy concern
to encompass behavior related to auto-closing and auto-reconsidering.

Note that putting this code in a single place reveals an asymmetry
between the actions:

- Auto-closing period is an optional attribute of a collection
- Auto-reconsidering period is hard-coded to 30 days for all collections
2025-06-01 16:50:12 -04:00
Jorge Manrubia 5214a74c03 Autolink emails and URLs at rendering time 2025-06-01 22:24:24 +02:00
Mike Dalessio 704e215eca Production mirrors Active Storage to :purestorage
Also include a script to copy existing blobs to Pure.

Local is still the primary.

Beta will keep using local disk service for Active Storage because I
think there are constraints on source IPs for the Pure cluster.
2025-05-31 14:37:35 -04:00
Jorge Manrubia 8924e7b42f Merge branch 'main' into creation-bugs
* main:
  update lexical
  Update AR::Tenanted to have tenanted blob keys
  Delete old multitenancy migration script
  Drop the unnecessary initializer creating storage paths
  Card shadow tweaks
2025-05-31 18:21:47 +02:00
Jorge Manrubia 5d662f1ec9 Revert "Patch for cards missing description"
This reverts commit 257c0902f4.
2025-05-31 12:30:04 +02:00
Andy Smith 68906321e8 Card shadow tweaks 2025-05-30 13:11:36 -05:00
Jorge Manrubia abcbb3277e Merge pull request #550 from basecamp/fix-card-creation
Patch for cards missing description
2025-05-30 17:37:06 +02:00
Jorge Manrubia 257c0902f4 Patch for cards missing description
The problem was that after redirecting back with morphing, the autosave mechanism
would trigger an autosave call with an empty content.

This is a first patch. The editor shouldn't be triggering these "change" events
in the first place when loading the editor.
2025-05-30 17:35:25 +02:00
Jason Zimdars 351941fa3c Icon for unassigned events 2025-05-30 08:12:12 -05:00
Jason Zimdars ee98c13db5 Tweak comment event icon 2025-05-30 08:10:55 -05:00
Jorge Manrubia 40e2dcae0b Update lexical to support placeholders and style them up 2025-05-30 11:07:42 +02:00
Jorge Manrubia 5ec09aa5d7 Not used anymore 2025-05-30 11:07:26 +02:00
Jason Zimdars 9228337c52 Don't color closed golden cards 2025-05-29 16:49:57 -05:00
Jason Zimdars f863ced9dd Merge branch 'main' into jz-5-29-25
* main:
  Use consistent rem margins
2025-05-29 16:28:15 -05:00
Jason Zimdars 88a54a246d Need to convert to srgb color space when using oklch colors in Safari
No idea why
2025-05-29 16:24:17 -05:00
Andy Smith 9efdf3385c Merge pull request #546 from basecamp/rich-text-margins
Use consistent rem margins
2025-05-29 16:14:45 -05:00
Jason Zimdars 6738d3a365 Don't go too hard, we want related cards highlighting to still work 2025-05-29 16:12:11 -05:00
Jason Zimdars 9052b76c39 Indicate golden cards in activity 2025-05-29 15:30:17 -05:00
Jason Zimdars 81eb1e6fa3 Tighten spacing, try a subtle texture 2025-05-29 15:17:51 -05:00
Andy Smith 71cfa95308 Use consistent rem margins 2025-05-29 14:37:56 -05:00
Jason Zimdars 613a877f7f Merge branch 'main' into jz-5-28-25
* main: (58 commits)
  Safari doesn't support CSS `field-sizing: content` so we can shim it for now
  Hide bubbles in trays
  update lexical
  update lexical
  Update script to deal with duplicated records
  Revert "Revert "Replace House with Lexical""
  Revert "Replace House with Lexical"
  Update actiontext lexical
  Remove trace
  Update lexical
  Use existing method
  Update lexical
  Fix merge issues
  Format
  Cleanup
  Format
  Make tests pass with action text
  Don't choke when rendering commands where the card was deleted
  Update lexical
  Simple format excerpts in activity
  ...
2025-05-29 14:21:17 -05:00
Jason Zimdars 32ae94524a Safari doesn't support CSS field-sizing: content so we can shim it for now 2025-05-29 14:19:48 -05:00
Andy Smith e0accd0fd4 Hide bubbles in trays 2025-05-29 13:37:07 -05:00
Jorge Manrubia fa04016cbe Revert "Revert "Replace House with Lexical"" 2025-05-29 14:25:16 +02:00
Jorge Manrubia 08d8b2e5ff Revert "Replace House with Lexical" 2025-05-29 14:22:27 +02:00
Jorge Manrubia f00fffe801 Remove trace 2025-05-29 13:34:16 +02:00
Jorge Manrubia 62bef018ea Merge branch 'main' into lexical
* main:
  Don't choke when rendering commands where the card was deleted
  Update tests
  Rework system events
  test: add missing assertions
  dep: bump active_record-tenanted to fix URI support
  Remove hyphen from "Un-do"
  Prevent default when handling keyboard shortcuts
  dep: update AR::Tenanted to support database URIs
  Detect platform and label the correct hotkey shortcut
  Things got too tight
  Don't require TLS for Beamer at the moment
  dep: update dependencies

# Conflicts:
#	Gemfile
#	Gemfile.lock
#	app/assets/stylesheets/comments.css
2025-05-29 12:44:14 +02:00
Jorge Manrubia 3eeba253ad Don't choke when rendering commands where the card was deleted 2025-05-29 00:39:17 +02:00
Jason Zimdars a69dbdafe1 Simple format excerpts in activity 2025-05-28 17:18:20 -05:00
Jorge Manrubia 594161b982 Make autosave work with lexical 2025-05-28 23:20:24 +02:00
Jason Zimdars f04cbf44de Fix event comment horizontal alignment
- No need to expose reactions here, either
2025-05-28 16:13:42 -05:00
Jorge Manrubia 2594bf90a7 Bye house! 2025-05-28 22:36:43 +02:00
Jason Zimdars c6c9e0d5fc Rework system events
- Restyle system events so they don't look like comments and aren't attributed to the system user
- Ensure the event creator is included in the description so it's clear who did it.
- Walk back system comment replacement. Yes, it potentially avoids embarassing people when they change their mind, it's also losing data. If two intentional assigments happen in proximity, we've been only showing the latest one,.
2025-05-28 15:26:41 -05:00
Jason Zimdars 224fb1893e Can't reliably use percentages here 2025-05-28 11:13:59 -05:00
Jason Zimdars adc84a7054 Improve color associations, add a few more types 2025-05-28 11:13:00 -05:00
Jason Zimdars 5e2c1c3501 Add a little more pizzazz to file icons 2025-05-28 10:26:32 -05:00
Jason Zimdars b50a6e57b6 Typo 2025-05-28 09:29:44 -05:00
Jason Zimdars f62c986a22 Tighten blocks, add explicit spacing 2025-05-28 09:29:13 -05:00
Kevin McConnell 50e2085e8b Remove hyphen from "Un-do" 2025-05-28 13:58:26 +01:00
Kevin McConnell 880e3d98b2 Prevent default when handling keyboard shortcuts
Without this, any default action would still happen. With Chrome on
Linux, that causes browser features to be triggered with our CTRL+J and
CTRL+K actions.
2025-05-28 08:18:49 +01:00
Jason Zimdars fc0d0cd300 Style non-previewable attachment in editor and rendered 2025-05-27 22:21:58 -05:00
Jason Zimdars bdbd556560 Center and allow natural width 2025-05-27 14:55:25 -05:00
Jason Zimdars c42395a3ab Merge branch 'main' into jz-5-26-25
* main:
  Detect platform and label the correct hotkey shortcut
2025-05-27 12:15:50 -05:00
Jason Zimdars d17134cb5c Detect platform and label the correct hotkey shortcut
Yes, Platform Agent is overkill for just this but there isn't a one-size JS solution for updating both input placeholders and other HTML text and we're likely to need it later for other things like displaying platform-specific PWA prompts.
2025-05-27 12:14:24 -05:00
Jorge Manrubia 108f711d1f Inline missing helper 2025-05-27 12:55:09 +02:00