Commit Graph

1242 Commits

Author SHA1 Message Date
Jorge Manrubia 08c5abfbdb Extract common method to query when entropy is cleaned
We were always quering auto_close_at
https://37s.fizzy.37signals.com/collections/2/cards/743
2025-06-02 18:04:14 +02:00
Jorge Manrubia db9ee1b3b2 Merge pull request #564 from basecamp/auto-link-render
Autolink emails and URLs at rendering time
2025-06-02 12:12:39 +02:00
Jorge Manrubia d7c06702e3 Add controller to retarget links
So that internal links can skip turbo frames, and external links
open in new pages
2025-06-02 12:04:43 +02:00
Mike Dalessio 28ed744d0c refactor: Extract a Card::Entropy concern
to encompass behavior related to auto-closing and auto-reconsidering.

Note that putting this code in a single place reveals an asymmetry
between the actions:

- Auto-closing period is an optional attribute of a collection
- Auto-reconsidering period is hard-coded to 30 days for all collections
2025-06-01 16:50:12 -04:00
Jorge Manrubia 5214a74c03 Autolink emails and URLs at rendering time 2025-06-01 22:24:24 +02:00
Jorge Manrubia 8924e7b42f Merge branch 'main' into creation-bugs
* main:
  update lexical
  Update AR::Tenanted to have tenanted blob keys
  Delete old multitenancy migration script
  Drop the unnecessary initializer creating storage paths
  Card shadow tweaks
2025-05-31 18:21:47 +02:00
Jorge Manrubia 5d662f1ec9 Revert "Patch for cards missing description"
This reverts commit 257c0902f4.
2025-05-31 12:30:04 +02:00
Andy Smith 68906321e8 Card shadow tweaks 2025-05-30 13:11:36 -05:00
Jorge Manrubia 257c0902f4 Patch for cards missing description
The problem was that after redirecting back with morphing, the autosave mechanism
would trigger an autosave call with an empty content.

This is a first patch. The editor shouldn't be triggering these "change" events
in the first place when loading the editor.
2025-05-30 17:35:25 +02:00
Jason Zimdars 9228337c52 Don't color closed golden cards 2025-05-29 16:49:57 -05:00
Jason Zimdars 9052b76c39 Indicate golden cards in activity 2025-05-29 15:30:17 -05:00
Jason Zimdars 32ae94524a Safari doesn't support CSS field-sizing: content so we can shim it for now 2025-05-29 14:19:48 -05:00
Jorge Manrubia fa04016cbe Revert "Revert "Replace House with Lexical"" 2025-05-29 14:25:16 +02:00
Jorge Manrubia 08d8b2e5ff Revert "Replace House with Lexical" 2025-05-29 14:22:27 +02:00
Jorge Manrubia 62bef018ea Merge branch 'main' into lexical
* main:
  Don't choke when rendering commands where the card was deleted
  Update tests
  Rework system events
  test: add missing assertions
  dep: bump active_record-tenanted to fix URI support
  Remove hyphen from "Un-do"
  Prevent default when handling keyboard shortcuts
  dep: update AR::Tenanted to support database URIs
  Detect platform and label the correct hotkey shortcut
  Things got too tight
  Don't require TLS for Beamer at the moment
  dep: update dependencies

# Conflicts:
#	Gemfile
#	Gemfile.lock
#	app/assets/stylesheets/comments.css
2025-05-29 12:44:14 +02:00
Jason Zimdars a69dbdafe1 Simple format excerpts in activity 2025-05-28 17:18:20 -05:00
Jorge Manrubia 594161b982 Make autosave work with lexical 2025-05-28 23:20:24 +02:00
Jason Zimdars c6c9e0d5fc Rework system events
- Restyle system events so they don't look like comments and aren't attributed to the system user
- Ensure the event creator is included in the description so it's clear who did it.
- Walk back system comment replacement. Yes, it potentially avoids embarassing people when they change their mind, it's also losing data. If two intentional assigments happen in proximity, we've been only showing the latest one,.
2025-05-28 15:26:41 -05:00
Kevin McConnell 50e2085e8b Remove hyphen from "Un-do" 2025-05-28 13:58:26 +01:00
Kevin McConnell 880e3d98b2 Prevent default when handling keyboard shortcuts
Without this, any default action would still happen. With Chrome on
Linux, that causes browser features to be triggered with our CTRL+J and
CTRL+K actions.
2025-05-28 08:18:49 +01:00
Jason Zimdars fc0d0cd300 Style non-previewable attachment in editor and rendered 2025-05-27 22:21:58 -05:00
Jason Zimdars d17134cb5c Detect platform and label the correct hotkey shortcut
Yes, Platform Agent is overkill for just this but there isn't a one-size JS solution for updating both input placeholders and other HTML text and we're likely to need it later for other things like displaying platform-specific PWA prompts.
2025-05-27 12:14:24 -05:00
Jorge Manrubia 108f711d1f Inline missing helper 2025-05-27 12:55:09 +02:00
Jorge Manrubia 4aa1cef99d Show previeable content in the editor
Embedded PDF previewing isnt' reliable (not working in Safari with active storage). Instead
let's align the editor with Active Storage previews and support pdf previews
2025-05-27 12:30:44 +02:00
Jason Zimdars 62c01627ec First stab at styles 2025-05-26 14:56:36 -05:00
Jorge Manrubia 7b6b81444b Minimal styles for non-image attachments 2025-05-23 14:34:16 +02:00
Jorge Manrubia de87ff9c70 Refine syntax higlighting 2025-05-23 13:28:26 +02:00
Jorge Manrubia 1c41b956a9 Highlight at rendering time too 2025-05-23 13:25:07 +02:00
Jorge Manrubia 85f03b5bf0 Use new default toolbar 2025-05-23 12:40:29 +02:00
Jorge Manrubia 0693617d83 Some initial work to reuse styles with lexical 2025-05-23 11:53:22 +02:00
Jorge Manrubia 10b2aad647 Replace House with lexical-powered actiontext 2025-05-23 11:41:08 +02:00
Jason Zimdars 53c19e8e07 Improve flow for adding stages
Previously the new stage form replaced the list, now it properly appends
2025-05-22 21:48:44 -05:00
Jason Zimdars 57f8eff3b8 Merge branch 'main' into jz-5-22-25-am
* main:
  Accidental
  Show user's activity right on their profile screen
2025-05-22 16:23:03 -05:00
Jason Zimdars 7ee65608c9 Show user's activity right on their profile screen 2025-05-22 16:18:28 -05:00
Jason Zimdars 9ae92501f2 Merge branch 'main' into jz-5-22-25-am
* main:
  Handle single items better
  Finishing touches
  Relative positioning for trays
  WIP
2025-05-22 14:27:00 -05:00
Andy Smith c3c5b38b84 Finishing touches 2025-05-22 13:36:20 -05:00
Jason Zimdars f9cae2c43b Bolder day markers 2025-05-22 13:19:51 -05:00
Andy Smith a22c69bbc3 Relative positioning for trays 2025-05-22 12:30:15 -05:00
Jason Zimdars f53f820817 Update edit template to include .comment container and avatar 2025-05-22 11:53:33 -05:00
Andy Smith cfdaffeecb Merge branch 'main' into relative-tray
* main:
  Use link, not button
  Add notification settings link
2025-05-22 11:35:58 -05:00
Andy Smith 9a9cb3340b WIP 2025-05-22 11:01:17 -05:00
Andy Smith 9221251796 Merge pull request #519 from basecamp/notification-settings
Add notification settings link
2025-05-22 11:00:53 -05:00
Jason Zimdars b90d231529 Clear the filter 2025-05-21 22:13:38 -05:00
Jason Zimdars d79f2f903f Allow filtering activity by user via user profile 2025-05-21 21:57:58 -05:00
Jason Zimdars d95838d6c3 Mentions should also include the card id and collection name 2025-05-21 15:50:15 -05:00
Jason Zimdars 18db32569a Can just call card on Notification now 2025-05-21 15:50:01 -05:00
Jason Zimdars 504946dc54 Events for closed cards should use the closed color 2025-05-21 13:35:37 -05:00
Andy Smith 5d19a1e525 Use link, not button 2025-05-21 11:14:34 -05:00
Jason Zimdars 9779adbdf5 Keep collection context when clearing filters 2025-05-21 11:11:50 -05:00
Andy Smith d660a484e6 Add notification settings link 2025-05-21 11:11:18 -05:00