Commit Graph

238 Commits

Author SHA1 Message Date
Jorge Manrubia 08c5abfbdb Extract common method to query when entropy is cleaned
We were always quering auto_close_at
https://37s.fizzy.37signals.com/collections/2/cards/743
2025-06-02 18:04:14 +02:00
Jorge Manrubia db9ee1b3b2 Merge pull request #564 from basecamp/auto-link-render
Autolink emails and URLs at rendering time
2025-06-02 12:12:39 +02:00
Jorge Manrubia d7c06702e3 Add controller to retarget links
So that internal links can skip turbo frames, and external links
open in new pages
2025-06-02 12:04:43 +02:00
Mike Dalessio 28ed744d0c refactor: Extract a Card::Entropy concern
to encompass behavior related to auto-closing and auto-reconsidering.

Note that putting this code in a single place reveals an asymmetry
between the actions:

- Auto-closing period is an optional attribute of a collection
- Auto-reconsidering period is hard-coded to 30 days for all collections
2025-06-01 16:50:12 -04:00
Jorge Manrubia 8924e7b42f Merge branch 'main' into creation-bugs
* main:
  update lexical
  Update AR::Tenanted to have tenanted blob keys
  Delete old multitenancy migration script
  Drop the unnecessary initializer creating storage paths
  Card shadow tweaks
2025-05-31 18:21:47 +02:00
Jorge Manrubia 5d662f1ec9 Revert "Patch for cards missing description"
This reverts commit 257c0902f4.
2025-05-31 12:30:04 +02:00
Andy Smith 68906321e8 Card shadow tweaks 2025-05-30 13:11:36 -05:00
Jorge Manrubia 257c0902f4 Patch for cards missing description
The problem was that after redirecting back with morphing, the autosave mechanism
would trigger an autosave call with an empty content.

This is a first patch. The editor shouldn't be triggering these "change" events
in the first place when loading the editor.
2025-05-30 17:35:25 +02:00
Jason Zimdars 32ae94524a Safari doesn't support CSS field-sizing: content so we can shim it for now 2025-05-29 14:19:48 -05:00
Jorge Manrubia fa04016cbe Revert "Revert "Replace House with Lexical"" 2025-05-29 14:25:16 +02:00
Jorge Manrubia 08d8b2e5ff Revert "Replace House with Lexical" 2025-05-29 14:22:27 +02:00
Jorge Manrubia 62bef018ea Merge branch 'main' into lexical
* main:
  Don't choke when rendering commands where the card was deleted
  Update tests
  Rework system events
  test: add missing assertions
  dep: bump active_record-tenanted to fix URI support
  Remove hyphen from "Un-do"
  Prevent default when handling keyboard shortcuts
  dep: update AR::Tenanted to support database URIs
  Detect platform and label the correct hotkey shortcut
  Things got too tight
  Don't require TLS for Beamer at the moment
  dep: update dependencies

# Conflicts:
#	Gemfile
#	Gemfile.lock
#	app/assets/stylesheets/comments.css
2025-05-29 12:44:14 +02:00
Jorge Manrubia 594161b982 Make autosave work with lexical 2025-05-28 23:20:24 +02:00
Jason Zimdars c6c9e0d5fc Rework system events
- Restyle system events so they don't look like comments and aren't attributed to the system user
- Ensure the event creator is included in the description so it's clear who did it.
- Walk back system comment replacement. Yes, it potentially avoids embarassing people when they change their mind, it's also losing data. If two intentional assigments happen in proximity, we've been only showing the latest one,.
2025-05-28 15:26:41 -05:00
Kevin McConnell 50e2085e8b Remove hyphen from "Un-do" 2025-05-28 13:58:26 +01:00
Jason Zimdars d17134cb5c Detect platform and label the correct hotkey shortcut
Yes, Platform Agent is overkill for just this but there isn't a one-size JS solution for updating both input placeholders and other HTML text and we're likely to need it later for other things like displaying platform-specific PWA prompts.
2025-05-27 12:14:24 -05:00
Jason Zimdars 62c01627ec First stab at styles 2025-05-26 14:56:36 -05:00
Jorge Manrubia de87ff9c70 Refine syntax higlighting 2025-05-23 13:28:26 +02:00
Jorge Manrubia 1c41b956a9 Highlight at rendering time too 2025-05-23 13:25:07 +02:00
Jorge Manrubia 85f03b5bf0 Use new default toolbar 2025-05-23 12:40:29 +02:00
Jorge Manrubia 0693617d83 Some initial work to reuse styles with lexical 2025-05-23 11:53:22 +02:00
Jorge Manrubia 10b2aad647 Replace House with lexical-powered actiontext 2025-05-23 11:41:08 +02:00
Jason Zimdars 9ae92501f2 Merge branch 'main' into jz-5-22-25-am
* main:
  Handle single items better
  Finishing touches
  Relative positioning for trays
  WIP
2025-05-22 14:27:00 -05:00
Andy Smith c3c5b38b84 Finishing touches 2025-05-22 13:36:20 -05:00
Jason Zimdars f53f820817 Update edit template to include .comment container and avatar 2025-05-22 11:53:33 -05:00
Andy Smith 3f873d904e Fix merge conflicts 2025-05-21 09:49:43 -05:00
Andy Smith f5dc923b43 Merge branch 'main' into tray-updates
* main:
  Tighten cards
  Stub recently closed filter
  Introduce a list style for all but the first six completed cards
2025-05-21 09:49:33 -05:00
Jason Zimdars f5e3e58be4 Tighten cards 2025-05-20 18:11:18 -05:00
Jason Zimdars 46ca6f13f6 Stub recently closed filter 2025-05-20 16:24:12 -05:00
Andy Smith 5a8da321fe Merge branch 'main' into tray-updates 2025-05-20 15:58:30 -05:00
Jason Zimdars e5f25b8d39 Introduce a list style for all but the first six completed cards 2025-05-20 15:43:24 -05:00
Andy Smith 04d01d7d10 Merge notification styles into a card variant 2025-05-20 13:50:53 -05:00
Andy Smith 900fbef686 Add card header to notifications 2025-05-19 15:20:56 -05:00
Andy Smith 8077e85019 Consolidate a few styles for card headers 2025-05-19 14:41:26 -05:00
Mike Dalessio 1d11f31fba Only render bubbles for cards in auto-closing collections 2025-05-16 10:46:04 -04:00
Mike Dalessio dddb33b483 Use a view helper to remove branching from the bubbles controller 2025-05-16 10:32:28 -04:00
Mike Dalessio 388fe2de73 Introduce a stimulus controller for bubbles
The "closing soon" bubbles were introduced in #406, and the "falling
back" bubbles in #500. However, these bubbles are part of the cached
card and so as time passes, the relative time doesn't change unless
the card is touched.

This PR introduces a stimulus controller for bubbles, which takes care
of:

- making the bubble visible during the reminder period
- calculating the relative number of days until entropy kicks in
- rendering appropriate text around the day count

ref: https://37s.fizzy.37signals.com/collections/693169850/cards/999009091
2025-05-16 10:27:00 -04:00
Andy Smith e7495046d9 Update label to "Falls back" 2025-05-15 09:49:54 -05:00
Andy Smith 15e3802a33 Add basic rules for reconsider bubble 2025-05-14 15:25:17 -05:00
Andy Smith 95298d4fce Stub out considering bubble 2025-05-14 14:53:09 -05:00
Andy Smith d568a7ff13 Create space for bubbles in containers 2025-05-14 14:39:33 -05:00
Jason Zimdars 9c4a359865 Ensure checkboxes in menus have full size click targets 2025-05-12 21:50:32 -05:00
Mike Dalessio b859c26125 Render the "last active at" timestamp in the card meta
because this is what the "closing soon" bubbles et al are triggered on.
2025-05-12 15:49:13 -04:00
Jason Zimdars ebba9a11fb Merge branch 'main' into jz-5-8-25
* main:
  Fix the flashing notif tray
  Remove unused var
  Update bubble text when 0 days
  More yellow, less orange
  Don't run solid queue in dev by default
  Add more gold to the golden cards
  Remove outlined letters, only use mono for date
  Tweak stroke values for legibility
  Try monospace font
  Text stroke outlines
2025-05-08 17:26:46 -05:00
Jason Zimdars 3bfb25ebc2 Close pinned cards when you click since the tray persists between page loads 2025-05-08 16:23:57 -05:00
Andy Smith 5281022ef3 Remove unused var 2025-05-08 15:44:48 -05:00
Andy Smith d6736a8bcf Update bubble text when 0 days 2025-05-08 15:43:56 -05:00
Andy Smith 0149f7daaa Merge pull request #467 from basecamp/completed-text-outline
Completed text outline
2025-05-08 14:36:44 -05:00
Andy Smith 9a38c28858 Merge pull request #463 from basecamp/reaction-emojis
Reaction emojis
2025-05-08 11:00:26 -05:00
Andy Smith 9eceeb2a2e Remove outlined letters, only use mono for date 2025-05-07 16:44:02 -05:00