2ced8e643d
Clarify a bit
2025-04-16 17:01:32 +02:00
2757cd8e62
Dont render inline
2025-04-16 16:49:16 +02:00
4bb9085737
Hide implementation detail of reading
2025-04-16 16:41:22 +02:00
397fc1d2bd
Only broadcast creations
2025-04-16 16:21:54 +02:00
b9f5293231
Style
2025-04-15 16:15:13 +02:00
f30a9308d2
Line up scopes in order of the flow
2025-04-15 16:13:54 +02:00
8e479dddba
Clearer still
2025-04-15 16:04:11 +02:00
5d22809e29
No public use of this concept, so inline it
2025-04-15 16:03:14 +02:00
680611503d
Distinguish between administering and just changing
2025-04-15 16:00:29 +02:00
a6a96fd5c8
Dont repeat the same checks from doing, make it clearer where the difference is
2025-04-15 15:55:29 +02:00
af0a42080b
Allow users to edit themselves
2025-04-15 15:35:39 +02:00
5b524254b9
Merge pull request #403 from basecamp/commit-to-single-account
...
The tenanted db is the account scope
2025-04-13 07:58:12 +02:00
cf93da6886
Get rid of card_title
...
We can just set untitled on assignment of empty
2025-04-12 21:29:56 +02:00
c463f342bf
Ensure user is returned
2025-04-12 20:30:28 +02:00
a579e67057
We are not using the parameter
2025-04-12 20:08:42 +02:00
6bbf68a4f9
The tenanted db is the account scope
2025-04-12 20:06:34 +02:00
760cbb6c99
Drop boosts
...
Killed by design.
2025-04-12 18:52:54 +02:00
1a70be06c6
Fix trailing CR
2025-04-12 13:37:31 +02:00
706178f3c4
Better naming
2025-04-12 13:33:54 +02:00
d4a31fec6d
Dont overload the main transaction
...
Even if we are going to get rid of this cleanup_events stuff.
2025-04-12 13:33:06 +02:00
2357c75063
Reads better with a verb first
2025-04-12 13:09:49 +02:00
0031ce34ea
Correct order
2025-04-12 11:46:17 +02:00
e4efe446e6
Simlpe callback is actually enough
...
Since the Comment already knows about the card.
2025-04-12 11:45:34 +02:00
f2c2b0492e
Have to solve this in an overhaul of events
2025-04-12 11:42:50 +02:00
f5b30456a0
Comments arent part of event summaries any more
2025-04-12 11:42:41 +02:00
e75d2bcaa1
Scopes last
2025-04-12 11:37:39 +02:00
d8f9511e08
Unused
2025-04-12 11:34:56 +02:00
1a9a65fffb
Unused
2025-04-12 11:31:50 +02:00
2f8a9bed0e
There is only ever one account per database
...
So there is no protection in scoping things by account cc @jorgemanrubia
2025-04-12 11:30:28 +02:00
81a89dbda1
Comments should always have messages
2025-04-12 11:23:45 +02:00
cef8899bda
Comments are not currently used as notifiables
2025-04-12 11:18:59 +02:00
9f1c3ae046
Note my discontent
2025-04-12 11:17:01 +02:00
1c4e0d3ccc
Not using the destroy callback
2025-04-12 11:11:30 +02:00
63c05220ce
Clearer naming
2025-04-12 11:09:55 +02:00
ecffdc2af4
Spacing
2025-04-12 11:07:27 +02:00
735a12abfc
Better name
2025-04-12 11:07:02 +02:00
9f7bbbef58
Split draft commenting back out to a dedicated concern
2025-04-12 11:05:56 +02:00
27d90abbd6
Reduce the direct knowledge of comments inside the card
2025-04-12 11:04:16 +02:00
b698eefa06
Messageables already have access to the card
2025-04-12 11:00:15 +02:00
60a0360203
Remove more activity scoring related to comments
2025-04-12 10:52:48 +02:00
fb733b9a60
No more tracking commenting as an activity for sorting
...
We are doing away with all the automated activity scoring, but for now
lets just get rid of it for comments.
2025-04-12 10:50:25 +02:00
81f431d946
Comment-specific behavior needs to live in the comment
...
This really is a bit of a tangled mess. Everyone knows everything about
everyone else.
2025-04-12 10:39:56 +02:00
bb64adfd1b
Most important methods first
2025-04-12 10:39:19 +02:00
4d2ba5b432
Use the explicit method for now
2025-04-12 10:27:57 +02:00
80bc1dd163
Reactions dont have any callbacks so can just be deleted
2025-04-12 10:15:38 +02:00
6f3ac772ea
Merge branch 'main' into comments-refactoring
...
* main:
Show more of the summary before truncating
Improve event summaries
Add this for debugging empty event cards
Some actions shouldn't be available to closed cards
Nicer spacing when the large button isn't present
Update `card-color` in a couple more places
Don't show the engagement toggle on closed cards
Show more of the summary before truncating
Improve event summaries
Remove shadows from notifications you can't see
Add this for debugging empty event cards
Some actions shouldn't be available to closed cards
Nicer spacing when the large button isn't present
Update `card-color` in a couple more places
Don't show the engagement toggle on closed cards
Style drafted cards
Considering needs to include drafted cards or you'll never be able to see them
This item makes no sense until it's saved
Tighten engagement switch design, only display it for published cards
2025-04-12 09:56:28 +02:00
5997ef2c70
Considering needs to include drafted cards or you'll never be able to see them
2025-04-11 12:08:05 -05:00
6f1c802292
Content being required via UI and db constraint is enough
...
We are not using/displaying model validations anywhere
2025-04-11 18:28:23 +02:00
a8aa2c4f80
Clean up the controller
2025-04-11 16:49:55 +02:00
f4ce57e308
Move comments under cards
2025-04-11 16:21:44 +02:00
David Heinemeier Hansson