Commit Graph

282 Commits

Author SHA1 Message Date
Jorge Manrubia 4f3f322528 Rename inconsistency: go with goldness 2025-04-11 10:22:18 +02:00
Jorge Manrubia 806609e77b Use gild/ungild 2025-04-11 10:20:06 +02:00
Jorge Manrubia 492a42ba92 Not needed anymore 2025-04-11 09:57:45 +02:00
Jason Zimdars 5560976091 Merge branch 'main' into gold-cards
* main:
  Try a segmented toggle for engagement
  Fix tests
  Rework min card design and meta section for all cards
  Move `title` to the `img` element so we get hover in both cases
  Remove sorting filter UI
  Sort Considering and Doing by `updated_at`
  Restore comment action icon
  Fix dot escaping container
  Seen cards should be flat
  Ensure overflow cards are hidden
  Arrow needs to match derived color
  Dialog target needs to be present
  This isn't necessary in the mini card template
  Revert "The button and dialog need not render in previews"
2025-04-10 16:42:45 -05:00
Jason Zimdars 0c107c5894 Fix that cards which were Drafted or in Considering were also being displayed in Doing
CC: @jorgemanrubia
2025-04-10 16:42:40 -05:00
Jason Zimdars 1387ad2581 Sort Considering and Doing by updated_at 2025-04-10 11:06:55 -05:00
Jorge Manrubia fac2fce3d5 Rename scope 2025-04-10 17:18:02 +02:00
Jorge Manrubia 2e5b25a30c Always place golden cards first 2025-04-10 17:05:30 +02:00
Jorge Manrubia 7406a1039f Add models to track gold cards and implement basic toggle behavior 2025-04-10 16:48:12 +02:00
Jorge Manrubia c7b3b45977 Merge pull request #391 from basecamp/cards-pagination-2
Paginate collection cards
2025-04-10 15:10:54 +02:00
Jorge Manrubia 695247ae9b Paginate collection cards 2025-04-10 15:09:56 +02:00
Jason Zimdars f9fb633cba Add colors to stages 2025-04-09 15:45:08 -05:00
Jason Zimdars c55501a6c8 Remove unused display count feature 2025-04-09 14:54:53 -05:00
Jorge Manrubia 221bbb3247 Fix renames that the scripts missed 2025-04-09 14:56:59 +02:00
Jorge Manrubia 723e6d94f5 Rename bubbles => cards 2025-04-09 14:50:58 +02:00
Mike Dalessio d111fb50c3 Default collection permissions to "all access"
ref: https://37s.fizzy.37signals.com/buckets/693169853/bubbles/999008744
2025-04-07 12:48:43 -04:00
David Heinemeier Hansson 23892296da Move readings under bubbles and out of double nesting 2025-04-07 14:06:56 +02:00
Jorge Manrubia fea5463642 Merge pull request #372 from basecamp/scope-accesses
Scope data by account
2025-04-07 13:35:44 +02:00
Jorge Manrubia 9b4169c7ca Scope data by account
With a single database this problem is not as bad, but it feels
safer to do things right. Also, not everyone in an account has access
to all the bubbles.
2025-04-07 13:09:49 +02:00
Jorge Manrubia 40df93eed7 Max max age for your own avatar
So that you don't get confused when you don't see it update
after changing it.
2025-04-07 06:59:36 +02:00
David Heinemeier Hansson 565ee0f548 Dont have to spell this out when there are no other formats 2025-04-06 21:09:49 +02:00
David Heinemeier Hansson c06802856e Move boosts under bubbles
But also remove the need for a bucket nesting
2025-04-06 21:04:28 +02:00
David Heinemeier Hansson 4fd1472fae Move bubble watch out from the needless bucket nesting 2025-04-06 19:22:40 +02:00
David Heinemeier Hansson eb0614c44f Use a more ergonomic API for watching
Passing a boolean vs using explicit on/off methods feel too low level
and doesnt read right in most of these cases.
2025-04-06 19:17:26 +02:00
David Heinemeier Hansson 95cd60b919 Style 2025-04-06 18:49:19 +02:00
David Heinemeier Hansson b8bcfdee40 This is not just param extraction, we sanitize too 2025-04-06 13:29:43 +02:00
David Heinemeier Hansson 5e78a1dab1 Make it clearer that this takes a title string not a tag object 2025-04-06 13:28:52 +02:00
David Heinemeier Hansson ee22e69e6e Move taggings to bubbles 2025-04-05 22:19:12 +02:00
David Heinemeier Hansson 540316e639 Move taggings under bubbles 2025-04-05 21:54:48 +02:00
David Heinemeier Hansson 5134985418 Simplify the assignments flow
We now submit on every selection, so we dont need a whole form and
checkboxes to do it.

This needs some design tune-up after the change, though. cc @jzimdars
2025-04-05 17:14:57 +02:00
David Heinemeier Hansson e825f1d33f No need for the partial indirection 2025-04-05 16:06:44 +02:00
David Heinemeier Hansson 3b5f8c2e6a Note the security oddity of finding straight off root 2025-04-05 15:56:12 +02:00
David Heinemeier Hansson 851be126ab Emphasize where this pin is showing up 2025-04-05 15:55:11 +02:00
David Heinemeier Hansson b4c0fec7a6 Move Assignments under Bubble
Since that what we are assigning
2025-04-05 15:51:53 +02:00
David Heinemeier Hansson e69c1bd0a1 Break pins out of the double nesting
Its cumbersome and needless
2025-04-05 15:45:16 +02:00
David Heinemeier Hansson f725a69dee Let BubbleScoped find its own bucket
Then it will be easier to break things that are double nested out of
that nesting.
2025-04-05 15:44:47 +02:00
David Heinemeier Hansson e4c6fe4b55 Shape up pinning API and broadcast in the controller 2025-04-05 15:15:48 +02:00
David Heinemeier Hansson bfb7ed1216 Move pins to my space
We used the my/ space in HEY to reflect anything that was primarily
hinged off Current.user. Good to use here too.
2025-04-05 14:57:24 +02:00
David Heinemeier Hansson 7494dad91e Drop the toggles scope for taggings as well 2025-04-05 14:20:06 +02:00
David Heinemeier Hansson 384de24132 Get rid of odd toggles concept
This is just assignments.
2025-04-05 14:16:04 +02:00
David Heinemeier Hansson 8ff017fc5b Only one invocation of this, not carrying the worth of its indirection
Generally I am wary of including global state checks in the belly of
models. It is one thing to do it as a default parameter, but I think it
is too far to do it inside an actual method.
2025-04-05 12:40:08 +02:00
Jorge Manrubia 77e9e4b05f Merge pull request #353 from basecamp/sort-completed
Sort completed bubbles by most recently completed first
2025-04-04 17:12:05 +02:00
Jorge Manrubia a7fc325184 Format 2025-04-04 17:01:30 +02:00
Jorge Manrubia 4ac2511771 Remove turbo frame for editing stages 2025-04-04 16:59:51 +02:00
Jorge Manrubia 6eb9240993 Move card preview templates to its own folder 2025-04-04 16:26:51 +02:00
Jorge Manrubia f437aecf00 Sort completed bubbles by most recently completed first 2025-04-04 15:39:00 +02:00
Jorge Manrubia 0e3f756a27 Merge pull request #351 from basecamp/close-with-label
Close as...
2025-04-04 15:09:47 +02:00
Jorge Manrubia 977199e189 Sort by newest first by default
https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008839
2025-04-04 14:21:06 +02:00
Jorge Manrubia 77d0cd5e7f Close as working with default fallback label 2025-04-04 10:59:53 +02:00
Jorge Manrubia dbae700554 Merge pull request #346 from basecamp/two-columns-refactor
Refactor collections perma + support for doing/considering
2025-04-04 08:29:17 +02:00