Commit Graph

481 Commits

Author SHA1 Message Date
Jorge Manrubia 1bb8de8564 Fix tests 2025-09-29 13:13:40 +02:00
Jorge Manrubia 6e1e0eddd8 Add pagination to the rest of the sections 2025-09-28 14:28:13 +02:00
Jorge Manrubia 72fb15dd0f Pagination working for columns
Bring pagination system from KIA that is compatible with page refreshes
2025-09-28 14:21:16 +02:00
Jorge Manrubia f3959ced0d Extract expander to partial 2025-09-27 07:57:36 +02:00
Jorge Manrubia b94af96e8f Merge branch 'collapsing-columns' into collapsing-columns+domain
# Conflicts:
#	app/helpers/cards_helper.rb
2025-09-26 18:48:48 +02:00
Jorge Manrubia f5c7d3d35b Reload frames with morphing to pervent blink when re-rendering columns 2025-09-26 16:38:04 +02:00
Jorge Manrubia 5c52b6b056 More fidelity for D&D cards
- Reload source frame with morphing. E.g: to deal with pagination or with the D&D placeholder
- Decrease source counter with JS
2025-09-26 15:30:09 +02:00
Jorge Manrubia aa9d7664ef Move cards to different columns from the perma 2025-09-26 11:14:02 +02:00
Andy Smith 418406e6ee Align column overflow better 2025-09-25 11:45:25 -05:00
Andy Smith d9958d01d0 Stub out column menus 2025-09-24 15:38:01 -05:00
Andy Smith 37cc95f7ce Hide stages within columns 2025-09-24 13:23:15 -05:00
Andy Smith 113063ada3 Add wavy BG to Stream workflow stage 2025-09-24 12:03:58 -05:00
Jorge Manrubia 2f6a639682 Prepare entropy code for the new auto postpone approach 2025-09-24 16:22:42 +02:00
Jorge Manrubia c96334ca3d Merge main into collapsing-columns branch
Resolves merge conflicts by:
- Integrating new Cards::Columns architecture from main
- Preserving collapsible columns functionality
- Maintaining stage-specific doing columns support
- Using new column-based rendering while keeping expanders

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-09-24 10:19:04 +02:00
Andy Smith 82bac33f41 Tidy up the expander 2025-09-23 15:15:41 -05:00
Stanko K.R. 24ac7cd00d Add custom labels for Webhooks 2025-09-23 18:00:13 +02:00
Andy Smith 7fec5a98c1 Use class_names helper 2025-09-22 11:22:40 -05:00
Andy Smith 2ecbe2cb7e Add option for icon-only involvement buttons 2025-09-19 16:19:37 -05:00
Jorge Manrubia 64b46d37e4 Toggle filters in the hey menu too
This also fixes a problem where the label in the menu for the filters was wrong
2025-09-19 16:52:13 +02:00
Andy Smith ccf4442562 Merge pull request #1119 from basecamp/nav-filter-handle-collapsed-sections
Nav filter handle collapsed sections
2025-09-18 13:32:01 -05:00
Jorge Manrubia 690734d8ab Fix several caching issues when viewing card permas 2025-09-18 10:58:09 +02:00
Andy Smith c7737f6e35 Merge branch 'main' into nav-filter-handle-collapsed-sections
* main: (55 commits)
  Use polymorphic_url instead of path
  Rename redundant name
  Exclude inactive users
  Send HTML to campfire instead of JSON
  Fix crash due to missing default value
  Bundle rails from main
  Sort alphabetically
  Now that we have space on the left, move it there
  Add missing actions
  Remove URL field from edit form
  Improve active state
  Don't need to navigate this list
  Style show view
  Style web hooks forms and list WIP
  Rename methods for clarity
  Use HTML5 validation for the URL
  Change the icon if there are webhooks on a collection
  Simplify delinquency tracking
  Scope Webhooks to Collections
  Limit access to webhooks to admins
  ...
2025-09-17 11:12:31 -05:00
Andy Smith ec0433d721 Remember localStorage state after filtering 2025-09-16 14:46:21 -05:00
Andy Smith 3cad86411f WIP 2025-09-16 14:14:38 -05:00
Jorge Manrubia 6fe28c53e7 Extract common method 2025-09-16 13:06:01 +02:00
Jason Zimdars c56eb9ecd1 Cards in On Deck adopt some entropy behavior as ones in Doing 2025-09-16 13:06:01 +02:00
Stanko Krtalić 0e2c7f7d4d Escape HTML everywhere where html_safe is used (#1114)
* Escape HTML everywhere where html_safe is used
* Mark search results as HTML safe at the attribute
2025-09-16 11:52:15 +02:00
Andy Smith 27a99b4e1d Remember nav section collapsed state 2025-09-15 16:29:32 -05:00
Andy Smith 60e515e462 Merge pull request #1098 from basecamp/collapsible-nav-sections
Collapsible nav sections
2025-09-15 12:54:21 -05:00
Mike Dalessio 2630e4bd74 Extract 37id and QB controllers, models, and tests 2025-09-13 16:03:02 -04:00
Mike Dalessio 8f39c015ea Tests now pass with local authentication
This is the first step of a multi-step SaaS engine extraction.

Looking ahead to an open source release, we need to make sure that
local authentication is treated as an "official" option, and not just
a hack I added for Kevin to do load testing outside our DC. So this PR
gets to green, and adds a CI step in "local authentication" mode.

This all probably feels a little hacky to you, Reader, but the goal of
this change is to ease the next step, which will be extracting the
37id and Queenbee integrations into a proprietary "SaaS mode" engine.

In service of that goal, this commit simply wraps all of the dependent
code and tests with a conditional check on
`config.x.local_authentication`.
2025-09-13 15:21:00 -04:00
Jason Zimdars 154c1a8a15 This was a debug value 2025-09-12 18:09:52 -05:00
Jason Zimdars 36c3571848 Fix spacing, simplify layout 2025-09-12 16:08:24 -05:00
Jason Zimdars f0a2d50195 Move to constant, whitespace 2025-09-12 15:33:09 -05:00
Jason Zimdars 24d4bd2551 Limit to one row 2025-09-12 14:32:42 -05:00
Andy Smith cab6992555 Merge branch 'main' into collapsible-nav-sections
* main: (32 commits)
  Fix VCR fixtures
  Format
  Touch user on modification to invalidate cache
  Fix add card not working in the cards screen
  Submit and refresh results as you type terms
  Fix: When expanding filters, submitting filters should keep the filters expanded
  Invalidate cache when filter changes
  Switch to gpt-5-chat
  Reorded method and remove unnecessary param
  Add migration to convert accesses
  Handle filter toggles with JS
  Prevent glitch where you see the filter bar expanded when you clear it
  Remove unused templates
  Fix: all collections link not working after moving to turbo frame
  Restore cache I deleted by mistake
  Speed up filter expansion with turbo stream
  Fix: filtering collections not working after moving menu to turbo frame
  Respect params when loading the menu or they won't be reflected!
  Add HTTP cache for the menu
  Load main menu lazily with a turbo frame
  ...
2025-09-12 12:53:44 -05:00
Andy Smith 373b139b9a Add collapsible nav sections 2025-09-12 12:32:32 -05:00
Andy Smith e1a428b46b Straighten out icon and radio sizes 2025-09-12 11:59:16 -05:00
Jorge Manrubia ba3b782d21 Merge branch 'main' into watchers
* main:
  Fix add card not working in the cards screen
  Submit and refresh results as you type terms
  Fix: When expanding filters, submitting filters should keep the filters expanded
  Invalidate cache when filter changes
  Switch to gpt-5-chat
  Handle filter toggles with JS
  Prevent glitch where you see the filter bar expanded when you clear it
  Remove unused templates
  Fix: all collections link not working after moving to turbo frame
  Restore cache I deleted by mistake
  Speed up filter expansion with turbo stream
  Fix: filtering collections not working after moving menu to turbo frame
  Respect params when loading the menu or they won't be reflected!
  Add HTTP cache for the menu
  Load main menu lazily with a turbo frame
  Inline :has(&) as it's REALLY slow in Safari
  Extract helper method
  Remove transition that is making Safari choke when navigating to Fizzy menus
  Reduce page size to reduce load for processing local times on initial page load
  Avoid having to parse strings

# Conflicts:
#	app/views/cards/index/_add_card_button.html.erb
#	test/vcr_cassettes/period_highlight_test-test_don_t_generate_highlights_for_existing_periods.yml
#	test/vcr_cassettes/period_highlight_test-test_generate_period_highlights.yml
#	test/vcr_cassettes/user/highlights_test-test_don_t_generate_highlights_for_existing_periods.yml
#	test/vcr_cassettes/user/highlights_test-test_generate_weekly_highlights.yml
2025-09-12 18:52:17 +02:00
Andy Smith a2fd470c63 Refactor popup item class names 2025-09-12 11:27:47 -05:00
Jorge Manrubia bf6f4cf2ba Reorded method and remove unnecessary param 2025-09-12 14:46:05 +02:00
Jason Zimdars 34e5b14b58 Move the watchers list into the turbo frame
Passes around a param to opt-out of rendering the watchers on the
notification settings screen
2025-09-11 18:05:34 -05:00
Jason Zimdars f9aed44fd2 Move involvement toggle and display all the watchers 2025-09-11 16:22:57 -05:00
Jason Zimdars e68b344cc2 Remove _Everything_ inolvement 2025-09-11 12:34:31 -05:00
Jorge Manrubia 05d3375a7d Avoid having to parse strings 2025-09-11 16:29:07 +02:00
Jorge Manrubia 4e72566856 Flatten card resource
We only need the parent collection for creating cards. Carrying it in the
rest of actions is a hassle.
2025-09-10 11:24:23 +02:00
Jorge Manrubia d533f05c7b Use vanilla resources for handling notifications 2025-09-10 09:17:57 +02:00
Jorge Manrubia 03815f810e Make sure time tags take vertical space until they are loaded
https://fizzy.37signals.com/5986089/collections/2/cards/1592
2025-09-09 13:57:54 +02:00
Jason Zimdars d7844a4105 Merge pull request #1031 from basecamp/improve-workflows
Improve workflows
2025-09-08 10:32:50 -05:00
Jorge Manrubia cb67352275 Don't render HTML stripping the tags for comment bodies, use to_plain_text instead
This will prevent error when generating notification bundles such as:

Type	ActionView::Template::Error
Message	undefined method 'rails_blob_path' for an instance of #<Class:0x00007fbb7e0c2a88>

We could just use the _url variant but this feels better nevertheless
2025-09-08 08:41:18 +02:00