Stanko Krtalić
24c20ad55f
Merge pull request #2244 from basecamp/expose-card-ids-on-comments
...
Expose the card ID and URL on comments
2025-12-24 08:50:47 +01:00
Stanko K.R.
822c3bb2ad
Expose the card ID and URL on comments
2025-12-24 08:45:31 +01:00
Jason Zimdars
5716303c22
Rename
...
It feels odd to have a `.system` class in the `.comment` namespace.
Might as well make it really obvious if we're going to rename it
2025-12-22 11:12:46 -06:00
Alexander Zaytsev
5657ee0455
Remove extra space
2025-12-19 09:37:07 +01:00
Alexander Zaytsev
e52eba9c4e
Rename .comment--system to .system-comment
2025-12-19 09:34:23 +01:00
Alexander Zaytsev
cc6b5cba9c
Use hash for conditional class
2025-12-19 09:33:07 +01:00
Jason Zimdars
ae5cb096f9
Let's just use the class we already have
2025-12-17 20:06:38 -06:00
Alexander Zaytsev
035c5f97a1
Use simpler selectors to target system comments
2025-12-17 10:09:35 +01:00
Jason Zimdars
8659e19671
Collapse and expand system comments
2025-12-16 14:21:48 -06:00
Kevin McConnell
e2292a1739
Update cached fragments
2025-12-15 13:23:57 +00:00
Mike Dalessio
c6725fdca0
Bust comment view cache
...
because, unlike ordinary view file changes, the change to Action Text
attachment rendering in e9cb2956 doesn't bust the cache automatically.
2025-12-14 13:05:45 -05:00
Stanko K.R.
3257e4a6e9
Inline partials
2025-12-10 15:27:56 +01:00
Stanko K.R.
cbbddf9ffe
Add cache directives
2025-12-10 09:23:53 +01:00
Stanko K.R.
7b30ca203e
Add index actions for Comments and Columns
...
Also, fix crash when a deactivated user is serialized (they don't have
an identity).
2025-12-10 09:23:52 +01:00
Stanko K.R.
d16b3756de
Add API for reactions
2025-12-10 09:23:52 +01:00
Stanko K.R.
41115eaf87
Add API for comments CRUD
2025-12-10 09:23:52 +01:00
gijigae
e03c002efd
Fix Japanese IME input handling for tags and form fields
...
When typing in Japanese, the Enter key is used to confirm kanji conversion
during IME composition. Previously, pressing Enter would immediately save
the tag, which prevented users from completing the conversion.
Changes:
- Add isComposing check to navigable_list_controller.js Enter handler
- Add IME composition tracking to form_controller.js
- Add compositionstart/compositionend event handlers to tag, step, and
reaction input fields
- Add preventComposingSubmit action to prevent form submission during
composition
This fix supports all IME input methods (Japanese, Chinese, Korean, etc.)
using standard browser composition events.
2025-12-06 17:26:35 +09:00
Jorge Manrubia
11249949eb
Fix: edit comment button disappears when morphing the page
...
This also replaces the ad-hoc stimulus controller with the pure-css based
solution we recently added.
https://app.fizzy.do/5986089/cards/3243
2025-12-02 07:06:50 +01:00
Jason Zimdars
8ff5eb0feb
No need to indicate these, they're common
...
But show a tooltip all the same
2025-12-01 14:14:27 -06:00
Mike Dalessio
79c9ea2ce1
Remove a bunch of N+1s
...
related to notification and comment rendering
2025-11-27 11:08:45 -05:00
Jason Zimdars
e26845709a
Disable focus ring
2025-11-26 11:24:13 -06:00
Mike Dalessio
e0aa1d257e
Drop User.system and replace with Account#system_user
2025-11-24 13:23:57 -05:00
Stanko K.R.
6f8364071c
Fix call to non-existant blur action
2025-11-21 17:57:38 +01:00
Stanko K.R.
ac2ed4851e
Blur comment field after submission
2025-11-21 15:59:22 +01:00
Jason Zimdars
25e2d98c35
Don't label these, they're expected and obvious (I think)
2025-11-19 16:26:55 -06:00
Jason Zimdars
0259cb860d
Fix awkward wrapping on mobile
2025-11-19 16:16:16 -06:00
Jason Zimdars
eeeb3a6e7e
Remove extra mark-up
2025-11-17 17:38:25 -06:00
Jason Zimdars
51a9edf419
Contain hotkeys inside the button
2025-11-17 17:35:14 -06:00
Jorge Manrubia
906c5245ce
Prefer inline partials
2025-11-17 11:29:08 +01:00
Jorge Manrubia
c247a430fb
Favor consistent style that avoids explicit dom_id calls
2025-11-17 11:21:50 +01:00
Jorge Manrubia
17876b30d4
Manage comments with streams
...
We replacing the full list of comments within a turbo frame, which didn't feel great when you had several comments.
2025-11-13 17:12:46 +01:00
Jorge Manrubia
bddbc0c0ac
Make comment body area permanent so that morphing/refresh does not touch it
2025-11-13 16:52:54 +01:00
Jason Zimdars
197cf12512
"Post" is too terse
...
I think we can go back to the longer label now that the hotkeys aren't
inside the button
2025-11-12 17:12:39 -06:00
Jorge Manrubia
2dab14ef64
Replace the full container since we want to get back to the initial state
...
To see the boost button again
2025-11-12 18:14:31 +01:00
Jorge Manrubia
2d96e7c9c6
Use streams to update/remove reactions
...
Prevents race condition causing flickering https://app.fizzy.do/5986089/cards/2906
This will prevent these from udpating live, but we will tackle that as part of live card
updates with page refreshes, which I will tackle soon.
2025-11-12 18:04:20 +01:00
Jason Zimdars
7d095c87b1
Simplify label, try showing the hotkey outside the button when we have room
2025-11-11 17:54:56 -06:00
Jason Zimdars
2afadd41e8
Indicate shortcut on comment submit
2025-11-10 18:20:58 -06:00
Andy Smith
6aeceb56e2
Tighten up reactions styles
2025-11-06 12:49:20 -06:00
Jorge Manrubia
39ec6cf062
Replace collection with board in the code, tests green
2025-11-05 13:41:12 +01:00
Jorge Manrubia
03a345609e
Baseline replacing collection with board across code
2025-11-05 13:31:54 +01:00
Jason Zimdars
48fd1f3502
Use debounced submit to prevent duplicate submissions
2025-10-30 12:16:35 -05:00
Andy Smith
6ab46e869e
Use BC icon
2025-10-29 16:53:06 -05:00
Andy Smith
93834ffc5f
Use boost icon
2025-10-29 16:43:34 -05:00
Andy Smith
b2a83f1625
Add Basecamp-style boosts
2025-10-27 16:59:57 -05:00
Andy Smith
6b0fc35627
Revert "Reactions"
2025-10-27 16:16:57 -05:00
Andy Smith
0b743037db
Set explicit button type
2025-10-27 15:57:59 -05:00
Andy Smith
ce4899d089
Better trigger alignment without reactions
2025-10-27 15:05:40 -05:00
Andy Smith
5180555e30
Position the reaction button when empty
2025-10-27 14:49:20 -05:00
Andy Smith
fdec3f2155
Add extra enojis
2025-10-27 14:35:49 -05:00
Andy Smith
fe00a43786
Nicer submit and cancel buttons
2025-10-27 14:27:55 -05:00