Jose Farias
2a9be42c4e
Use count cache instead of counting comments in calculating score
2024-11-19 13:26:25 -06:00
Jose Farias
0c38699dec
Merge branch 'main' into activity-score
...
* main: (22 commits)
Fix layout issue that caused comment form to be unselectable
Stick with stock buttons for now
Still a little odd that it's a separate form but this conceptually belongs here
We've got a utility for this
Fix navbar alignment
Kind of hate that icon, let's try something else
Use new bubble shape
Prevent bubble getting squished
Fix image fit, try animation
Don't assume `@filter` is set
Clicking assignees filters by that assignee
Restore behavior: clicking tags filters by that tag
Make these consist from view-to-view
Improve hover motion for meta bubbles
No longer used
Improve assignee bubble display, especially when there are multiple assignees
name -> key
** not required
Swap one? and many? branches
Change title based on selected buckets
...
2024-11-19 13:09:57 -06:00
Jose Farias
0c51129e1e
name -> key
2024-11-18 12:04:52 -06:00
Jose Farias
0995eee074
Turn filter chips into links
2024-11-18 11:34:44 -06:00
Jose Farias
f17b060906
Move rescoring concerns to bubble
2024-11-15 19:48:53 -06:00
Jose Farias
b4e8adca47
Pre-calculate comment counts and activity scores
2024-11-15 18:17:42 -06:00
Jose Farias
fb04249209
Make filters into a simple form
2024-11-14 21:50:38 -06:00
Jose Farias
a2092efc0a
Add assigners to filter summary
2024-11-13 14:27:23 -06:00
Jose Farias
cc2b799b1c
Allow assigner ids param
2024-11-13 14:01:31 -06:00
Jose Farias
33d1f7f022
Sort filter params before hashing
...
So that param order doesn't matter
2024-11-13 13:55:46 -06:00
Jose Farias
4dfba46142
Fix tests
2024-11-13 13:55:30 -06:00
Jose Farias
458a6a1ac2
Wire up assigner filters
2024-11-13 13:34:51 -06:00
Jose Farias
72ddd18bcc
Spell out button_to params
2024-11-13 13:23:12 -06:00
Jose Farias
8301db767a
Add frame to search terms form
2024-11-12 20:20:38 -06:00
Jose Farias
ec16237bf4
Render each kind of filter in its own frame
2024-11-12 19:58:19 -06:00
Jose Farias
932fc341ce
Add terms to filter
2024-11-12 19:14:40 -06:00
Jose Farias
e399702217
Clean up Filter class methods
2024-11-12 16:36:59 -06:00
Jose Farias
e53df951f2
KNOWN_PARAMS -> PERMITTED_PARAMS
2024-11-12 16:36:38 -06:00
Jose Farias
6384d5eb0e
Remove most_active as index option
2024-11-11 17:29:16 -06:00
Jose Farias
0baaf5d87f
Wire up filter form sans search
2024-11-11 13:46:15 -06:00
Jose Farias
d455b72906
Hash filter params
2024-11-08 15:17:55 -06:00
Jose Farias
aca9a69ce1
Add derived_params alias
2024-11-07 12:48:27 -06:00
Jose Farias
77a9b267d8
Split out fields and params for filters
2024-11-07 12:44:26 -06:00
Jose Farias
fb08ff394d
exists? -> any?
2024-11-07 11:35:26 -06:00
Jose Farias
8f17152108
Put includes on the same line
2024-11-07 11:32:44 -06:00
Jose Farias
f53ee0ddac
Sanitize params after initialization
2024-11-06 18:19:19 -06:00
Jose Farias
e73f44cde9
Unnecessary parens
2024-11-06 18:16:18 -06:00
Jose Farias
f7495ac1fa
Improve denormalized filters note
2024-11-06 18:13:05 -06:00
Jose Farias
9efe94a277
idempotent_create -> persist
2024-11-06 18:09:55 -06:00
Jose Farias
32618debf6
Pull out strip_default_params
2024-11-06 18:05:15 -06:00
Jose Farias
49f3894bcb
Update denormalization comment
2024-11-06 18:01:40 -06:00
Jose Farias
be0973705c
Unnecessary newline
2024-11-06 17:56:46 -06:00
Jose Farias
a853f75ef9
No need to set resources in to_params anymore
...
They're denormalized now
2024-11-06 17:54:43 -06:00
Jose Farias
e6cf8d3571
Delegate default_params to class
2024-11-06 17:52:31 -06:00
Jose Farias
12ce07639d
Add tests
2024-11-06 17:49:14 -06:00
Jose Farias
3d9d169477
Many-to-many relationship for filters and filterables
2024-11-05 21:21:46 -06:00
Jose Farias
f2706d0f74
Unnest bubble filters
2024-11-05 13:04:05 -06:00
Jose Farias
2f7baaff29
create -> create!
2024-10-28 10:47:49 -06:00
Jose Farias
cf9b07711a
Document left_joins_messageable smell
2024-10-28 10:27:50 -06:00
Jose Farias
5cdf83163c
Document with_status name smell
2024-10-28 10:25:56 -06:00
Jose Farias
dbad5a1a8c
Document intention to persist summary body
2024-10-28 10:24:43 -06:00
Jose Farias
404755c9d9
Clean up Bubble#track_event
2024-10-28 10:20:39 -06:00
Jose Farias
c571c4400d
Inline EventSummary#tallied_boosts
2024-10-28 10:07:25 -06:00
Jose Farias
8b062b4432
Pull out Bubble#activity_count
2024-10-28 10:07:12 -06:00
Jose Farias
46d1ce4702
Make it clear where the boost_count is coming from
2024-10-27 19:53:37 -06:00
Jose Farias
2fb6ed76b3
Fix comments-dependent scopes
2024-10-27 19:50:06 -06:00
Jose Farias
61d68bf79d
Account for event summaries with no boosts
2024-10-27 17:53:00 -06:00
Jose Farias
287a956364
Let EventSummary do the work to summarize events
2024-10-27 17:41:48 -06:00
Jose Farias
0727414017
Lean into delegated types APIs
2024-10-27 17:39:30 -06:00
Jose Farias
f782b43ef5
find_or_create_next_summary -> find_or_create_active_summary
2024-10-27 12:36:37 -06:00