Stanko K.R.
34d83aaa7c
Fix tests after the removal of memberships
2025-11-17 09:12:40 -05:00
Kevin McConnell
1959e15f7e
Fix more tests
...
These are mainly because the fixture's UUIDs are deterministic rather
than time-sortable, and more places where we need to correct the fixture
IDs as well.
2025-11-17 09:12:31 -05:00
Stanko K.R.
71a332bb08
Remove dead code
2025-11-17 09:12:17 -05:00
Stanko K.R.
6858b96619
Simplify join codes
2025-11-17 09:12:17 -05:00
Mike Dalessio
dbf66f9a50
Constrain user queries to the current or relevant account
2025-11-17 09:11:57 -05:00
Mike Dalessio
c38f27f3b4
test: fix or skip signup controller tests
2025-11-17 09:11:47 -05:00
Mike Dalessio
905cf759d8
test: fixing or skipping more tests
2025-11-17 09:11:47 -05:00
Mike Dalessio
d41d50d52b
Account.sole → Current.account
...
and some other de-tenant changes, including removing the controller
tenanting concerns
2025-11-17 09:11:40 -05:00
Jorge Manrubia
eea9afb639
Fix: dismiss grouped notifications by card from the notifications tray
...
This also splits the templates into two: index and tray, since the URL now changes.
2025-11-14 12:58:24 +01:00
Jorge Manrubia
0d55c966b3
Fix: setting board entropy was changing the account entropy when not present
2025-11-14 12:10:54 +01:00
Jorge Manrubia
17876b30d4
Manage comments with streams
...
We replacing the full list of comments within a turbo frame, which didn't feel great when you had several comments.
2025-11-13 17:12:46 +01:00
Jorge Manrubia
2dab14ef64
Replace the full container since we want to get back to the initial state
...
To see the boost button again
2025-11-12 18:14:31 +01:00
Jorge Manrubia
2d96e7c9c6
Use streams to update/remove reactions
...
Prevents race condition causing flickering https://app.fizzy.do/5986089/cards/2906
This will prevent these from udpating live, but we will tackle that as part of live card
updates with page refreshes, which I will tackle soon.
2025-11-12 18:04:20 +01:00
Jorge Manrubia
285328ec60
Smoother tag updates with streams
2025-11-12 17:29:35 +01:00
Jorge Manrubia
872537f02c
Ensure only admins/creators can publish boards
2025-11-12 11:48:35 +01:00
Jorge Manrubia
9c77ad6029
Admins can't edit the board in general
2025-11-12 11:41:46 +01:00
Jorge Manrubia
cc612479f0
Add missing test
2025-11-12 11:35:58 +01:00
Jorge Manrubia
b7729401b4
Only admins can edit entropy
2025-11-12 11:33:46 +01:00
Jorge Manrubia
e67cdd986f
Only admins can manage join codes
2025-11-12 11:30:29 +01:00
Stanko K.R.
cd51256f41
Disable user creation tests for the OSS config
2025-11-07 07:17:49 +01:00
Stanko K.R.
3f4d500103
Unify sign in and sign up
2025-11-07 07:06:25 +01:00
Jorge Manrubia
693c0c0fb2
Redirect to root to avoid changing the path by default
2025-11-05 19:00:50 +01:00
Jorge Manrubia
2af7a9f402
Merge pull request #1498 from basecamp/rename-boards
...
Rename collections => boards
2025-11-05 18:50:49 +01:00
Jorge Manrubia
3b34703db3
Make sure that only admins or card creators can delete cards
2025-11-05 16:37:43 +01:00
Jorge Manrubia
de8e861712
Make sure only admins or collection creators can toggle the individual access settings
2025-11-05 16:04:25 +01:00
Jorge Manrubia
193cc26a98
Make sure only admins or collection creators can toggle the all access setting
2025-11-05 15:51:19 +01:00
Jorge Manrubia
39ec6cf062
Replace collection with board in the code, tests green
2025-11-05 13:41:12 +01:00
Jorge Manrubia
03a345609e
Baseline replacing collection with board across code
2025-11-05 13:31:54 +01:00
Stanko Krtalić
1c54efbd75
Merge pull request #1497 from basecamp/fix-double-memberships
...
Prohibit duplicate memberships
2025-11-05 12:22:32 +01:00
Stanko K.R.
3f054c79dd
Check that the join code was copied to the membership
2025-11-05 12:09:47 +01:00
Stanko K.R.
cfdd7ab1cb
Prohibit duplicate memberships
2025-11-05 11:57:40 +01:00
Jorge Manrubia
999043eda0
Fix tests
2025-11-05 11:48:36 +01:00
Jorge Manrubia
10d14b5774
Don't choke when no collections
2025-11-05 08:31:42 +01:00
Mike Dalessio
739d77e0c6
Only include active users in Lexxy prompts
...
Specifically, exclude users that are inactive or with role "system".
ref: https://app.fizzy.do/5986089/cards/2760
ref: https://app.fizzy.do/5986089/cards/2789
2025-11-04 18:48:59 -05:00
Stanko K.R.
875515b51d
Skip the menu screen if there is just one account
2025-11-04 17:52:31 +01:00
Jorge Manrubia
2bb90eab13
Use the sole collection as the root for a better onboarding experience for new accounts
2025-11-04 17:09:35 +01:00
Stanko K.R.
5f26690aa1
Redirect to the account you joined after sign in
2025-11-04 07:20:16 +01:00
Jorge Manrubia
8aead31200
Fix: mark all as read wasn't refreshing in the notifications screen
2025-11-04 06:12:30 +01:00
Jorge Manrubia
24da4066b7
Refresh the full meta area so that the assignee name gets updated too
2025-11-03 16:11:53 +01:00
Jorge Manrubia
00818697ef
Use page refreshes with morphing to avoid flickering
...
Replacing the card container will reload the frame. Also, see
https://github.com/basecamp/fizzy/commit/5b70320a6b64adf2d1e0be4bd7dc221a5ba80c95
2025-11-03 16:11:53 +01:00
David Heinemeier Hansson
c25fcc087a
Test avatars controller
2025-11-03 14:21:53 +01:00
Jorge Manrubia
da6d1011fd
Replace card replacement with stream actions to prevent flickering when managing steps
2025-11-03 10:59:24 +01:00
Jorge Manrubia
9d4dd3b00e
Remove "save as draft"
...
Removes the creating status completely as well as the abandoned cards system. It will
always resume drafts if they exist, for a given collection and user.
https://app.box-car.com/5986089/cards/2489
2025-11-03 09:32:29 +01:00
Jorge Manrubia
ebe1617f42
Format
2025-11-03 09:29:43 +01:00
David Heinemeier Hansson
e4cdc15b6a
Fix tests
2025-11-02 20:25:11 +01:00
David Heinemeier Hansson
43069b1ea4
Extract Users::JoinsController from overloaded UsersController
...
Good code smell is when the before_action callbacks stack up but can't
be shared across actions
2025-11-02 17:49:25 +01:00
David Heinemeier Hansson
bced7405df
Extract events loading from overloaded UsersController
2025-11-02 17:31:28 +01:00
David Heinemeier Hansson
76c87f6b67
Test updating account settings
2025-11-02 16:04:51 +01:00
David Heinemeier Hansson
c834cce504
Simplify join code creation and validation and test controller
...
cc @monorkin
2025-11-02 15:58:33 +01:00
David Heinemeier Hansson
b3474ec97d
Rename Entropy::Configuration to just Entropy
2025-11-02 13:11:41 +01:00