Commit Graph

244 Commits

Author SHA1 Message Date
Mike Dalessio c78bb652d5 Clean up beacon on-visibility-change handling
The previous version was not posting the beacon when the page was
loaded and visible.
2025-08-09 14:09:34 -04:00
Mike Dalessio 8ec109ec1a Delay clearing notifications until a card is actually viewed.
Send the "read" beacon when the card is made visible.

Also take care to only send the "disconnect" beacon if the card is
visible.

ref: https://fizzy.37signals.com/5986089/collections/2/cards/1301
2025-08-08 08:02:54 -04:00
Andy Smith d5a1c9824c Merge pull request #836 from basecamp/lightbox-improvements
Lightbox improvements
2025-08-05 09:59:37 -05:00
Andy Smith 34f926ffca Support optional captions 2025-08-04 13:05:39 -05:00
Andy Smith 4c505aeb23 Get all transitions working properly 2025-07-31 15:34:27 -05:00
Andy Smith 3f7f414c34 Animate the lightbox 2025-07-30 17:26:05 -05:00
Jason Zimdars 6227cf9a8b Keyboard arrow through pins and notifications 2025-07-30 16:07:55 -05:00
Jason Zimdars 1d6a60cd17 Remove debug 2025-07-24 14:49:53 -05:00
Jason Zimdars 8c9d7d9d91 Update badge counts clientside because we can't count on pushes to remove badges 2025-07-24 14:43:51 -05:00
Jason Zimdars 99df4b1a12 No longer used 2025-07-23 17:33:56 -05:00
Jason Zimdars 785de2f0cb Whitespace 2025-07-22 22:42:36 -05:00
Jason Zimdars 211403f584 Remove debug 2025-07-21 18:49:29 -05:00
Jason Zimdars 9b6995194c Break sooner, use switch 2025-07-21 18:49:18 -05:00
Jason Zimdars c3b946c961 Design flow for enabling push and the various status that go with it 2025-07-21 18:27:31 -05:00
Jason Zimdars 4ba3bbc4f1 Revert "Linux wet the bed on this, trim whitespace and ensure 8-bit values"
This reverts commit 3940d9d60f.
2025-07-17 19:51:31 -05:00
Jason Zimdars b2334fc8be Revert "Add debug for Linux"
This reverts commit 37e344d9f1.
2025-07-17 19:51:25 -05:00
Jason Zimdars 37e344d9f1 Add debug for Linux 2025-07-17 19:33:21 -05:00
Jason Zimdars 3940d9d60f Linux wet the bed on this, trim whitespace and ensure 8-bit values 2025-07-17 19:30:30 -05:00
Jason Zimdars 1b52a860f3 No need to talk to other controllers right now 2025-07-17 18:04:40 -05:00
Jason Zimdars 347e41037f Simplify connect method, stub a method that will display various states based on detection 2025-07-17 17:54:23 -05:00
Jason Zimdars 3ddb5e536e Use async method instead of getter, use root scope 2025-07-17 17:29:20 -05:00
Jason Zimdars 291f4e2d14 Now that the basics are working, update debug to catch real issues
- I'll use these to update the UI later
2025-07-15 18:09:30 -05:00
Jason Zimdars db9f670876 Must include account slug to match manifest scope 2025-07-15 17:03:28 -05:00
Jason Zimdars 47324eb45a Fix routes to manifest and service-worker, rename controller 2025-07-15 16:42:47 -05:00
Jason Zimdars 8f47db3ced Add service worker and subscriptions controllers 2025-07-15 15:22:32 -05:00
Jason Zimdars 96602d7a97 Show date instead of time for notifications older than 1 day 2025-07-07 17:12:43 -05:00
Jorge Manrubia 809d23245f The prompt confirmation system wasn't really working after moving to lexical
The async value setting was biting us here
2025-07-03 23:29:36 +02:00
Jorge Manrubia bd7b9a442e Merge branch 'main' into fizzy-do-prompts
* main: (57 commits)
  Untenanted access in authenticated controllers should request auth
  dep: bundle update
  dep: update Rails
  dep: bump AR::Tenanted
  Clean up the cable meta tag
  Fix activity feed pagination to fetch on demand
  Create a "published" event if a card is created published
  Scatter Honcho seeds over a 30 day period
  Fix the PWA manifest to use slugged URLs
  Collection publication edits render a turbo frame
  Collection workflow edits render a turbo frame
  Collection entropy config edits render a turbo frame
  Use automatic sizing where supported
  Introduce a separate controller for collection entropy config
  Add `card_id` to index
  Move to scope and inline method
  Prefer modern syntax
  Fix that stage should be visible above card background
  Indicate opens menu
  Hide dialog targets from screen readers when closed
  ...

# Conflicts:
#	db/schema.rb
#	db/schema_cache.yml
2025-07-03 16:11:00 +02:00
Jorge Manrubia 0c4baed8a4 Show help menu without introducing newlines after updating lexical 2025-07-02 23:03:38 +02:00
Jason Zimdars 86e6309735 Hide dialog targets from screen readers when closed 2025-07-02 15:57:30 -05:00
Jorge Manrubia 7913513826 Reset after entering help command 2025-07-02 22:35:52 +02:00
Jorge Manrubia 33768757db Don't submit on /help command 2025-07-02 21:59:53 +02:00
Jorge Manrubia 8330bb25fc Support help command 2025-07-02 21:55:13 +02:00
Jorge Manrubia b0e35bcd54 Remove trace 2025-07-02 21:51:42 +02:00
Jorge Manrubia 93be9e945f Support user prompts in Fizzy do, move parsing logic to context 2025-07-01 14:06:39 +02:00
Jorge Manrubia 0f7b45ab38 Use lexical in the command line 2025-07-01 12:15:02 +02:00
Jorge Manrubia 939d68b941 Don't prevent default with light/right arrows since this prevents moving cursor on input fields 2025-07-01 11:38:44 +02:00
Jorge Manrubia c2e1b36d7e Merge pull request #675 from basecamp/command-errors
Show command errors
2025-07-01 09:56:42 +02:00
Jorge Manrubia 2ab322adfe Tidy up code to normalize text, extract text helpers 2025-07-01 09:42:22 +02:00
Jason Zimdars dec57f1a9a Perform conversion on the client side 2025-06-30 17:30:34 -05:00
Jorge Manrubia 179ae45bf3 Show command errors
I went with placing htis logic at the command level since it plays well with the composite structure, where you don't know whether you are handling one command or many commands, and you want to aggregate all the errors. I didn't leverage the existing support with rails' model errors because that customizing those message is cumbersome (either i18n or using custom validation logic for everything).
2025-06-30 23:10:39 +02:00
Jason Zimdars 2678f8c099 Convert diacritics to approximations before filtering
- Introduces a helper method for setting the filterable value
- Updates `filter_controller.js` to use `data-filter-text-value` attribute populated with converted content. This was previous `data-value` in the earlier implementation but ignored in the current on.
- Also uses the same helper to make @mentions diacritic insensitive
2025-06-30 13:53:50 -05:00
Jorge Manrubia 611543a88e Don't submit with empty strings 2025-06-25 15:29:17 +02:00
Jason Zimdars 6997f8e5a2 Don't match hotkeys inside Lexical 2025-06-16 14:13:52 -05:00
Jorge Manrubia 0e570565a4 Don't miss cards dropped in the same container! 2025-06-13 10:04:22 +02:00
Jorge Manrubia 5364585818 If we wait for the form to submit it can happen that we don't remove the dragged item! 2025-06-12 12:33:01 +02:00
Jorge Manrubia f58aaadba5 Drag and drop cards to move between doing/considering 2025-06-12 11:57:53 +02:00
Jorge Manrubia a60bf886cf Remove log 2025-06-10 11:04:20 +02:00
Jorge Manrubia 15d3c0e724 Simplify since the design is identical 2025-06-06 09:19:51 +02:00
Jorge Manrubia f742749b0f Tidy up controller and make sure the different targets are properly separated
If not, it wouldn't show stalled if there were entropy bubbles in the page
2025-06-06 09:15:51 +02:00