Commit Graph

742 Commits

Author SHA1 Message Date
Jason Zimdars a1583225c4 Adjust icon and card header for events 2025-06-05 13:39:30 -05:00
Jason Zimdars 20d0515031 Fix that flash notices invisibly overlapped navbar 2025-06-05 11:21:52 -05:00
Jason Zimdars ad27d856bb Use card header in events 2025-06-05 11:16:53 -05:00
Jorge Manrubia 1fe16e1416 Merge pull request #585 from basecamp/entropy-settings-ui
Entropy improvements
2025-06-05 09:19:56 +02:00
Jason Zimdars 6eece93f10 Merge branch 'knobs' into entropy-settings-ui
* knobs:
  Add comment
  Properly parameterize the field name
  Remove leftover console.log
  Correct the reserved area math
  Better a11y
  Connect the range slider
  Basic radio input working
  Expose button so you can delete drafts
  Save button should match card color
  `x` interferes with string entry, try `SHIFT+ENTER` to toggle checkboxes
  Remove unnecessary param and update condition
2025-06-04 20:34:04 -05:00
Jason Zimdars e42c6548b0 Wire up knob UI design 2025-06-04 20:28:20 -05:00
Andy Smith 22a85e6fc5 Contain images 2025-06-04 16:00:46 -05:00
Jason Zimdars 10224c2698 Extract the header so we can explain in context 2025-06-04 15:30:19 -05:00
Andy Smith 989825dcda Add comment 2025-06-04 13:50:27 -05:00
Andy Smith 8e24b3edff Merge pull request #572 from basecamp/prevent-layout-shift
Add height/width values for images and videos
2025-06-04 13:39:23 -05:00
Andy Smith e513474e36 Correct the reserved area math 2025-06-04 13:38:50 -05:00
Andy Smith 04551d859e Better a11y 2025-06-04 13:06:43 -05:00
Andy Smith 80b1ac8cc9 Connect the range slider 2025-06-04 12:49:32 -05:00
Andy Smith 68ac1f80ec Basic radio input working 2025-06-04 12:10:28 -05:00
Jason Zimdars 678fb66f17 Stub UI for independent settings for Considering and Doing 2025-06-03 15:51:37 -05:00
Jason Zimdars ff403021cc Wire-up keyboard navigation
- Introduces a distinct controller and individual forms for each option so they behave like other pop-ups
- Adds `filter` and `navigable-list` behaviors
2025-06-03 11:05:39 -05:00
Jason Zimdars acfc7da551 Merge pull request #548 from basecamp/change-collection
Change collection
2025-06-03 08:56:00 -05:00
Jason Zimdars dc5c8d17a4 Handle these special case options a different way 2025-06-02 15:49:44 -05:00
Jason Zimdars 0be387bb41 Add distinct navigation selected styles 2025-06-02 15:18:27 -05:00
Andy Smith 34a4ba6c60 Add height/width values for images and videos 2025-06-02 14:36:04 -05:00
Jorge Manrubia 61fbad218b Make tag filters selectable/navigable too 2025-06-02 18:39:44 +02:00
Jason Zimdars 902a99ca56 Merge branch 'main' into change-collection
* main: (25 commits)
  Add controller to retarget links
  Use more complete regexp
  dep: bundle update
  refactor: Extract a Card::Entropy concern
  Autolink emails and URLs at rendering time
  Remove the "mirror" storage service
  Update production storage to write to the Pure blob store
  Clean up the purestorage config, and add explanatory comments.
  Drop the action_text_markdowns table
  Mount mission control under `/admin/jobs`
  dep: add mission_control-jobs
  Flip the storage mirror to write to Pure as the primary
  Production mirrors Active Storage to `:purestorage`
  Make sure Sentry is configured for the beta env.
  Update lexical
  update lexical
  update lexical
  Create a distinct "beta" environment
  Revert "Patch for cards missing description"
  Add a kamal "ssh" alias
  ...
2025-06-02 09:34:01 -05:00
Jorge Manrubia 29c1f3133d Remove unused classes from controller 2025-06-02 15:08:34 +02:00
Jorge Manrubia 37fd2b248d Revamp filters menu (WIP)
- Make them navigable by keyboard (UP, DOWN, ENTER to activate option).
- Filter based on the actual text in the element, use containment condition instead of CSS selector on value prefix.
- Make all the elements in the filter searchable and reachable by keyboard.
2025-06-02 14:51:03 +02:00
Mike Dalessio 28ed744d0c refactor: Extract a Card::Entropy concern
to encompass behavior related to auto-closing and auto-reconsidering.

Note that putting this code in a single place reveals an asymmetry
between the actions:

- Auto-closing period is an optional attribute of a collection
- Auto-reconsidering period is hard-coded to 30 days for all collections
2025-06-01 16:50:12 -04:00
Andy Smith 68906321e8 Card shadow tweaks 2025-05-30 13:11:36 -05:00
Jason Zimdars 1594c2fe3f Merge branch 'main' into change-collection
* main:
  Icon for unassigned events
  Tweak comment event icon
  update lexical
  Update lexical to support placeholders and style them up
  Not used anymore
  update lexical
2025-05-30 08:17:31 -05:00
Jason Zimdars ee98c13db5 Tweak comment event icon 2025-05-30 08:10:55 -05:00
Jason Zimdars a2a914ee72 Event icon for changing collection 2025-05-30 08:04:13 -05:00
Jorge Manrubia 40e2dcae0b Update lexical to support placeholders and style them up 2025-05-30 11:07:42 +02:00
Jorge Manrubia 5ec09aa5d7 Not used anymore 2025-05-30 11:07:26 +02:00
Jason Zimdars c4ca5d34e4 Allow cards to be moved to another collection 2025-05-29 21:41:29 -05:00
Jason Zimdars f863ced9dd Merge branch 'main' into jz-5-29-25
* main:
  Use consistent rem margins
2025-05-29 16:28:15 -05:00
Jason Zimdars 88a54a246d Need to convert to srgb color space when using oklch colors in Safari
No idea why
2025-05-29 16:24:17 -05:00
Andy Smith 9efdf3385c Merge pull request #546 from basecamp/rich-text-margins
Use consistent rem margins
2025-05-29 16:14:45 -05:00
Jason Zimdars 6738d3a365 Don't go too hard, we want related cards highlighting to still work 2025-05-29 16:12:11 -05:00
Jason Zimdars 9052b76c39 Indicate golden cards in activity 2025-05-29 15:30:17 -05:00
Jason Zimdars 81eb1e6fa3 Tighten spacing, try a subtle texture 2025-05-29 15:17:51 -05:00
Andy Smith 71cfa95308 Use consistent rem margins 2025-05-29 14:37:56 -05:00
Jason Zimdars 613a877f7f Merge branch 'main' into jz-5-28-25
* main: (58 commits)
  Safari doesn't support CSS `field-sizing: content` so we can shim it for now
  Hide bubbles in trays
  update lexical
  update lexical
  Update script to deal with duplicated records
  Revert "Revert "Replace House with Lexical""
  Revert "Replace House with Lexical"
  Update actiontext lexical
  Remove trace
  Update lexical
  Use existing method
  Update lexical
  Fix merge issues
  Format
  Cleanup
  Format
  Make tests pass with action text
  Don't choke when rendering commands where the card was deleted
  Update lexical
  Simple format excerpts in activity
  ...
2025-05-29 14:21:17 -05:00
Jason Zimdars 32ae94524a Safari doesn't support CSS field-sizing: content so we can shim it for now 2025-05-29 14:19:48 -05:00
Andy Smith e0accd0fd4 Hide bubbles in trays 2025-05-29 13:37:07 -05:00
Jorge Manrubia fa04016cbe Revert "Revert "Replace House with Lexical"" 2025-05-29 14:25:16 +02:00
Jorge Manrubia 08d8b2e5ff Revert "Replace House with Lexical" 2025-05-29 14:22:27 +02:00
Jorge Manrubia 62bef018ea Merge branch 'main' into lexical
* main:
  Don't choke when rendering commands where the card was deleted
  Update tests
  Rework system events
  test: add missing assertions
  dep: bump active_record-tenanted to fix URI support
  Remove hyphen from "Un-do"
  Prevent default when handling keyboard shortcuts
  dep: update AR::Tenanted to support database URIs
  Detect platform and label the correct hotkey shortcut
  Things got too tight
  Don't require TLS for Beamer at the moment
  dep: update dependencies

# Conflicts:
#	Gemfile
#	Gemfile.lock
#	app/assets/stylesheets/comments.css
2025-05-29 12:44:14 +02:00
Jason Zimdars f04cbf44de Fix event comment horizontal alignment
- No need to expose reactions here, either
2025-05-28 16:13:42 -05:00
Jason Zimdars c6c9e0d5fc Rework system events
- Restyle system events so they don't look like comments and aren't attributed to the system user
- Ensure the event creator is included in the description so it's clear who did it.
- Walk back system comment replacement. Yes, it potentially avoids embarassing people when they change their mind, it's also losing data. If two intentional assigments happen in proximity, we've been only showing the latest one,.
2025-05-28 15:26:41 -05:00
Jason Zimdars 224fb1893e Can't reliably use percentages here 2025-05-28 11:13:59 -05:00
Jason Zimdars adc84a7054 Improve color associations, add a few more types 2025-05-28 11:13:00 -05:00
Jason Zimdars 5e2c1c3501 Add a little more pizzazz to file icons 2025-05-28 10:26:32 -05:00