Commit Graph

78 Commits

Author SHA1 Message Date
Jason Zimdars 2ea2e65f04 Always show the stage picker, cards in Considering are unstaged 2025-09-22 10:55:22 -05:00
Jason Zimdars 7a2f77d096 Drop cards into specific stage columns 2025-09-19 17:34:52 -05:00
Jason Zimdars a4e1b04f0e Allow dropping cards into closed 2025-09-19 17:13:20 -05:00
Jorge Manrubia be246d204f Replace assignees with a turbo stream instead of replacing the full card
So that we don't lose th editing context if you do it while editing a card

https://fizzy.37signals.com/5986089/collections/2/cards/1479
2025-09-09 15:32:18 +02:00
Jorge Manrubia 07bdcb7a9c Pass the new param this partial requires 2025-09-09 12:12:39 +02:00
Jason Zimdars aa13853ae4 Add a third, "On deck" column in Collections 2025-08-12 17:58:12 -05:00
Jorge Manrubia 919211244b Review the code to move cards
- Scope accessed records
- Keep consistency by moving events too
2025-07-04 19:56:48 +02:00
Jason Zimdars 27aaa815c7 Prefer modern syntax 2025-07-02 16:12:37 -05:00
Jason Zimdars f02215c5b7 Add steps to cards 2025-07-01 20:05:20 -05:00
Kevin McConnell 5a9f9692f2 Track collection access when viewing cards 2025-06-24 15:48:05 -05:00
Kevin McConnell 63ddb23585 Opt out of writer affinity on readings controller 2025-06-16 15:05:47 +01:00
Jorge Manrubia d9323fa3e7 Add flash notice when adding another card 2025-06-13 11:02:40 +02:00
Jorge Manrubia 303a3faea1 Merge pull request #607 from basecamp/drag-and-drop-cards
Drag and drop cards to move between doing/considering
2025-06-13 10:04:59 +02:00
Jorge Manrubia 7a4e59391b Add test 2025-06-13 09:55:37 +02:00
Jorge Manrubia 31c851aa5b Use the same controller for publishing cards and for publishing and adding another 2025-06-13 08:55:30 +02:00
Jorge Manrubia 0cb3648785 Extract concern with common column-related code 2025-06-12 12:48:10 +02:00
Jorge Manrubia a979daddf3 Reuse filter scope 2025-06-12 12:39:33 +02:00
Jorge Manrubia 97fecc2bbe Extract method 2025-06-12 12:10:17 +02:00
Jorge Manrubia a5de3cf64b Replace with morph 2025-06-12 12:06:00 +02:00
Jorge Manrubia f58aaadba5 Drag and drop cards to move between doing/considering 2025-06-12 11:57:53 +02:00
Jorge Manrubia 84fdeb4a5e Track events when reopening cards 2025-06-04 17:18:01 +02:00
Jason Zimdars ff403021cc Wire-up keyboard navigation
- Introduces a distinct controller and individual forms for each option so they behave like other pop-ups
- Adds `filter` and `navigable-list` behaviors
2025-06-03 11:05:39 -05:00
Jorge Manrubia 2b98db9e66 Flatten out comments and messages
https://37s.fizzy.37signals.com/collections/693169850/cards/999008989#comment_994777841
2025-04-29 19:21:18 +02:00
Jorge Manrubia f166b30f2f Fix: dismiss mention notifications in cards and comments when reading a card 2025-04-24 12:19:20 +02:00
Jorge Manrubia b08326ccbe Merge branch 'main' into plain-text-mentions
* main: (48 commits)
  Improve layout and truncation
  This is annoying
  Fix summary
  Remove index columns
  Same treatment for the events index
  New menu filters and navigates
  Don't test for _Added by_ events
  Indention
  @collection is always available when card scoped
  Style
  Remove check for _Added by..._ line
  The placeholder attribute is on the `house-md` element
  Duh, no before destroy commit, but this is still not right!
  No long transactions!
  Don't display published event in threads
  But feels more essentially part of the User, so list first
  Not related to the other two
  Missing controller
  Style
  Errant `bubbles` => `cards` replacement
  ...

# Conflicts:
#	app/models/card.rb
#	app/models/user.rb
#	db/schema.rb
#	db/schema_cache.yml
2025-04-23 17:24:01 +02:00
David Heinemeier Hansson 3d28203224 Use singular staging resource and beef up testing 2025-04-22 14:44:55 +02:00
David Heinemeier Hansson 2d5901fe1e Fix pin turbo stream response rendering 2025-04-22 11:48:19 +02:00
Jorge Manrubia aa3acfeaa8 Add plain text mentions 2025-04-22 11:26:56 +02:00
David Heinemeier Hansson f3000a02c5 Follow render_card_replacement pattern
And clean up the rest of the implementation a tad.
2025-04-18 15:20:38 +02:00
David Heinemeier Hansson 7395d4e034 Removing the image can also just be done as a card replacement 2025-04-18 15:14:36 +02:00
David Heinemeier Hansson ac9cbad4f9 I like this even better 2025-04-17 15:32:09 +02:00
David Heinemeier Hansson 62088b66d1 Suffix qualifier is unnnecessary 2025-04-17 15:30:55 +02:00
David Heinemeier Hansson 4dbd8205ce Fix trailing space 2025-04-17 15:21:14 +02:00
David Heinemeier Hansson 7adbd8d634 Use card rerendering instead of redirects 2025-04-17 15:20:27 +02:00
David Heinemeier Hansson 547e5ea24f Rerender instead of redirect 2025-04-17 14:54:29 +02:00
David Heinemeier Hansson 4d0dddec46 No need to loop through a job when this is the sole point of the action 2025-04-17 14:31:28 +02:00
David Heinemeier Hansson 87ce4a623b Even clearer about where these pins are going 2025-04-17 14:31:02 +02:00
David Heinemeier Hansson 1437bcb3b7 Clearer about where these are being sent 2025-04-17 14:29:12 +02:00
David Heinemeier Hansson fc0cf3917f Pin without redirect
Use turbo stream response to save on the redirect latency
2025-04-17 14:05:26 +02:00
David Heinemeier Hansson 07e801b74c Fix pinning to tray
They need to have a complete dom element that is unique
2025-04-17 13:52:55 +02:00
David Heinemeier Hansson a5de4863fa Allow for multiple notifications to be read
cc @kevinmcconnell
2025-04-17 11:39:37 +02:00
Kevin McConnell 6c8fe164b3 Read a card should dismiss all notifications
Previous code assumed that there was a single notification to dismiss
for that card, but in practice there can be zero or many. If it's zero,
we need to avoid the crash. If it's many, we should dismiss them all.

Also re-rendering the notification stack after dismissing enables us to
remove all the removed cards, as well as reveal any older ones that were
previously outside the visible page size.

This reverts commit 6135909b7e.
2025-04-17 09:40:59 +01:00
David Heinemeier Hansson 6135909b7e Card readings just need to remove the notification
No need to broadcast everything again
2025-04-16 16:51:18 +02:00
David Heinemeier Hansson d00a0433e9 Inline anemic method 2025-04-16 15:34:28 +02:00
Andy Smith a88264ed0a Merge branch 'main' into consolidate-cards
* main: (94 commits)
  Source order seems to be significant
  Use `card.title`
  Nicer flow
  Fix string interpolation
  Fix constant
  Use record lookup
  Always use sole
  Explained less and extracted nothing of value
  Weird double negative
  Remove anemic and indirect method that explained nothing
  Can use record lookup for workflows
  Access control has already been done through the card
  Style
  Use _path in all cases where we are not potentially changing the domain
  Clearer
  Spacing
  Get rid of card_title
  Join the two users controllers but split out role setting
  Ensure user is returned
  We are not using the parameter
  ...
2025-04-14 09:40:22 -05:00
David Heinemeier Hansson cfb345bc32 Nicer flow 2025-04-13 20:39:09 +02:00
David Heinemeier Hansson e8a730c239 Fix constant 2025-04-13 20:36:07 +02:00
David Heinemeier Hansson 7b60748796 Clearer 2025-04-13 08:11:25 +02:00
David Heinemeier Hansson 4ef46ccd19 Spacing 2025-04-13 08:10:47 +02:00
David Heinemeier Hansson 6bbf68a4f9 The tenanted db is the account scope 2025-04-12 20:06:34 +02:00