9a38c28858
Merge pull request #463 from basecamp/reaction-emojis
...
Reaction emojis
2025-05-08 11:00:26 -05:00
1662a8af82
Hide terminal menu when pressing ESC
...
This was only working when the focus was on the input
2025-05-08 11:37:30 +02:00
5cd71a7699
Don't dismiss on any key, only with N or ESC
...
Also, this reworks the system to rely on stimulus event handling. This cover cases like unbinding events automatically when the controller get disconnected and such.
See:
https://3.basecamp.com/2914079/buckets/37331921/todos/8617430347
2025-05-08 11:21:39 +02:00
86db634f7f
Fix: selected item not showing up in Safari
...
It also handles auto selecting when an element is focus. E.g: if you tabulate to the next control in the navigable list, you want selection to update accordingly.
2025-05-08 10:41:51 +02:00
59303a4628
Merge branch 'main' into fizzy-do-3
...
* main: (29 commits)
Ensure that a "reconsidered" card gets an updated timestamp
Try a fresh activity design
Log the authenticated user
Remove leading space when avatar is hidden on pinned cards
Display card number in notifications and events
Ensure that cards with an empty title aren't mysterious in notifs
bin/dev ensures puma runs solid queue
Adjust selection color to feel more terminal-y
Eliminate double-tab behavior
Clear error state when you start editing
Color terminal text on error
Don't indicate spelling errors
The command is lowercase
Remind 7 days before, not 30
Make the icon square
Subtler bubble styles
Variable bubble shapes
Bubble CSS
Rename 'badge' to 'bubble'
Address PR feedback
...
# Conflicts:
# app/javascript/controllers/terminal_controller.js
# app/views/commands/_form.html.erb
2025-05-08 10:29:54 +02:00
d10c45772e
Add a clear command to clear filters
2025-05-08 10:20:57 +02:00
06ed269ef8
Add control to show and remove card id filters
2025-05-08 09:58:54 +02:00
62b44cbb29
Polish help
2025-05-07 17:32:49 -05:00
d3cad768a1
Try a fresh activity design
2025-05-07 16:26:32 -05:00
8d1a4ec73a
Close ghost space when no reactions exist
2025-05-07 15:15:28 -05:00
d4d6a702f8
Remove leading space when avatar is hidden on pinned cards
2025-05-07 15:13:10 -05:00
dd5e45c93d
Display card number in notifications and events
2025-05-07 15:09:47 -05:00
beda688d10
Show buttons depending on reaction presence
2025-05-07 15:06:40 -05:00
c69402a300
Get turboframes sorted out
2025-05-07 15:02:34 -05:00
3710aa43e4
Stub out overflow reactions
2025-05-07 14:29:29 -05:00
fe48aecaae
Eliminate double-tab behavior
2025-05-07 12:28:09 -05:00
28659c1295
Clear error state when you start editing
...
- It feels wrong to persist the error state while you're fixing the command
2025-05-07 11:52:20 -05:00
19a7972a46
Don't indicate spelling errors
2025-05-07 11:43:45 -05:00
03473d8842
Merge pull request #406 from basecamp/closing-soon-badge
...
Closing soon badge
2025-05-07 11:13:35 -05:00
2503524b7a
Implement help menu command to show a help menu with the commands
2025-05-07 17:32:43 +02:00
6776e69ed8
Stop propagation so that it doesn't navigate back on ESC
2025-05-07 14:43:11 +02:00
87484dbca0
Add basic keyboard navigation support for the Fizzy do menu
2025-05-07 13:46:19 +02:00
0dcc6959da
Extract constant to clarify regexp
2025-05-07 13:31:52 +02:00
4d2f2067ed
Format
2025-05-07 12:13:45 +02:00
181e35b5b2
Restore command when clicking on it
2025-05-07 12:03:02 +02:00
8697cabbe2
Show confirmation when submitting certain commands
...
https://3.basecamp.com/2914079/buckets/37331921/todos/8617430347
2025-05-07 10:20:32 +02:00
22c3c33c0b
Merge pull request #460 from basecamp/fizzy-do-initial
...
Fizzy Do (initial)
2025-05-07 08:57:37 +02:00
6f382b68e0
Rename command controller => terminal controller and name the error class after terminal
2025-05-07 08:53:25 +02:00
55ea460d3e
Handle form errors with a stimulus class
...
We need to keep the focus in place when submitting the form. We are using a data-turbo-permanent for that. We were rendering the error form with a turbo stream. The problem was that turbo streams ignore permanent elements as per this https://github.com/hotwired/turbo/pull/688 , so the system wasn't updating the input field as expected.
Handling this as the stimulus level will also help with managing additional error states (such as the one we need for confirmations).
2025-05-07 08:46:47 +02:00
94e2ab25f9
Make command a button
2025-05-06 17:45:05 -05:00
10890df97f
Style undo button
2025-05-06 17:32:45 -05:00
5b8f108316
Gentler react animation
2025-05-06 17:02:03 -05:00
9034498f40
Fix hidden field value
2025-05-06 16:49:14 -05:00
9b49606246
Consistently align and size all elements
2025-05-06 16:37:01 -05:00
521351da16
Add a keyboard shortcut
2025-05-06 16:15:19 -05:00
36fb154ee1
Display obvious chip when filtering by stage
2025-05-06 15:45:28 -05:00
4d1c215f02
Merge branch 'main' into closing-soon-badge
2025-05-06 15:25:01 -05:00
d3d7a25d07
Stub out basic emoji presets
2025-05-06 10:43:56 -05:00
1faaed4a16
Prefer ul
2025-05-06 16:06:47 +02:00
a8d4cbcff0
Keep focus in place when navigating and morphing
2025-05-06 12:14:04 +02:00
bf443a2438
Remove turbo permanent that messes up with error rendering
2025-05-06 11:15:03 +02:00
5280221d5f
Format
2025-05-06 10:45:40 +02:00
08507048ea
Add aria label
2025-05-06 10:43:59 +02:00
5c417ada63
Keep focus
2025-05-06 10:20:37 +02:00
8ad3461d1b
Keep focus on error
2025-05-06 10:16:38 +02:00
0bdbcbf156
Highlight errors
2025-05-06 09:56:12 +02:00
456463ffef
Reset form automatically
2025-05-06 09:30:37 +02:00
3954033e61
Make confirmation for undo work
2025-05-06 09:27:00 +02:00
3e8896ef93
Undo working for assignments
2025-05-06 09:25:52 +02:00
7a51e13d7c
Remove old code
2025-05-06 08:56:56 +02:00
Andy Smith