Commit Graph

221 Commits

Author SHA1 Message Date
Mike Dalessio 91de604815 Move event activity loading into Events::DaysController 2025-03-26 07:46:56 -04:00
Mike Dalessio b7e5ca780c Extract the EventsTimeline controller concern 2025-03-26 07:37:42 -04:00
Mike Dalessio 23e4fd9b1c Remove the buckets#index action and view
and have bucket#destroy redirect to root_path
2025-03-25 13:40:36 -04:00
Mike Dalessio a66dc2a789 Move tags and assignments partials out of "bubbles/sidebar"
They're part of the card now, let's name them that way.

Also, rename the "tag" partial to "tagging", following the naming
convention established by the controller.
2025-03-24 17:11:58 -04:00
Mike Dalessio 5ae87d8140 Ensure the tags dropdown is not subject to the cached card fragment
- Rearrange the _tags and _tag partial, so they are properly nested concerns
- Add turbo frames for _tags and _tag
- Load _tag in a separate request, so it's not cached with the card
- Cache _tag using the bubble and the account
- New model behavior: touch Account when tags are added or removed
- New controller action: "new" for taggings toggles, which renders the _tag partial
- Updating taggings responds with a turbo stream response that updates the _tags frame

This is very much a parallel change to what was done with assignments
in #317.
2025-03-24 16:48:11 -04:00
Mike Dalessio df377861fc Merge pull request #317 from basecamp/flavorjones-assignee-card-cache
Assignee dropdown no longer subject to the card fragment cache
2025-03-24 15:27:53 -04:00
Jason Zimdars 4bc125c7eb Load the form in a turbo frame so focused field doesn't intercept hotkeys 2025-03-24 14:15:28 -05:00
Jason Zimdars 9b9e09601e Introduce text-based UI 2025-03-24 11:33:04 -05:00
Mike Dalessio 44650cc36e Reload the assignees turbo frame when assigments are updated
Also, add a cache around the dropdown keyed on [bubble, bucket].
2025-03-21 17:53:41 -04:00
Jason Zimdars 8e26106a07 Reorder and rename activity columns; include system popped events 2025-03-19 13:35:17 -05:00
Jason Zimdars 28a569c49b Tickets 2025-03-17 21:24:08 -05:00
Kevin McConnell f50a880d6b Avoid double render in Avatars#show
After sending the conditional 304 response, we were still attempting to
render the response, which is unnecessary.
2025-03-12 09:05:50 +00:00
Kevin McConnell 49fa8b21a6 Move current user check to controller
This is necessary to a) ensure people can't edit/delete comments they
don't own, and b) make the comment partial cacheable.
2025-03-03 17:04:16 +00:00
Kevin McConnell 942dd27e5c Sort buckets on notification settings 2025-02-27 12:17:32 +00:00
Kevin McConnell ab27371115 Include self in watcher list 2025-02-27 10:51:59 +00:00
Kevin McConnell 385e299db7 Simplify param 2025-02-26 10:53:03 +00:00
Kevin McConnell a802b8de5a Allow managing bucket subscriptions 2025-02-26 10:53:03 +00:00
Kevin McConnell f22742c431 watched_by? should reflect subscriptions too 2025-02-26 10:53:03 +00:00
Kevin McConnell 694783e5f3 Allow toggling watch preference
We use a true/false preference so we can tell the difference between
disabling the watch vs never having the watch. This is so we can toggle
off and on the preferences for a container (like the bucket) without
losing any bubble-specific preferences.
2025-02-26 10:53:03 +00:00
Jason Zimdars d73d3a9daa Constrain boost events 2025-02-24 17:12:46 -06:00
Jason Zimdars 5a4d2a72c8 Remove uniqueness constraint
I'm not sure if this was inadvertent or an artifact of an earlier design but I'm fairly certain we want a more comprehensive list of events here. Especially comments, for example. We should show all the comments that happen in a particular hour on the timeline. There may be places were we need to dial back but for now I'm going to lift the constraint and see how it feels.
2025-02-24 17:01:43 -06:00
Jason Zimdars 530b6e4a90 Stub notifications settings screen 2025-02-21 17:25:44 -06:00
Jason Zimdars 28bdc531b0 Mark individual notifications as read 2025-02-21 16:39:50 -06:00
Jason Zimdars 190e046479 Mark all notifications as read from the index 2025-02-21 12:12:00 -06:00
Jason Zimdars 8cde1883a6 Filter activity by bucket 2025-02-19 18:05:12 -06:00
Jason Zimdars 000bd158eb Reactions on comments 2025-02-18 17:08:56 -06:00
Jason Zimdars 783af287db Don't allow creating duplicate tags 2025-02-14 11:44:52 -06:00
Jason Zimdars edd7e55313 Prevent using # in the stored tag name 2025-02-14 11:23:08 -06:00
Kevin McConnell 483c6cdbe6 Allow updating draft comment with bubble 2025-02-13 14:39:33 +00:00
Kevin McConnell a24817ffb7 Don't show system events in Activity view 2025-02-12 14:31:29 +00:00
Kevin McConnell b0add103c4 Remove the system user avatar
We probably won't need it.
2025-02-12 14:29:33 +00:00
Kevin McConnell dac2611c57 Auto-pop bubbles 2025-02-12 13:20:05 +00:00
Kevin McConnell 485a056ba2 Add a "system" role & specific user 2025-02-12 13:19:53 +00:00
Kevin McConnell fd1556b298 Decision can belong to subsequently created bubble 2025-02-11 14:34:39 +00:00
Kevin McConnell bb5c767111 Recover recently-deleted bubbles 2025-02-11 14:34:39 +00:00
Kevin McConnell beaa8fa30c Formatting 2025-02-11 14:34:39 +00:00
Kevin McConnell c23d829063 Tidy 2025-02-11 14:34:39 +00:00
Kevin McConnell 70f7f100a9 Add publish/draft/cancel buttons to form 2025-02-11 14:34:39 +00:00
Kevin McConnell 321384b573 Replace "editing" param with creating? state 2025-02-11 14:34:39 +00:00
Jason Zimdars 04844504f1 Move to plain checkboxes instead of combobox 2025-02-04 16:51:06 -06:00
Jason Zimdars 92cc2c8121 Just use plain checkboxes
- Style WIP
2025-01-29 21:25:43 -06:00
Kevin McConnell 4c63f88620 Merge pull request #206 from basecamp/latest-activity
Latest activity
2025-01-28 17:43:06 +00:00
Kevin McConnell 13080a5c36 Simplify the methods a bit 2025-01-28 17:27:56 +00:00
Kevin McConnell cc1051c968 Expire upload links after 5 minutes
By default the Active Storage URLs are valid for 5 minutes. We should
avoid caching the responses for longer than that.
2025-01-28 16:13:26 +00:00
Kevin McConnell e93acb0e38 Don't repeatedly mark notifications read 2025-01-28 11:54:11 +00:00
Kevin McConnell c213914af6 Remove conditional caching on bubble
This leads to us showing stale assets after deployments. Removing for
now, until we add a more consistent cache strategy.
2025-01-28 11:34:08 +00:00
Jason Zimdars a847a71a57 Merge branch 'main' into latest-activity
* main:
  Undo weird flash notices
  Redirect to bucket after deleting
  Fix layout issues in Safari
  Should match text
  Add production deploy config
  Add Kamal deploy config
  Remove old deploy config
2025-01-27 17:11:27 -06:00
Jason Zimdars 7364720e42 Redirect to bucket after deleting 2025-01-27 16:55:57 -06:00
Kevin McConnell 1184ea8cf8 Smoosh empty days together 2025-01-27 17:07:46 +00:00
Kevin McConnell 3f3b5f3a61 Only show unique bubble entries in each cluster 2025-01-27 15:41:01 +00:00