Commit Graph

6511 Commits

Author SHA1 Message Date
Adrien Maston 3f7b33889b Update app/views/events/index/_add_card_button.html.erb
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-02-26 12:14:13 +01:00
Adrien Maston a62defb570 Just return the object 2026-02-26 11:48:01 +01:00
Adrien Maston 047e8efad3 Rename is-main-action to display-as-primary-action 2026-02-26 11:33:24 +01:00
Adrien Maston fc1ee616c8 Remove debug line 2026-02-26 11:13:39 +01:00
Adrien Maston 158e95de42 Rename show-label to display-title 2026-02-26 11:12:01 +01:00
Adrien Maston 7f058a7cea Make add card and mark done main actions 2026-02-25 17:55:15 +01:00
Adrien Maston feea5289b6 Apply to add/done actions 2026-02-25 17:08:41 +01:00
Adrien Maston 74b91c8832 Add "show label" and "main action" attributes 2026-02-25 17:08:11 +01:00
Adrien Maston bab9d1d34a Merge pull request #2594 from basecamp/mobile/fix-card-background-image
Mobile / Fix card background image
2026-02-25 11:20:27 +01:00
Adrien Maston 7fa0504057 Merge pull request #2605 from basecamp/mobile/fix-clipped-stalled-bubble
Mobile / Fix clipped stalled bubble
2026-02-25 10:20:53 +01:00
Adrien Maston 10c24b7734 Tweak translation 2026-02-24 17:48:24 +01:00
Adrien Maston 26282e3435 Use safe inset 2026-02-24 17:21:59 +01:00
Adrien Maston 88235a2737 Merge pull request #2602 from basecamp/fix-watching-overflow-dialog
Fix "watching" overflow dialog
2026-02-24 16:33:40 +01:00
Rosa Gutierrez 60b3c9c772 Fix duplicate push notification for mention and comment event
Event notifiers used the `mentionees` DB association to exclude mentioned
users from comment/card notifications. Since mentions are created async
via Mention::CreateJob, a race condition meant the mentionee list could
be empty when the event notification job ran first, causing the user to
receive both a comment and a mention push notification.

Use `scan_mentionees` instead, which scans the rich text body directly
for mentioned users without depending on Mention records existing yet.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-24 15:56:27 +01:00
Adrien Maston bd4cfbfd10 Change display on [open] dialog 2026-02-24 15:49:47 +01:00
Adrien Maston 7b93ec35b4 Merge pull request #2598 from basecamp/mobile/tweak-card-draft
Mobile / Tweak card draft
2026-02-24 14:56:31 +01:00
Denis Svara 3a14e3e338 Merge pull request #2599 from basecamp/mobile/path-config-setup
Mobile: Path config endpoint
2026-02-24 14:52:09 +01:00
Adrien Maston bf98b1a6d7 Adjust closed stamp position on perma 2026-02-24 12:44:13 +01:00
Denis Švara c0c78152c9 Add ios path config. 2026-02-24 11:26:07 +01:00
Denis Švara e00a51b6c2 Add android path config. 2026-02-24 11:26:00 +01:00
Denis Švara db9f67589c Implement ClientConfigurationsController for mobile client path config. 2026-02-24 11:25:07 +01:00
Adrien Maston b76f608c67 Simplify
Remove shadows and backgrounds
2026-02-24 11:22:20 +01:00
Stanko K.R. 2f9d4533c5 Relativize absolute links to the instance on export 2026-02-24 08:22:01 +01:00
Stanko K.R. 4eadce8ffe Automatically update account slugs in links 2026-02-24 08:11:47 +01:00
Stanko K.R. 55779f8ac4 Organize the record sets better 2026-02-24 07:36:51 +01:00
Stanko K.R. d8ed2f44b8 Reconcile card count after import 2026-02-24 07:36:20 +01:00
Jay Ohms d17acd39ef Merge pull request #2595 from basecamp/mobile/board-pull-to-refresh
Prevent pull-to-refresh gesture from conflicting with side scrolling on board perma
2026-02-23 11:43:24 -05:00
Adrien Maston e08413a2dd Merge pull request #2581 from basecamp/mobile/share
Mobile / Share
2026-02-23 17:13:44 +01:00
Jay Ohms 0ecc7527ca Prevent pull-to-refresh gesture conflicting with side scrolling on the board perma on Android 2026-02-23 11:02:10 -05:00
Adrien Maston a4f1a6b106 Coding style 2026-02-23 16:11:52 +01:00
Adrien Maston 0b229c701b Rename event 2026-02-23 16:10:54 +01:00
Adrien Maston 73068bc2cf Restrict top positioning of closed stamp to perma 2026-02-23 12:42:02 +01:00
Adrien Maston 5c7b3a8acb Keep reactions in static positioning on card perma
... and remove no longer needed styles
2026-02-23 12:41:38 +01:00
Fernando 8d2075b653 Merge pull request #2580 from basecamp/fix-hyphenated-search
Fix hyphenated search
2026-02-20 12:14:38 -06:00
Andy Smith cd80893957 Handle two column layout on mobile 2026-02-20 11:55:36 -06:00
Andy Smith dc0452fd0e Use flex instead of grid to better support single sections 2026-02-20 11:54:16 -06:00
Andy Smith 25adfbbcb0 Merge pull request #2584 from basecamp/settings-overflow-fix
Make generic scrollable list class for settings
2026-02-20 11:47:31 -06:00
Rosa Gutierrez 3e5233239b Fix push notification not firing on notification creation
- Rails only applies the last callback when `after_create_commit` and
  `after_update_commit` reference the same method name [1]:

> However, if you use the `after_create_commit` and the
`after_update_commit` callback with the same method name, it will only
allow the last callback defined to take effect, as they both internally
alias to `after_commit` which overrides previously defined callbacks
with the same method name.

- Push notifications were never sent when a notification was first
  created — only when the source was updated
- Replaced the two callbacks with a single `after_save_commit`, which
  fires on both create and update, with the
  `source_id_previously_changed?` guard (true for both new records and
  source changes)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

[1] https://guides.rubyonrails.org/active_record_callbacks.html#aliases-for-after-commit
2026-02-20 18:37:33 +01:00
Andy Smith 17d869cf08 Cleanup unused classes 2026-02-20 11:09:15 -06:00
Andy Smith f835c211af Make generic scrollable list class for settings 2026-02-20 11:05:26 -06:00
Adrien Maston 1d07e10650 Replace additional date by optional description 2026-02-20 17:18:53 +01:00
Adrien Maston 4e53000bc3 Add bridged share button to board and card permas 2026-02-20 13:03:33 +01:00
Adrien Maston 9569032403 Move helper to bridge helper file 2026-02-20 13:03:28 +01:00
Rosa Gutierrez bb6f2963b4 Revert commits accidentally pushed to main
Revert "Add bridged share button to board and card permas"
This reverts commit 069e165b43.

Revert "Move helper to bridge helper file"
This reverts commit 1ee37f046c.
2026-02-20 12:58:39 +01:00
Adrien Maston 069e165b43 Add bridged share button to board and card permas 2026-02-20 12:49:00 +01:00
Adrien Maston 1ee37f046c Move helper to bridge helper file 2026-02-20 12:46:00 +01:00
Fernando Olivares 554182f4b4 Fix stemmer stripping hyphens instead of splitting on them
The stemmer was concatenating tokens across hyphens (e.g. "BC3-IOS-1D8B"
→ "bc3ios1d8b") while the query sanitizer split on them, causing MySQL
MATCH AGAINST to never find the indexed token. Replace non-word chars
with spaces instead of stripping them so indexing and querying tokenize
consistently.

Requires search:reindex after deploy to rebuild existing search records.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-19 16:16:39 -06:00
Adrien Maston 92a845b17b Remove additional space above header
... to align with native titles
2026-02-19 17:54:02 +01:00
Adrien Maston 0394c44f22 Merge pull request #2577 from basecamp/fix-unpin-typo
Fix "Unpin" typo
2026-02-19 16:53:29 +01:00
Adrien Maston 904917f648 Up-pin should be Unpin 2026-02-19 16:36:32 +01:00