418548b9ba
More efficient query for watched_by? and use etag for the status
2025-11-03 16:51:21 +01:00
f5977522cb
Use shared callback to set card
2025-11-03 16:51:21 +01:00
f2d702fb54
Merge pull request #1457 from basecamp/assignee-update
...
A couple of fixes for updating cards:
2025-11-03 16:12:38 +01:00
24da4066b7
Refresh the full meta area so that the assignee name gets updated too
2025-11-03 16:11:53 +01:00
00818697ef
Use page refreshes with morphing to avoid flickering
...
Replacing the card container will reload the frame. Also, see
https://github.com/basecamp/fizzy/commit/5b70320a6b64adf2d1e0be4bd7dc221a5ba80c95
2025-11-03 16:11:53 +01:00
fcad4518da
Split callbacks for easier overwriting
2025-11-03 16:00:35 +01:00
6678d0e4fc
No longer used
2025-11-03 15:58:36 +01:00
65d04f681a
DRY up the public controllers by introducing a shared base class
2025-11-03 15:56:25 +01:00
393e5fd3d4
Don't want to ship with this wart
...
cc @monorkin
2025-11-03 15:30:44 +01:00
42ebdf9ac1
More natural conditional
2025-11-03 15:29:20 +01:00
9913853cc6
Remove anemic concern
2025-11-03 15:27:12 +01:00
3116cea6a1
Stick with turbo stream templates for everything
2025-11-03 15:18:04 +01:00
3ed5c53b31
Use existing CollectionScoped
...
It enforces access restrictions on collections too
2025-11-03 15:12:38 +01:00
8d28c25a7b
Unnecessary
2025-11-03 15:06:41 +01:00
ed9259fa1a
Ivar not used
2025-11-03 15:04:03 +01:00
995dcfe8e6
Simplify setup and pull query-prevention into model
2025-11-03 15:00:15 +01:00
2bf95f5b9a
Just stick to default
2025-11-03 14:49:01 +01:00
f9ff13cdc4
Add http caching for user events
2025-11-03 14:25:32 +01:00
b05e7c04e1
Ensure you can only delete your own avatar or else you have to be admin
2025-11-03 14:21:48 +01:00
4c2f3ef0b8
Style
2025-11-03 14:21:25 +01:00
3ec9308345
Always bang for exceptions
2025-11-03 14:21:06 +01:00
aeb23b691c
Always use templates for turbo streaming to stay consistentn
2025-11-03 13:46:34 +01:00
0a9e1620a0
No longer needed
2025-11-03 13:46:22 +01:00
da6d1011fd
Replace card replacement with stream actions to prevent flickering when managing steps
2025-11-03 10:59:24 +01:00
9d4dd3b00e
Remove "save as draft"
...
Removes the creating status completely as well as the abandoned cards system. It will
always resume drafts if they exist, for a given collection and user.
https://app.box-car.com/5986089/cards/2489
2025-11-03 09:32:29 +01:00
ebe1617f42
Format
2025-11-03 09:29:43 +01:00
9caf39ad2c
Use modern strong params syntax
2025-11-02 20:26:12 +01:00
39dc2b6ab9
Prefer explicit turbo stream templates
2025-11-02 20:22:15 +01:00
cf503bfba3
Prefer templates for turbo streams in all but the very simplest cases
...
(And probably even then)
2025-11-02 20:20:01 +01:00
3ccc93294f
Style
2025-11-02 18:13:23 +01:00
3ff7a88294
Style
2025-11-02 18:11:00 +01:00
fd61b4426c
Conventional to do includes first
2025-11-02 18:09:30 +01:00
828ac5d2c1
Conventional order of actions
2025-11-02 18:08:49 +01:00
43069b1ea4
Extract Users::JoinsController from overloaded UsersController
...
Good code smell is when the before_action callbacks stack up but can't
be shared across actions
2025-11-02 17:49:25 +01:00
bced7405df
Extract events loading from overloaded UsersController
2025-11-02 17:31:28 +01:00
6a62df470c
No longer used
2025-11-02 16:34:29 +01:00
877e62dec5
No CR when there are only two statements
2025-11-02 16:30:49 +01:00
02bd57089d
Use before_action to pull up account assignment
2025-11-02 16:04:44 +01:00
c834cce504
Simplify join code creation and validation and test controller
...
cc @monorkin
2025-11-02 15:58:33 +01:00
2c9845eb62
No need to hide that the top-level entropy is tied to the Account
2025-11-02 15:24:55 +01:00
0af74bfa11
Style
2025-11-02 14:17:46 +01:00
7052d6ecec
Fix style
2025-11-02 13:54:46 +01:00
b3474ec97d
Rename Entropy::Configuration to just Entropy
2025-11-02 13:11:41 +01:00
d29e4dcdcf
No CR when there are only two statements in total
2025-11-02 12:49:54 +01:00
e6459cede3
Use existing authorization method
2025-11-02 08:34:06 +01:00
49d865ffd1
Delete scoped session tokens when encountered
2025-10-31 19:00:37 +01:00
085c7fee2e
Fix Rubocop offenses
2025-10-31 16:35:44 +01:00
ece9008459
Remove dead code
2025-10-31 16:28:08 +01:00
dd583206ee
Allow changes to the Account name
2025-10-31 16:26:08 +01:00
452c6a8373
Rework the email change flow to tie to memberships
2025-10-31 16:26:08 +01:00
David Heinemeier Hansson