Commit Graph

1039 Commits

Author SHA1 Message Date
Jason Zimdars 53b906423a Overflow needs to be on the nearest item 2025-03-20 18:12:43 -05:00
Jason Zimdars 39ebeadc08 Hide button when empty 2025-03-20 18:04:39 -05:00
Jason Zimdars 9dba039096 Missing class 2025-03-20 17:59:29 -05:00
Jason Zimdars eaf927f1a8 Refactor tray styles 2025-03-20 17:54:24 -05:00
Jason Zimdars 0da84efd01 Tray pins design 2025-03-20 16:52:56 -05:00
Jason Zimdars 1802a6391a Tweak events and dates 2025-03-20 13:54:56 -05:00
Jason Zimdars 0e0513dd77 Try addressing clipped descenders another way 2025-03-20 11:52:33 -05:00
Jason Zimdars 2f2dd1248d Revert "Address line-height"
This reverts commit efaeb26fab.
2025-03-20 11:52:33 -05:00
Mike Dalessio 947b963157 Merge pull request #308 from basecamp/flavorjones-fix-card-cache-on-bucket-change
Use the bucket name as part of the card cache key
2025-03-20 12:49:54 -04:00
Mike Dalessio 473703df3d Invalidate the bubble cache when the bucket name changes
by including the bucket name as part of the bubble cache key.

ref: https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008709

Co-authored-by: Kevin McConnell <kevin@37signals.com>
2025-03-20 12:46:23 -04:00
Jason Zimdars 2e0f787777 Polish trays behavior 2025-03-20 11:41:17 -05:00
Jason Zimdars e92995b5e5 Account for untitled bubbles 2025-03-20 11:41:02 -05:00
Jason Zimdars efaeb26fab Address line-height 2025-03-20 11:16:31 -05:00
Jason Zimdars 7f06504a55 Ensure something is rendered when title is blank 2025-03-20 11:16:31 -05:00
Jason Zimdars 015b26e7e8 Dark mode 2025-03-20 11:16:31 -05:00
Jason Zimdars e315e66d58 Keep it top right 2025-03-19 17:54:52 -05:00
Jason Zimdars f4b1c0593b Missing summary 2025-03-19 17:50:26 -05:00
Jason Zimdars 05d377e919 Actually let's use the icons and the state 2025-03-19 17:45:20 -05:00
Jason Zimdars 4370281f67 Add a missing event, adjust icons 2025-03-19 17:02:05 -05:00
Jason Zimdars 264d78b21a Update test 2025-03-19 16:37:06 -05:00
Jason Zimdars eabb5a14c8 This is causing layout issues with code blocks
Ideally they would scroll and keep the original line breaks but the layout needs proper constraints for that to happen
2025-03-19 16:34:33 -05:00
Jason Zimdars 572428bfbc Improved comments and events layout 2025-03-19 16:33:03 -05:00
Jason Zimdars 714ae9d317 Differentiate events with an icon 2025-03-19 13:35:17 -05:00
Jason Zimdars 8e26106a07 Reorder and rename activity columns; include system popped events 2025-03-19 13:35:17 -05:00
Mike Dalessio a6197753ff Make sure first runs redirect will work
by turning off turbo on the form
2025-03-19 12:36:32 -04:00
Jason Zimdars 5973d14e2c Trays everywhere 2025-03-18 17:13:57 -05:00
Jason Zimdars fc163886e8 Move search onto home 2025-03-18 17:11:42 -05:00
Jason Zimdars de851fa69c Move back to edges 2025-03-18 17:10:50 -05:00
Jason Zimdars b99fc7484b Handful of tweaks 2025-03-18 16:01:31 -05:00
Jason Zimdars b498dfd752 Restore related events hover effect 2025-03-18 15:59:37 -05:00
Kevin McConnell 4216b1123e Formatting 2025-03-18 17:53:32 +00:00
Kevin McConnell bc5e32e737 Only "published" notifies collection subscribers
The other notifications are only sent to the watchers of the bubble.
2025-03-18 17:46:57 +00:00
Jason Zimdars 836e6fab5e Avoid touch when setting initial stage 2025-03-18 08:26:16 -05:00
Jason Zimdars 28a569c49b Tickets 2025-03-17 21:24:08 -05:00
Jason Zimdars e53052b7e7 Fix visual button regression
`.for-screen-reader` has specific behavior inside `.btn` that makes it unsuitable for use on form elements. This fix adds a second, functionally identical, class `visually-hidden` for those cases. Later we can figure out a way to make it clear when to use which.
2025-03-14 09:58:50 -05:00
Bruno Prieto 10cdb8c1a8 Improve accessibility of comments and reactions 2025-03-14 02:29:44 +01:00
Bruno Prieto 7354e74432 Improve bubble readability for screen readers 2025-03-14 01:35:40 +01:00
Bruno Prieto 63a098fcdb Fix filter input and label id assigments 2025-03-13 23:44:05 +01:00
Bruno Prieto 793a43ff27 Add aria-label and aria-description to filter dialog
Otherwise the browser will try to infer the properties. That process is slow for screen readers
2025-03-13 22:56:28 +01:00
Bruno Prieto dfb49d0f87 Add aria-label and aria-description to filter dialog
Otherwise the browser will try to infer the properties. That process is slow for screen readers
2025-03-13 22:46:19 +01:00
Bruno Prieto cea43da13f Organize filter inputs by group, similar to fieldset
Menu tag is deprecated, li elements are only valid inside ul or ol elements
2025-03-13 22:36:12 +01:00
Bruno Prieto fdd3fb53c0 Label tag don't need a for attribute if it has a input as a children
Then input ids aren't required
2025-03-13 22:20:40 +01:00
Bruno Prieto 8a9d57e4c8 Show filter inputs for screen readers 2025-03-13 21:53:53 +01:00
Bruno Prieto bcda67e114 Div is not a valid parent for list of li elements 2025-03-13 21:25:26 +01:00
Bruno Prieto 4425e0d16a Hide bubbles for SR users for now 2025-03-13 21:24:30 +01:00
Mike Dalessio 3e374f4661 fix: Send assignment notifications only to the assignee(s)
ref: https://37s.fizzy.37signals.com/buckets/693169850/bubbles/999008619
2025-03-13 12:16:47 -04:00
Mike Dalessio 4af0fe01d6 Update recurring jobs to iterate over all tenants 2025-03-12 07:53:31 -04:00
Mike Dalessio d9ece38753 Make the application multi-tenant 2025-03-12 07:53:31 -04:00
Kevin McConnell f50a880d6b Avoid double render in Avatars#show
After sending the conditional 304 response, we were still attempting to
render the response, which is unnecessary.
2025-03-12 09:05:50 +00:00
Mike Dalessio e0fa376d4f Update scoreable to return a large positive number when score==0 (#290)
Avoid infinite activity score orders

Items with a zero activity score were getting an activity sorting score
of -infinity, because we base the value on log2(score). Adjusting the
calculation avoids this edge case, by always basing the sorting score on
a non-zero number.

---------

Co-authored-by: Kevin McConnell <kevin@37signals.com>
2025-03-11 07:39:17 -04:00