Commit Graph

1618 Commits

Author SHA1 Message Date
David Heinemeier Hansson 89d1b316f0 Name is already schema and UI required
And we are not using these validations for display anywhere.
2025-04-21 09:21:55 +02:00
David Heinemeier Hansson dc2205ee79 Cards have a not-null schema and collections destroy all cards on deletion
This shouldnt be necessary. Maybe remnant of some previous design?
2025-04-21 09:18:42 +02:00
David Heinemeier Hansson 48a6c05250 No longer used 2025-04-20 16:23:15 +02:00
David Heinemeier Hansson d3fa62d4c2 Inline touch check thats only used once
Not worth loading an entire file for this.
2025-04-20 16:21:08 +02:00
David Heinemeier Hansson 78369725c4 Move card concern logic into those concerns 2025-04-18 17:18:28 +02:00
David Heinemeier Hansson cacee0febb Remove anemic scope 2025-04-18 17:18:13 +02:00
David Heinemeier Hansson f368b9f9c9 Inline anemic method 2025-04-18 17:13:11 +02:00
David Heinemeier Hansson aae6c7b1a2 Indention 2025-04-18 17:09:55 +02:00
David Heinemeier Hansson 7c76bdd96d Drop Scorable concern 2025-04-18 17:07:36 +02:00
David Heinemeier Hansson 3eeb121ea1 Cards are no longer resized on the basis of activity scores 2025-04-18 17:00:13 +02:00
David Heinemeier Hansson c65639a3ce No longer used
Seemed to have been used for an old combobox design
2025-04-18 16:52:55 +02:00
David Heinemeier Hansson 9aef965db8 No longer used
I assume it was from the old bubble design
2025-04-18 16:49:36 +02:00
David Heinemeier Hansson 247524da29 Stlye 2025-04-18 16:47:53 +02:00
David Heinemeier Hansson 406c764253 Style 2025-04-18 16:46:20 +02:00
David Heinemeier Hansson c6f363c281 Style 2025-04-18 16:42:35 +02:00
David Heinemeier Hansson 9cea403acd Make sure that any card getting read does not empty out the notifications tray
Since we wont rehydrate it
2025-04-18 16:32:27 +02:00
David Heinemeier Hansson f594bc09a0 Simplify
This is coming straight from the form, unlikely to blow up
2025-04-18 16:24:54 +02:00
David Heinemeier Hansson 7b0d3d033f Fix extra space 2025-04-18 16:08:53 +02:00
David Heinemeier Hansson f6cd21f7cb Extract default stages into something that will be created together with a new Workflow in the model 2025-04-18 16:07:01 +02:00
David Heinemeier Hansson 1026408736 Need this for the draft header to be visible 2025-04-18 15:22:59 +02:00
David Heinemeier Hansson f3000a02c5 Follow render_card_replacement pattern
And clean up the rest of the implementation a tad.
2025-04-18 15:20:38 +02:00
David Heinemeier Hansson 7395d4e034 Removing the image can also just be done as a card replacement 2025-04-18 15:14:36 +02:00
David Heinemeier Hansson de23b4a866 Not needed for a single dependency 2025-04-18 15:10:47 +02:00
Jason Zimdars e16dc859e3 Display the empty message via CSS when there are no unread notifications 2025-04-17 16:57:24 -05:00
Jason Zimdars b37a8e3f33 Hide Previously Seen section when empty with CSS 2025-04-17 16:54:11 -05:00
David Heinemeier Hansson b8775d41f5 Inline perma to container partial
Reveals all the container elements and perma wasnt used elsewhere.
2025-04-17 16:06:28 +02:00
David Heinemeier Hansson 0e442ac0d0 Use card replacement for card updates too 2025-04-17 15:56:56 +02:00
David Heinemeier Hansson 461c104ac2 Extract helper method to keep partial at a uniform level of abstraction 2025-04-17 15:42:07 +02:00
David Heinemeier Hansson 63b2abe020 Remove duplicated conditional 2025-04-17 15:38:47 +02:00
David Heinemeier Hansson b508a93aba Style 2025-04-17 15:36:11 +02:00
David Heinemeier Hansson 182d1c934b Note that we dont want to keep reloading these frames 2025-04-17 15:35:56 +02:00
David Heinemeier Hansson ac9cbad4f9 I like this even better 2025-04-17 15:32:09 +02:00
David Heinemeier Hansson 62088b66d1 Suffix qualifier is unnnecessary 2025-04-17 15:30:55 +02:00
David Heinemeier Hansson df1f623435 Group partials for container 2025-04-17 15:25:11 +02:00
David Heinemeier Hansson b788ef1638 Match domain language 2025-04-17 15:23:40 +02:00
David Heinemeier Hansson 4dbd8205ce Fix trailing space 2025-04-17 15:21:14 +02:00
David Heinemeier Hansson 7adbd8d634 Use card rerendering instead of redirects 2025-04-17 15:20:27 +02:00
David Heinemeier Hansson d019e282ae Better name 2025-04-17 15:00:14 +02:00
David Heinemeier Hansson 770029c26d Stick with domain language 2025-04-17 14:59:15 +02:00
David Heinemeier Hansson 547e5ea24f Rerender instead of redirect 2025-04-17 14:54:29 +02:00
David Heinemeier Hansson ab1835294d Style 2025-04-17 14:53:45 +02:00
David Heinemeier Hansson f24287915f Extract partials that can be rerendered 2025-04-17 14:52:35 +02:00
David Heinemeier Hansson 4d0dddec46 No need to loop through a job when this is the sole point of the action 2025-04-17 14:31:28 +02:00
David Heinemeier Hansson 87ce4a623b Even clearer about where these pins are going 2025-04-17 14:31:02 +02:00
David Heinemeier Hansson 1437bcb3b7 Clearer about where these are being sent 2025-04-17 14:29:12 +02:00
David Heinemeier Hansson 8fe8241069 Reuse create template 2025-04-17 14:14:08 +02:00
David Heinemeier Hansson bddd624e41 Match template name to container id 2025-04-17 14:14:03 +02:00
David Heinemeier Hansson fc0cf3917f Pin without redirect
Use turbo stream response to save on the redirect latency
2025-04-17 14:05:26 +02:00
David Heinemeier Hansson 07e801b74c Fix pinning to tray
They need to have a complete dom element that is unique
2025-04-17 13:52:55 +02:00
David Heinemeier Hansson 0c743d27a8 There is no more/less flicker with morphing
Where did you see the flickering that this solved, @jorgemanrubia?
2025-04-17 13:42:49 +02:00