Commit Graph

63 Commits

Author SHA1 Message Date
Andy Smith 78273898d2 Remove testing colors 2025-08-14 16:33:56 -05:00
Andy Smith dfefd16f0f Place orient classes in popup CSS 2025-08-14 16:33:18 -05:00
Andy Smith d25f628204 Extract orient into a module 2025-08-14 16:32:18 -05:00
Andy Smith c444011095 Working left/right orientation 2025-08-14 14:59:50 -05:00
Andy Smith 0843e3d555 Hack for Safari sticky-footer-while-transitioning bug 2025-08-13 15:42:03 -05:00
Andy Smith 994694308f Remove sticky footer in popup 2025-08-11 17:09:41 -05:00
Andy Smith 3b97e905c6 Make popup group title padding more targeted 2025-08-05 16:44:20 -05:00
Andy Smith 72194598d9 Merge pull request #849 from basecamp/filter-improvements
Filter improvements
2025-08-05 15:34:27 -05:00
Andy Smith d5a1c9824c Merge pull request #836 from basecamp/lightbox-improvements
Lightbox improvements
2025-08-05 09:59:37 -05:00
Andy Smith 7211d7f953 Make group title sticky when scrolling 2025-08-04 16:00:03 -05:00
Andy Smith 6d43582f5b Hide lists when children are all hidden 2025-08-04 15:54:16 -05:00
Andy Smith f587fd7e1f Handle group padding better 2025-08-04 15:04:59 -05:00
Andy Smith f0c63bd2f1 Better padding and alignment for radio buttons in filter menu 2025-08-04 14:56:24 -05:00
Andy Smith 3f7f414c34 Animate the lightbox 2025-07-30 17:26:05 -05:00
Andy Smith c00914b9c8 Hoist up dialog variable 2025-07-30 16:15:33 -05:00
Andy Smith 06c2e6d0aa Put animated popups within cascade layer 2025-07-21 14:03:15 -05:00
Andy Smith 67df61b57d Dry up utility classes for popup__group 2025-07-21 13:59:33 -05:00
Andy Smith ace44d709e Inline padding for popup__items, not popup__groups 2025-07-21 13:40:59 -05:00
Andy Smith 37cc6a6955 popup__items full-width by default 2025-07-21 13:37:33 -05:00
Andy Smith 1e62ae8c94 Set min-width on popup__items 2025-07-21 13:32:56 -05:00
Andy Smith a2f9339cdb Remove unused --outline vars 2025-07-02 16:40:59 -05:00
Andy Smith 4bc1b36d3d Clean up --hover variables 2025-07-02 16:14:34 -05:00
Jason Zimdars 3af949edca Merge branch 'main' into filter-ignore-diacritics
* main:
  Clear the comments cache
  Add context for search screens
  Needs changed for both states
  Use lighter icon and update asset
  Add btn--circle class to user edit form
  Organize button variants
  Untangle `avatar btn` crossover styles
  Remove redundant classes and styles for avatars
  Adjust footer line height
  Tweak padding
2025-06-30 17:01:43 -05:00
Andy Smith 95310da203 Merge pull request #650 from basecamp/misc-polish
Tweak padding
2025-06-30 15:07:41 -05:00
Jason Zimdars 2678f8c099 Convert diacritics to approximations before filtering
- Introduces a helper method for setting the filterable value
- Updates `filter_controller.js` to use `data-filter-text-value` attribute populated with converted content. This was previous `data-value` in the earlier implementation but ignored in the current on.
- Also uses the same helper to make @mentions diacritic insensitive
2025-06-30 13:53:50 -05:00
Jason Zimdars d420d8d8ac Add keyboard navigation and filtering to quick filters 2025-06-26 16:56:27 -05:00
Andy Smith fb8eb089c5 Adjust footer line height 2025-06-24 16:05:07 -05:00
Andy Smith a48d1854ef Tweak padding 2025-06-24 15:59:59 -05:00
Jason Zimdars 23bb045111 Rework menu sizing 2025-06-23 17:56:26 -05:00
Jason Zimdars c2b92fd4f5 DRY this up 2025-06-19 20:42:11 -05:00
Jason Zimdars 8b9ee506a5 DRY up, tweak look 2025-06-19 20:24:02 -05:00
Jason Zimdars 4edb5e5a01 Try plain color items 2025-06-19 18:13:24 -05:00
Jason Zimdars 9553a75ea9 Adjust styles when footer is present 2025-06-19 17:56:21 -05:00
Jason Zimdars 0d03c4027c Clearer put before nested selectors 2025-06-19 15:09:54 -05:00
Jason Zimdars 1b1a38b8a1 Render tags and users in menu, filter them 2025-06-18 15:36:01 -05:00
Jason Zimdars dc5c8d17a4 Handle these special case options a different way 2025-06-02 15:49:44 -05:00
Jason Zimdars 0be387bb41 Add distinct navigation selected styles 2025-06-02 15:18:27 -05:00
Jorge Manrubia 61fbad218b Make tag filters selectable/navigable too 2025-06-02 18:39:44 +02:00
Jorge Manrubia 37fd2b248d Revamp filters menu (WIP)
- Make them navigable by keyboard (UP, DOWN, ENTER to activate option).
- Filter based on the actual text in the element, use containment condition instead of CSS selector on value prefix.
- Make all the elements in the filter searchable and reachable by keyboard.
2025-06-02 14:51:03 +02:00
Andy Smith 6eb5ae3e95 Mobile styles 2025-05-13 15:48:11 -05:00
Jason Zimdars d8c2591296 Adjust for svg icons 2025-05-06 15:45:28 -05:00
Jason Zimdars c6542e3d85 Filter assignees 2025-04-30 11:27:42 +02:00
Jason Zimdars 9d6e40904f Adjust size for demo 2025-04-27 21:26:06 +02:00
Jason Zimdars 57aa58352d Keyboard focus effect 2025-04-27 17:07:56 +02:00
Jason Zimdars dfdb4eee6b Constrain width for filtering 2025-04-27 16:30:42 +02:00
Jason Zimdars ec0fcf7420 Ensure entire row is clickable 2025-04-27 16:12:19 +02:00
Jason Zimdars 0fa0622b06 Post-merge misc 2025-04-25 16:18:46 -05:00
Jason Zimdars a3b81af1da Merge branch 'main' into colors
* main: (284 commits)
  Polish closed stamp
  Add new card button to considering column
  Let's leave inside the menu for now
  Improve terminal history behavior
  More space between
  Add a navigation hint, make "All collections" link navigate like the others
  Reorder methods
  Fix: dismiss notifications from comments
  Fix card icons
  Filter collections menus, add keyboard shortcuts
  Style
  Space between
  Remove debug
  Consistent sizing
  Configure deployment for load balancing
  Configure the autoclose period at the collection level
  Rename to avoid using the same name
  Add brakeman rule
  Collections can be private now too
  Not used outside the class anymore
  ...
2025-04-25 15:59:09 -05:00
Jason Zimdars 7e3bd75b15 Overflow long menus 2025-04-23 16:43:55 -05:00
Jason Zimdars 4bce7f1b5c Adjust spacing, bring back "All Collections" option 2025-04-23 16:39:47 -05:00