Commit Graph

3508 Commits

Author SHA1 Message Date
Jorge Manrubia 6392180493 Merge pull request #419 from basecamp/revert-408-add-card-description
Revert "Add a description field for cards"
2025-04-21 16:42:09 +02:00
Jorge Manrubia a4cc143b09 Revert "Add a description field for cards" 2025-04-21 16:41:33 +02:00
David Heinemeier Hansson 4d1a1382e1 Fix seeds for new descriptions 2025-04-21 16:21:20 +02:00
Jorge Manrubia 9ecd7f7a60 Merge pull request #408 from basecamp/add-card-description
Add a description field for cards
2025-04-21 16:06:47 +02:00
Jorge Manrubia fb83b5e70e Merge branch 'main' into add-card-description
* main:
  Fix trailing empty line
  --skip-server in ci setup
  Enumerate all the options for logging in
  Have an empty first-run tenant too
  Convert to conventional Rails style
  Seed multiple seed accounts with basic DSL
  Stlye
  No need to run Solid Cache in development
  Use morphing to replace the card and exclude turbo frames from being replaced
  Name is already schema and UI required
  Cards have a not-null schema and collections destroy all cards on deletion
  No longer used
  Inline touch check thats only used once

# Conflicts:
#	app/views/cards/_container.html.erb
2025-04-21 16:04:06 +02:00
David Heinemeier Hansson 539b26c7df Small enough DSL to inline it 2025-04-21 16:01:01 +02:00
David Heinemeier Hansson 55789b7a34 Merge pull request #416 from basecamp/replace-with-morph
Use morphing in the stream replace the card container
2025-04-21 15:40:28 +02:00
David Heinemeier Hansson ad2c1ca8fc Merge pull request #418 from basecamp/seed-multiple-dev-accounts
Seed multiple seed accounts with basic DSL
2025-04-21 15:27:10 +02:00
David Heinemeier Hansson 581070b22c Fix trailing empty line 2025-04-21 15:26:47 +02:00
David Heinemeier Hansson e1b2b623e8 --skip-server in ci setup 2025-04-21 15:26:19 +02:00
David Heinemeier Hansson 29948d8881 Enumerate all the options for logging in 2025-04-21 15:23:31 +02:00
David Heinemeier Hansson dc12751192 Have an empty first-run tenant too 2025-04-21 15:23:18 +02:00
David Heinemeier Hansson 2bfead0381 Convert to conventional Rails style 2025-04-21 15:23:08 +02:00
Jorge Manrubia 99dbc04e2c Format 2025-04-21 15:20:03 +02:00
Jorge Manrubia ffdec1cc3b Index description too 2025-04-21 15:18:11 +02:00
David Heinemeier Hansson b6584ed655 Seed multiple seed accounts with basic DSL 2025-04-21 15:12:57 +02:00
Jorge Manrubia 7925cd7bf9 Extract partials 2025-04-21 14:52:21 +02:00
Jorge Manrubia 491e743c27 Place below associations 2025-04-21 14:48:07 +02:00
David Heinemeier Hansson 167563d9f8 Stlye 2025-04-21 14:01:53 +02:00
David Heinemeier Hansson 4b294ccaa6 No need to run Solid Cache in development 2025-04-21 13:55:09 +02:00
Jorge Manrubia 3e1a2bcc7e Use morphing to replace the card and exclude turbo frames from being replaced
Reconnecting the frames result in a visible flickering.

This also prevents flickering in the avatars when replacing the card container.
2025-04-21 09:24:57 +02:00
David Heinemeier Hansson 89d1b316f0 Name is already schema and UI required
And we are not using these validations for display anywhere.
2025-04-21 09:21:55 +02:00
David Heinemeier Hansson dc2205ee79 Cards have a not-null schema and collections destroy all cards on deletion
This shouldnt be necessary. Maybe remnant of some previous design?
2025-04-21 09:18:42 +02:00
David Heinemeier Hansson 48a6c05250 No longer used 2025-04-20 16:23:15 +02:00
David Heinemeier Hansson d3fa62d4c2 Inline touch check thats only used once
Not worth loading an entire file for this.
2025-04-20 16:21:08 +02:00
David Heinemeier Hansson ccd98f6d98 Update card.rb 2025-04-19 20:01:41 +02:00
David Heinemeier Hansson 9e921b85c0 Merge branch 'main' into add-card-description 2025-04-19 20:00:43 +02:00
David Heinemeier Hansson 883a225946 Use upstreamed assert_in_body 2025-04-19 10:08:08 +02:00
Andy Smith f82dd39305 Same sizes for swatches 2025-04-18 15:10:43 -05:00
Andy Smith 7b86c4f607 Align color picker 2025-04-18 15:00:46 -05:00
Andy Smith 46374adcf6 Tweak golden card color 2025-04-18 11:43:27 -05:00
Andy Smith f3767f2584 Use variables for card colors 2025-04-18 11:26:13 -05:00
David Heinemeier Hansson 78369725c4 Move card concern logic into those concerns 2025-04-18 17:18:28 +02:00
David Heinemeier Hansson cacee0febb Remove anemic scope 2025-04-18 17:18:13 +02:00
David Heinemeier Hansson f368b9f9c9 Inline anemic method 2025-04-18 17:13:11 +02:00
David Heinemeier Hansson aae6c7b1a2 Indention 2025-04-18 17:09:55 +02:00
David Heinemeier Hansson 82c9b011ac Merge pull request #414 from basecamp/drop-activity-score
Drop activity scoring
2025-04-18 17:09:22 +02:00
David Heinemeier Hansson 7c76bdd96d Drop Scorable concern 2025-04-18 17:07:36 +02:00
David Heinemeier Hansson 1114679c20 Remove activity score columns 2025-04-18 17:05:17 +02:00
David Heinemeier Hansson 3eeb121ea1 Cards are no longer resized on the basis of activity scores 2025-04-18 17:00:13 +02:00
David Heinemeier Hansson c65639a3ce No longer used
Seemed to have been used for an old combobox design
2025-04-18 16:52:55 +02:00
David Heinemeier Hansson 9aef965db8 No longer used
I assume it was from the old bubble design
2025-04-18 16:49:36 +02:00
David Heinemeier Hansson 247524da29 Stlye 2025-04-18 16:47:53 +02:00
David Heinemeier Hansson 406c764253 Style 2025-04-18 16:46:20 +02:00
David Heinemeier Hansson c6f363c281 Style 2025-04-18 16:42:35 +02:00
David Heinemeier Hansson 9cea403acd Make sure that any card getting read does not empty out the notifications tray
Since we wont rehydrate it
2025-04-18 16:32:27 +02:00
David Heinemeier Hansson 129bc01e33 Merge pull request #413 from basecamp/refactor-workflow-default-stages
Refactor workflow default stages
2025-04-18 16:31:08 +02:00
David Heinemeier Hansson 70275c9f04 Yank Solid Queue from development
It clogs up the test log and occasionally causes the puma to hang when
you want to quit.
2025-04-18 16:30:30 +02:00
David Heinemeier Hansson f594bc09a0 Simplify
This is coming straight from the form, unlikely to blow up
2025-04-18 16:24:54 +02:00
David Heinemeier Hansson 3003105ac9 Flesh out the rest of the controller tests 2025-04-18 16:16:04 +02:00