263b3336db
Add missing CR
2025-04-11 17:50:53 +02:00
0954cfe008
Add CR
2025-04-11 17:48:01 +02:00
79700162fc
Use correct stream name
...
comment, :comments makes no sense for a stream for the reactions
2025-04-11 17:47:35 +02:00
eec76d0d4f
Use modern params#expect
2025-04-11 17:43:31 +02:00
f9bb779b61
Use local vars so ivar dependency is only from before actions
2025-04-11 17:42:30 +02:00
3ecf150636
Use proper access control
...
Otherwise you could react to any comment on the entire account. And then
you might as well just do Comment.find.
2025-04-11 17:41:28 +02:00
dc4e50fba5
Move messages partial under cards
2025-04-11 17:34:49 +02:00
5084bbf3b7
Use modern params#expect syntax
2025-04-11 17:01:19 +02:00
8a4a087a00
Fine to let destroying something destroyed be a no-op
...
Would be an edge-casey race condition, but its possible
2025-04-11 17:00:08 +02:00
256d536009
Always use _path unless we are changing domains
2025-04-11 16:58:56 +02:00
16c1583133
Usually the order comes last
2025-04-11 16:58:47 +02:00
5ecf0ce3f6
Stick with one term
2025-04-11 16:57:03 +02:00
a8aa2c4f80
Clean up the controller
2025-04-11 16:49:55 +02:00
f2811803d3
Needed to come first
2025-04-11 16:32:06 +02:00
adabfba636
In order of appearance
2025-04-11 16:31:16 +02:00
0084dde686
Merge pull request #397 from basecamp/move-comments-under-cards
...
Move comments under cards
2025-04-11 16:26:43 +02:00
cbdb9aa113
Schema movement -- is this because the dumper doesnt sort deterministically? cc @flavorjones
2025-04-11 16:24:38 +02:00
f4ce57e308
Move comments under cards
2025-04-11 16:21:44 +02:00
64b529ce94
Fix indention
2025-04-11 16:12:18 +02:00
67917ff4d1
Merge pull request #396 from basecamp/fix-turbo-morph-issue
...
Refresh timers when morphing happens
2025-04-11 13:26:38 +02:00
ba6eab509c
Refresh timers when morphing happens
2025-04-11 13:26:01 +02:00
4e91d8a666
Merge pull request #395 from basecamp/golden-doing
...
Only consider golden those cards in "doing"
2025-04-11 12:04:00 +02:00
825bbf808e
Extract helper for card articles, use classes to determine when to show golden status
2025-04-11 12:01:52 +02:00
aef75feead
Only consider golden those cards in "doing"
2025-04-11 11:49:52 +02:00
1275abd99e
Fix recently completed order for good!
2025-04-11 11:37:02 +02:00
66b5732264
Place recently closed cards first
2025-04-11 11:27:38 +02:00
bf038c7a74
Merge pull request #392 from basecamp/gold-cards
...
Gold cards
2025-04-11 10:49:45 +02:00
17aa9b97e9
Monkey patch a prepend_order method
2025-04-11 10:28:12 +02:00
4f3f322528
Rename inconsistency: go with goldness
2025-04-11 10:22:18 +02:00
eae1669ac3
Touch
2025-04-11 10:20:30 +02:00
806609e77b
Use gild/ungild
2025-04-11 10:20:06 +02:00
b4297ab852
Format
2025-04-11 09:57:45 +02:00
f4b2bec5ce
Fix test
2025-04-11 09:57:45 +02:00
492a42ba92
Not needed anymore
2025-04-11 09:57:45 +02:00
5360b4ccb4
Add comment
2025-04-11 09:57:45 +02:00
1bac0b84b3
Add tests
2025-04-11 09:36:24 +02:00
70a59eb341
WIP pins
2025-04-10 17:42:17 -05:00
da7a30203c
Style golden cards
2025-04-10 17:14:04 -05:00
57c76b6259
Consistent card resizing
2025-04-10 17:09:06 -05:00
5560976091
Merge branch 'main' into gold-cards
...
* main:
Try a segmented toggle for engagement
Fix tests
Rework min card design and meta section for all cards
Move `title` to the `img` element so we get hover in both cases
Remove sorting filter UI
Sort Considering and Doing by `updated_at`
Restore comment action icon
Fix dot escaping container
Seen cards should be flat
Ensure overflow cards are hidden
Arrow needs to match derived color
Dialog target needs to be present
This isn't necessary in the mini card template
Revert "The button and dialog need not render in previews"
2025-04-10 16:42:45 -05:00
0c107c5894
Fix that cards which were Drafted or in Considering were also being displayed in Doing
...
CC: @jorgemanrubia
2025-04-10 16:42:40 -05:00
7ef49ccffa
Polish up columns
2025-04-10 16:16:36 -05:00
81ee2ab64d
Try a segmented toggle for engagement
2025-04-10 16:06:35 -05:00
7c3c3a9ef5
Less space above card-perma
2025-04-10 15:44:45 -05:00
74d1571b19
Merge branch 'main' into consolidate-cards
...
* main: (45 commits)
Fix tests
Rework min card design and meta section for all cards
Move `title` to the `img` element so we get hover in both cases
Remove sorting filter UI
Sort Considering and Doing by `updated_at`
Restore comment action icon
Fix dot escaping container
Seen cards should be flat
Ensure overflow cards are hidden
Arrow needs to match derived color
Dialog target needs to be present
This isn't necessary in the mini card template
Revert "The button and dialog need not render in previews"
Paginate collection cards
Add a rails helper for the new custom stream action
Add test
Reflect picked color automatically with a custom stream action
Simplify conditions to pick up a color
Reuse existing constant
Update fixtures and test
...
2025-04-10 15:12:38 -05:00
2d17e86945
Flat card styles
2025-04-10 15:02:03 -05:00
8429669bf5
WIP card columns
2025-04-10 14:56:52 -05:00
ca067f7ca0
Fix tests
...
This is cheating a little because Doing and Considering are both always sorted by Latest at the moment. Keeping it like this while we vet this new direction
2025-04-10 14:42:42 -05:00
e4110734eb
Rework min card design and meta section for all cards
2025-04-10 14:39:50 -05:00
7fdf9ab2fd
Move title to the img element so we get hover in both cases
2025-04-10 14:39:19 -05:00
David Heinemeier Hansson