Commit Graph

3508 Commits

Author SHA1 Message Date
Jorge Manrubia d22cbe6f7f Add tests for stalled detection 2025-06-05 15:09:55 +02:00
Jorge Manrubia 35731980fb extract method 2025-06-05 14:06:21 +02:00
Jorge Manrubia fee3ae45c8 Fix duplicated reopened card 2025-06-05 13:55:53 +02:00
Jorge Manrubia eb95af4add Add test for reopening cards 2025-06-05 13:29:34 +02:00
Jorge Manrubia 7c1bd23460 Exclude body checking in this test
Requests like summarize can result in completely different responses
2025-06-05 13:02:40 +02:00
Kevin McConnell e998783155 Use VFS-based Beamer 2025-06-05 11:59:30 +01:00
Jorge Manrubia 3df7d3e5a8 Match requests by body
So that modifying the prompt make the tests fail

If not, the tests defeat their purpose!
2025-06-05 12:45:45 +02:00
Jorge Manrubia 9b4cd7eff2 Remove vcr_record! 2025-06-05 12:36:37 +02:00
Jorge Manrubia 7eb1930eb3 Test for stalled cards 2025-06-05 12:36:12 +02:00
Jorge Manrubia 7c657a2bd9 Support stalled filtering 2025-06-05 12:07:55 +02:00
Jorge Manrubia 6fec61edf4 Tweak params 2025-06-05 11:19:03 +02:00
Jorge Manrubia 19e27370fa Stimulus can't handle "null" JSON string 2025-06-05 11:10:09 +02:00
Jorge Manrubia fbe12014ab Format 2025-06-05 11:08:37 +02:00
Jorge Manrubia 6e8087ee2e Toggle entropy/stalled container in the bubbles controller 2025-06-05 11:08:20 +02:00
Jorge Manrubia bfa4dc626b Restructure to make it easy to extend rendering logic 2025-06-05 10:39:51 +02:00
Jorge Manrubia 76119b17bd Entropy, not bubble! 2025-06-05 10:33:02 +02:00
Jorge Manrubia 22ed605884 Namespace bubble-related targets 2025-06-05 10:32:14 +02:00
Jorge Manrubia 2cbd451944 Group entropy options in an object value
We'll add stalling considerations next, this helps keeping things organized.
2025-06-05 10:28:33 +02:00
Jorge Manrubia c52e49ef91 Merge branch 'main' into stalled-cards
* main: (33 commits)
  Rename helpers since they are not related to collections only anymore
  Simplify
  Reorder method
  Update brakeman
  Fix tests after removing the index action
  Format
  Extract partials
  Format
  Tidy up code
  We're not using this right now
  Wire up knob UI design
  Contain images
  Extract the header so we can explain in context
  Display users and invite on `account/settings`
  Link to workflows
  Link to account settings
  Update to use two-column layout, add title and nav
  Add comment
  Properly parameterize the field name
  Remove leftover console.log
  ...
2025-06-05 10:09:12 +02:00
Jorge Manrubia 1fe16e1416 Merge pull request #585 from basecamp/entropy-settings-ui
Entropy improvements
2025-06-05 09:19:56 +02:00
Jorge Manrubia a5f7f34750 Rename helpers since they are not related to collections only anymore 2025-06-05 09:19:08 +02:00
Jorge Manrubia a014af6ef0 Simplify 2025-06-05 09:16:38 +02:00
Jorge Manrubia 8a63bac3c0 Reorder method 2025-06-05 09:14:51 +02:00
Jorge Manrubia e8322afb59 Update brakeman 2025-06-05 09:13:19 +02:00
Jorge Manrubia 540254def4 Fix tests after removing the index action
The show action makes more sense in the controller. Also, the filter
scoped was failing due to Rails raising on missing actions (because we
have deleted the index action). Inlining the concern fixes it and clarifies
where this action is implemented.
2025-06-05 09:12:07 +02:00
Jorge Manrubia de87f4ed6c Format 2025-06-05 08:58:15 +02:00
Jorge Manrubia acd1038359 Extract partials 2025-06-05 08:57:38 +02:00
Jorge Manrubia cb1ee9eabd Format 2025-06-05 08:54:42 +02:00
Jorge Manrubia b9dd7fe808 Tidy up code 2025-06-05 08:54:31 +02:00
Jason Zimdars 6eece93f10 Merge branch 'knobs' into entropy-settings-ui
* knobs:
  Add comment
  Properly parameterize the field name
  Remove leftover console.log
  Correct the reserved area math
  Better a11y
  Connect the range slider
  Basic radio input working
  Expose button so you can delete drafts
  Save button should match card color
  `x` interferes with string entry, try `SHIFT+ENTER` to toggle checkboxes
  Remove unnecessary param and update condition
2025-06-04 20:34:04 -05:00
Jason Zimdars 25d8defa85 We're not using this right now 2025-06-04 20:28:33 -05:00
Jason Zimdars e42c6548b0 Wire up knob UI design 2025-06-04 20:28:20 -05:00
Andy Smith e4b14a91dd Merge pull request #588 from basecamp/contain-images
Contain images
2025-06-04 16:02:12 -05:00
Andy Smith 22a85e6fc5 Contain images 2025-06-04 16:00:46 -05:00
Jason Zimdars 10224c2698 Extract the header so we can explain in context 2025-06-04 15:30:19 -05:00
Jason Zimdars 638bc16b4b Display users and invite on account/settings 2025-06-04 15:16:24 -05:00
Jason Zimdars cc03a3dcb4 Link to workflows 2025-06-04 14:58:09 -05:00
Jason Zimdars 24f4589c02 Link to account settings 2025-06-04 14:57:09 -05:00
Jason Zimdars 9872f35c2a Update to use two-column layout, add title and nav 2025-06-04 14:56:30 -05:00
Andy Smith 989825dcda Add comment 2025-06-04 13:50:27 -05:00
Andy Smith b4e283ab6a Properly parameterize the field name 2025-06-04 13:49:18 -05:00
Andy Smith 5baebefb6b Remove leftover console.log 2025-06-04 13:48:07 -05:00
Andy Smith 8e24b3edff Merge pull request #572 from basecamp/prevent-layout-shift
Add height/width values for images and videos
2025-06-04 13:39:23 -05:00
Andy Smith e513474e36 Correct the reserved area math 2025-06-04 13:38:50 -05:00
Andy Smith 04551d859e Better a11y 2025-06-04 13:06:43 -05:00
Andy Smith 80b1ac8cc9 Connect the range slider 2025-06-04 12:49:32 -05:00
Andy Smith 68ac1f80ec Basic radio input working 2025-06-04 12:10:28 -05:00
Jorge Manrubia 20c1119674 Wip for showing stalled 2025-06-04 17:18:10 +02:00
Jorge Manrubia cd9d9f78c7 We'll add tests here 2025-06-04 17:18:01 +02:00
Jorge Manrubia 9cdc34f0ae Basic tests for detecting stalled cards 2025-06-04 17:18:01 +02:00