Commit Graph

271 Commits

Author SHA1 Message Date
Jorge Manrubia 4ff55df2e0 Create system comments on events 2025-04-29 20:33:07 +02:00
Jason Zimdars 92f0d078b8 Update filter, we're not setting indexed_by 2025-04-27 15:55:40 +02:00
Jason Zimdars 137a16a810 Move to concern 2025-04-26 19:26:34 -05:00
Jason Zimdars ff5ecf305e Merge branch 'main' into jz-4-25
* main:
  Reorder methods
  Fix: dismiss notifications from comments
  Configure the autoclose period at the collection level
2025-04-25 13:50:53 -05:00
Jason Zimdars e82241669f Fix card icons 2025-04-25 12:45:15 -05:00
Jorge Manrubia e90b062440 Configure the autoclose period at the collection level 2025-04-25 13:29:16 +02:00
Jorge Manrubia 54d7327ccd Merge branch 'main' into events-revamp
* main:
  Account for stages where the color isn't set
  Choose workflows from a small preview
  Add missing filter display classes, style input
  Scroll users list, adjust layout
  Workflows and card perma polish
  Type polish and sizing constraints
  dep: AR::Tenanted: no implicit db migrations
  New layout for collections settings, stub entropy setting
  Adjust collection line to contrast with comment excerpts
  Adjust perma layout for larger cards
  Give the timeline a little space on each side
2025-04-25 09:41:29 +02:00
Jason Zimdars 783e7d12a1 Scroll users list, adjust layout 2025-04-24 16:59:48 -05:00
Jorge Manrubia 25dbd77acd Tidy up things a bit removing dups and splitting methods 2025-04-24 18:01:49 +02:00
Jorge Manrubia 27f6006b58 Does not belong here anymore 2025-04-24 13:48:53 +02:00
Jorge Manrubia 905ccb9b4b Make comments the event's host 2025-04-24 13:45:48 +02:00
Jorge Manrubia 18cc24e1d3 Add an event prefix named after the model now that events are generic 2025-04-24 13:20:09 +02:00
Jorge Manrubia 13b0c0fc41 First pass to tidy up activity time rendering 2025-04-24 12:28:16 +02:00
Jorge Manrubia 54f4bd5144 Generalize event's cards as eventable,add collection
Lots to tidy up but this is working
2025-04-24 12:28:16 +02:00
Jason Zimdars 8c51ca391b Move card delete button to a far less prominent position 2025-04-23 16:39:47 -05:00
Jorge Manrubia 646e4a59bc Fix missing variable name 2025-04-23 18:45:55 +02:00
Jorge Manrubia b08326ccbe Merge branch 'main' into plain-text-mentions
* main: (48 commits)
  Improve layout and truncation
  This is annoying
  Fix summary
  Remove index columns
  Same treatment for the events index
  New menu filters and navigates
  Don't test for _Added by_ events
  Indention
  @collection is always available when card scoped
  Style
  Remove check for _Added by..._ line
  The placeholder attribute is on the `house-md` element
  Duh, no before destroy commit, but this is still not right!
  No long transactions!
  Don't display published event in threads
  But feels more essentially part of the User, so list first
  Not related to the other two
  Missing controller
  Style
  Errant `bubbles` => `cards` replacement
  ...

# Conflicts:
#	app/models/card.rb
#	app/models/user.rb
#	db/schema.rb
#	db/schema_cache.yml
2025-04-23 17:24:01 +02:00
Jorge Manrubia 07d3447e7e Resolve notifications URLs 2025-04-23 14:34:59 +02:00
Jorge Manrubia 2eae58725a Remove notifications' resource relationship
Is confusing since "source" already captures the origin of the notifications. It's
needed to interpret things at rendering time, so we can query things as needed there.
2025-04-23 13:52:47 +02:00
Jorge Manrubia 7c0aff0680 Don't indent case 2025-04-23 13:36:39 +02:00
Jorge Manrubia 043230394e Tidy up event helper code
Also, revert to using a helper method to determine the event action, since this is purely a view concern. Keep method at the event model to identify initial assignments.
2025-04-23 13:35:09 +02:00
Jorge Manrubia 68e2e96076 Fix indentation 2025-04-23 10:44:42 +02:00
Jason Zimdars 9b57480b40 ticket is a vestige of a previous design 2025-04-22 13:55:46 -05:00
Jorge Manrubia 9b4fec936e Move mentions to comments
- It does not make sense to scan "event summaries" for notifications.
- Placing them at the message level prevents us from using the generic approach to extract the mentionable content
2025-04-22 16:17:37 +02:00
David Heinemeier Hansson 3d28203224 Use singular staging resource and beef up testing 2025-04-22 14:44:55 +02:00
Jorge Manrubia 3bf73a0b71 Rename to match actual action 2025-04-22 14:22:23 +02:00
Jorge Manrubia 4f06473405 Notifications for mentions showing up 2025-04-22 12:02:48 +02:00
David Heinemeier Hansson 22abf0ba46 Remove anemic concern
Colors are a card concern.
2025-04-22 11:56:41 +02:00
Jorge Manrubia aa3acfeaa8 Add plain text mentions 2025-04-22 11:26:56 +02:00
Jorge Manrubia b0aae3ad9e Reapply "Add a description field for cards"
This reverts commit a4cc143b09.
2025-04-21 16:45:24 +02:00
Jorge Manrubia a4cc143b09 Revert "Add a description field for cards" 2025-04-21 16:41:33 +02:00
David Heinemeier Hansson 9e921b85c0 Merge branch 'main' into add-card-description 2025-04-19 20:00:43 +02:00
David Heinemeier Hansson 247524da29 Stlye 2025-04-18 16:47:53 +02:00
David Heinemeier Hansson c6f363c281 Style 2025-04-18 16:42:35 +02:00
Jason Zimdars 026020c06e Restore drafted card state 2025-04-17 18:07:39 -05:00
David Heinemeier Hansson 461c104ac2 Extract helper method to keep partial at a uniform level of abstraction 2025-04-17 15:42:07 +02:00
David Heinemeier Hansson 73f272f132 Use one controller for all notification readings 2025-04-15 19:14:50 +02:00
Kevin McConnell 028a43e652 Title is on the related card 2025-04-14 15:50:24 +01:00
Andy Smith a88264ed0a Merge branch 'main' into consolidate-cards
* main: (94 commits)
  Source order seems to be significant
  Use `card.title`
  Nicer flow
  Fix string interpolation
  Fix constant
  Use record lookup
  Always use sole
  Explained less and extracted nothing of value
  Weird double negative
  Remove anemic and indirect method that explained nothing
  Can use record lookup for workflows
  Access control has already been done through the card
  Style
  Use _path in all cases where we are not potentially changing the domain
  Clearer
  Spacing
  Get rid of card_title
  Join the two users controllers but split out role setting
  Ensure user is returned
  We are not using the parameter
  ...
2025-04-14 09:40:22 -05:00
Jason Zimdars 3cfdaf1129 Use card.title 2025-04-14 08:54:54 -05:00
David Heinemeier Hansson 80c518b7e1 Fix string interpolation 2025-04-13 20:36:16 +02:00
David Heinemeier Hansson cf93da6886 Get rid of card_title
We can just set untitled on assignment of empty
2025-04-12 21:29:56 +02:00
David Heinemeier Hansson 760cbb6c99 Drop boosts
Killed by design.
2025-04-12 18:52:54 +02:00
David Heinemeier Hansson 120e8da1d5 Unused 2025-04-12 14:14:34 +02:00
David Heinemeier Hansson 4723b7b504 Style 2025-04-12 14:13:20 +02:00
David Heinemeier Hansson 6f3ac772ea Merge branch 'main' into comments-refactoring
* main:
  Show more of the summary before truncating
  Improve event summaries
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Show more of the summary before truncating
  Improve event summaries
  Remove shadows from notifications you can't see
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Style drafted cards
  Considering needs to include drafted cards or you'll never be able to see them
  This item makes no sense until it's saved
  Tighten engagement switch design, only display it for published cards
2025-04-12 09:56:28 +02:00
Andy Smith 75a46356cc Merge branch 'main' into consolidate-cards
* main:
  Show more of the summary before truncating
  Improve event summaries
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Show more of the summary before truncating
  Improve event summaries
  Remove shadows from notifications you can't see
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
2025-04-11 15:38:57 -05:00
Jason Zimdars 188ebc3110 Improve event summaries 2025-04-11 13:21:47 -05:00
Andy Smith c853d3c570 Merge branch 'main' into consolidate-cards
* main: (31 commits)
  Style drafted cards
  Considering needs to include drafted cards or you'll never be able to see them
  This item makes no sense until it's saved
  Tighten engagement switch design, only display it for published cards
  Needed to come first
  In order of appearance
  Schema movement -- is this because the dumper doesnt sort deterministically? cc @flavorjones
  Move comments under cards
  Fix indention
  Refresh timers when morphing happens
  Extract helper for card articles, use classes to determine when to show golden status
  Only consider golden those cards in "doing"
  Fix recently completed order for good!
  Place recently closed cards first
  Monkey patch a prepend_order method
  Rename inconsistency: go with goldness
  Touch
  Use gild/ungild
  Format
  Fix test
  ...
2025-04-11 12:43:05 -05:00
David Heinemeier Hansson 6effc1568f No need for a separate body partial 2025-04-11 18:41:26 +02:00