4ff55df2e0
Create system comments on events
2025-04-29 20:33:07 +02:00
2b98db9e66
Flatten out comments and messages
...
https://37s.fizzy.37signals.com/collections/693169850/cards/999008989#comment_994777841
2025-04-29 19:21:18 +02:00
137a16a810
Move to concern
2025-04-26 19:26:34 -05:00
82885e453d
Not needed anymore
2025-04-26 09:13:24 +02:00
685c1f4aca
Reorder methods
2025-04-25 20:04:04 +02:00
0056cafa04
Merge pull request #436 from basecamp/configure-auto-close
...
Configure the autoclose period for collections
2025-04-25 19:55:19 +02:00
5e279ab2e1
Fix: dismiss notifications from comments
2025-04-25 19:52:09 +02:00
e90b062440
Configure the autoclose period at the collection level
2025-04-25 13:29:16 +02:00
5a431ba6bb
Collections can be private now too
2025-04-25 10:31:41 +02:00
b866267192
Not used outside the class anymore
2025-04-25 10:28:39 +02:00
54d7327ccd
Merge branch 'main' into events-revamp
...
* main:
Account for stages where the color isn't set
Choose workflows from a small preview
Add missing filter display classes, style input
Scroll users list, adjust layout
Workflows and card perma polish
Type polish and sizing constraints
dep: AR::Tenanted: no implicit db migrations
New layout for collections settings, stub entropy setting
Adjust collection line to contrast with comment excerpts
Adjust perma layout for larger cards
Give the timeline a little space on each side
2025-04-25 09:41:29 +02:00
dca5e3b942
New layout for collections settings, stub entropy setting
2025-04-24 12:56:14 -05:00
331fdc05f6
Format
2025-04-24 15:20:08 +02:00
40368032f2
Split notifiers for comments and cards
...
This lets us remove the annoying if to check the card
2025-04-24 15:19:42 +02:00
ccb72ad229
Rename for consistency with what we had for comments
2025-04-24 14:51:25 +02:00
4183a5a32c
Remove unneeded transaction
2025-04-24 14:49:48 +02:00
27f6006b58
Does not belong here anymore
2025-04-24 13:48:53 +02:00
905ccb9b4b
Make comments the event's host
2025-04-24 13:45:48 +02:00
18cc24e1d3
Add an event prefix named after the model now that events are generic
2025-04-24 13:20:09 +02:00
b746987712
Make eventable a generic concern and create a card's especialization for it
2025-04-24 13:07:12 +02:00
aee7f4f886
Not used
2025-04-24 12:34:33 +02:00
13b0c0fc41
First pass to tidy up activity time rendering
2025-04-24 12:28:16 +02:00
965100df51
Access events through collections
2025-04-24 12:28:16 +02:00
54f4bd5144
Generalize event's cards as eventable,add collection
...
Lots to tidy up but this is working
2025-04-24 12:28:16 +02:00
e8e3bd16a6
First step to make events more generic in nature
2025-04-24 12:28:16 +02:00
f166b30f2f
Fix: dismiss mention notifications in cards and comments when reading a card
2025-04-24 12:19:20 +02:00
3793718e72
Fix concern I lost during merge
2025-04-23 17:25:36 +02:00
b08326ccbe
Merge branch 'main' into plain-text-mentions
...
* main: (48 commits)
Improve layout and truncation
This is annoying
Fix summary
Remove index columns
Same treatment for the events index
New menu filters and navigates
Don't test for _Added by_ events
Indention
@collection is always available when card scoped
Style
Remove check for _Added by..._ line
The placeholder attribute is on the `house-md` element
Duh, no before destroy commit, but this is still not right!
No long transactions!
Don't display published event in threads
But feels more essentially part of the User, so list first
Not related to the other two
Missing controller
Style
Errant `bubbles` => `cards` replacement
...
# Conflicts:
# app/models/card.rb
# app/models/user.rb
# db/schema.rb
# db/schema_cache.yml
2025-04-23 17:24:01 +02:00
5749ad77e5
Rename classes
2025-04-23 16:19:50 +02:00
f258b05b23
Delegate target to the notifiable objects
2025-04-23 16:19:50 +02:00
5dac14ab50
Move logic to the model
2025-04-23 16:06:20 +02:00
970a51db28
No need for it!
2025-04-23 15:49:22 +02:00
b4cfd40a2f
Inline, no need to duplicate the conditional
2025-04-23 15:37:28 +02:00
6f98f2f573
Order methods
2025-04-23 15:32:22 +02:00
e964c5f9c9
Not used!
2025-04-23 15:31:26 +02:00
53eba9bd0b
Favor after_create_commit to keep transactions fast
2025-04-23 15:28:28 +02:00
ea66845e71
There is always an action
2025-04-23 15:27:58 +02:00
e8e95bd511
Use it
2025-04-23 15:27:25 +02:00
4bef466df2
1-line
2025-04-23 15:22:41 +02:00
ad58de9e76
Remove access checks when watching
...
https://github.com/basecamp/fizzy/pull/425#discussion_r2056039581
2025-04-23 15:22:18 +02:00
a9df2d48d1
Remove delegate
2025-04-23 15:17:51 +02:00
6ff9f7a154
Fix identation
2025-04-23 15:07:02 +02:00
469fb9f049
Simplify the logic to determine action text changes
2025-04-23 15:02:31 +02:00
e446080367
Don't create duplicated mentions
...
E.g: when editing a comment or description with a mention
2025-04-23 14:45:56 +02:00
f43629f849
Format
2025-04-23 14:39:10 +02:00
2eae58725a
Remove notifications' resource relationship
...
Is confusing since "source" already captures the origin of the notifications. It's
needed to interpret things at rendering time, so we can query things as needed there.
2025-04-23 13:52:47 +02:00
696732a90a
Rename mentions' container => source
2025-04-23 13:41:34 +02:00
043230394e
Tidy up event helper code
...
Also, revert to using a helper method to determine the event action, since this is purely a view concern. Keep method at the event model to identify initial assignments.
2025-04-23 13:35:09 +02:00
2e3ffcfb9d
Remove identation
2025-04-23 13:35:08 +02:00
755c9b45c7
Rename and fix problem where after_touch was overriding the saved content
2025-04-23 12:38:33 +02:00
Jorge Manrubia