Commit Graph

64 Commits

Author SHA1 Message Date
Jorge Manrubia 4ff55df2e0 Create system comments on events 2025-04-29 20:33:07 +02:00
Jorge Manrubia 2b98db9e66 Flatten out comments and messages
https://37s.fizzy.37signals.com/collections/693169850/cards/999008989#comment_994777841
2025-04-29 19:21:18 +02:00
Jorge Manrubia 685c1f4aca Reorder methods 2025-04-25 20:04:04 +02:00
Jorge Manrubia 0056cafa04 Merge pull request #436 from basecamp/configure-auto-close
Configure the autoclose period for collections
2025-04-25 19:55:19 +02:00
Jorge Manrubia 5e279ab2e1 Fix: dismiss notifications from comments 2025-04-25 19:52:09 +02:00
Jorge Manrubia e90b062440 Configure the autoclose period at the collection level 2025-04-25 13:29:16 +02:00
Jorge Manrubia 54d7327ccd Merge branch 'main' into events-revamp
* main:
  Account for stages where the color isn't set
  Choose workflows from a small preview
  Add missing filter display classes, style input
  Scroll users list, adjust layout
  Workflows and card perma polish
  Type polish and sizing constraints
  dep: AR::Tenanted: no implicit db migrations
  New layout for collections settings, stub entropy setting
  Adjust collection line to contrast with comment excerpts
  Adjust perma layout for larger cards
  Give the timeline a little space on each side
2025-04-25 09:41:29 +02:00
Jason Zimdars dca5e3b942 New layout for collections settings, stub entropy setting 2025-04-24 12:56:14 -05:00
Jorge Manrubia 4183a5a32c Remove unneeded transaction 2025-04-24 14:49:48 +02:00
Jorge Manrubia 18cc24e1d3 Add an event prefix named after the model now that events are generic 2025-04-24 13:20:09 +02:00
Jorge Manrubia b746987712 Make eventable a generic concern and create a card's especialization for it 2025-04-24 13:07:12 +02:00
Jorge Manrubia 54f4bd5144 Generalize event's cards as eventable,add collection
Lots to tidy up but this is working
2025-04-24 12:28:16 +02:00
Jorge Manrubia f166b30f2f Fix: dismiss mention notifications in cards and comments when reading a card 2025-04-24 12:19:20 +02:00
Jorge Manrubia b08326ccbe Merge branch 'main' into plain-text-mentions
* main: (48 commits)
  Improve layout and truncation
  This is annoying
  Fix summary
  Remove index columns
  Same treatment for the events index
  New menu filters and navigates
  Don't test for _Added by_ events
  Indention
  @collection is always available when card scoped
  Style
  Remove check for _Added by..._ line
  The placeholder attribute is on the `house-md` element
  Duh, no before destroy commit, but this is still not right!
  No long transactions!
  Don't display published event in threads
  But feels more essentially part of the User, so list first
  Not related to the other two
  Missing controller
  Style
  Errant `bubbles` => `cards` replacement
  ...

# Conflicts:
#	app/models/card.rb
#	app/models/user.rb
#	db/schema.rb
#	db/schema_cache.yml
2025-04-23 17:24:01 +02:00
Jorge Manrubia ad58de9e76 Remove access checks when watching
https://github.com/basecamp/fizzy/pull/425#discussion_r2056039581
2025-04-23 15:22:18 +02:00
Jorge Manrubia a9df2d48d1 Remove delegate 2025-04-23 15:17:51 +02:00
Jorge Manrubia f43629f849 Format 2025-04-23 14:39:10 +02:00
Jorge Manrubia edcc9e3279 Add mentionees as watchers 2025-04-23 12:38:06 +02:00
David Heinemeier Hansson 3d28203224 Use singular staging resource and beef up testing 2025-04-22 14:44:55 +02:00
Jorge Manrubia d5f0359338 Extract mentionable content using reflection to remove duplicated logic and the need for additional concerns 2025-04-22 14:19:45 +02:00
Jorge Manrubia 22df208f9a Render proper content for mentions, don't send mentions to yourself 2025-04-22 14:11:21 +02:00
David Heinemeier Hansson 827c00ce49 Extract Workflowing concern 2025-04-22 12:32:34 +02:00
David Heinemeier Hansson 20a2965181 Keep scopes together 2025-04-22 12:12:30 +02:00
David Heinemeier Hansson 7a46fd0948 Stick with open/close as a consistent pair instead of active/close 2025-04-22 12:08:56 +02:00
David Heinemeier Hansson 22abf0ba46 Remove anemic concern
Colors are a card concern.
2025-04-22 11:56:41 +02:00
Jorge Manrubia aa3acfeaa8 Add plain text mentions 2025-04-22 11:26:56 +02:00
Jorge Manrubia b0aae3ad9e Reapply "Add a description field for cards"
This reverts commit a4cc143b09.
2025-04-21 16:45:24 +02:00
Jorge Manrubia a4cc143b09 Revert "Add a description field for cards" 2025-04-21 16:41:33 +02:00
Jorge Manrubia 99dbc04e2c Format 2025-04-21 15:20:03 +02:00
Jorge Manrubia ffdec1cc3b Index description too 2025-04-21 15:18:11 +02:00
David Heinemeier Hansson 9e921b85c0 Merge branch 'main' into add-card-description 2025-04-19 20:00:43 +02:00
David Heinemeier Hansson 78369725c4 Move card concern logic into those concerns 2025-04-18 17:18:28 +02:00
David Heinemeier Hansson f368b9f9c9 Inline anemic method 2025-04-18 17:13:11 +02:00
David Heinemeier Hansson 7c76bdd96d Drop Scorable concern 2025-04-18 17:07:36 +02:00
Jason Zimdars 47d0ae98a1 Remove DraftCommenting 2025-04-16 19:01:21 -05:00
David Heinemeier Hansson b9f5293231 Style 2025-04-15 16:15:13 +02:00
David Heinemeier Hansson f30a9308d2 Line up scopes in order of the flow 2025-04-15 16:13:54 +02:00
David Heinemeier Hansson a6a96fd5c8 Dont repeat the same checks from doing, make it clearer where the difference is 2025-04-15 15:55:29 +02:00
David Heinemeier Hansson 6bbf68a4f9 The tenanted db is the account scope 2025-04-12 20:06:34 +02:00
David Heinemeier Hansson 760cbb6c99 Drop boosts
Killed by design.
2025-04-12 18:52:54 +02:00
David Heinemeier Hansson 1a70be06c6 Fix trailing CR 2025-04-12 13:37:31 +02:00
David Heinemeier Hansson ecffdc2af4 Spacing 2025-04-12 11:07:27 +02:00
David Heinemeier Hansson 735a12abfc Better name 2025-04-12 11:07:02 +02:00
David Heinemeier Hansson 9f7bbbef58 Split draft commenting back out to a dedicated concern 2025-04-12 11:05:56 +02:00
David Heinemeier Hansson 27d90abbd6 Reduce the direct knowledge of comments inside the card 2025-04-12 11:04:16 +02:00
David Heinemeier Hansson 81f431d946 Comment-specific behavior needs to live in the comment
This really is a bit of a tangled mess. Everyone knows everything about
everyone else.
2025-04-12 10:39:56 +02:00
David Heinemeier Hansson bb64adfd1b Most important methods first 2025-04-12 10:39:19 +02:00
David Heinemeier Hansson 4d2ba5b432 Use the explicit method for now 2025-04-12 10:27:57 +02:00
David Heinemeier Hansson 6f3ac772ea Merge branch 'main' into comments-refactoring
* main:
  Show more of the summary before truncating
  Improve event summaries
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Show more of the summary before truncating
  Improve event summaries
  Remove shadows from notifications you can't see
  Add this for debugging empty event cards
  Some actions shouldn't be available to closed cards
  Nicer spacing when the large button isn't present
  Update `card-color` in a couple more places
  Don't show the engagement toggle on closed cards
  Style drafted cards
  Considering needs to include drafted cards or you'll never be able to see them
  This item makes no sense until it's saved
  Tighten engagement switch design, only display it for published cards
2025-04-12 09:56:28 +02:00
Jason Zimdars 5997ef2c70 Considering needs to include drafted cards or you'll never be able to see them 2025-04-11 12:08:05 -05:00