Commit Graph

356 Commits

Author SHA1 Message Date
Jorge Manrubia 4ff55df2e0 Create system comments on events 2025-04-29 20:33:07 +02:00
Jorge Manrubia e03f1f7f9b Rename test that was being skipped 2025-04-29 19:23:56 +02:00
Jorge Manrubia 2b98db9e66 Flatten out comments and messages
https://37s.fizzy.37signals.com/collections/693169850/cards/999008989#comment_994777841
2025-04-29 19:21:18 +02:00
Jorge Manrubia f12970c697 We're using seconds now 2025-04-25 22:55:42 +02:00
Jorge Manrubia 0056cafa04 Merge pull request #436 from basecamp/configure-auto-close
Configure the autoclose period for collections
2025-04-25 19:55:19 +02:00
Jorge Manrubia 5e279ab2e1 Fix: dismiss notifications from comments 2025-04-25 19:52:09 +02:00
Jorge Manrubia e90b062440 Configure the autoclose period at the collection level 2025-04-25 13:29:16 +02:00
Jorge Manrubia 501a3b2b44 Add test to make sure you can't access innaccessible collections via filtering either 2025-04-25 07:23:11 +02:00
Jorge Manrubia 40368032f2 Split notifiers for comments and cards
This lets us remove the annoying if to check the card
2025-04-24 15:19:42 +02:00
Jorge Manrubia 905ccb9b4b Make comments the event's host 2025-04-24 13:45:48 +02:00
Jorge Manrubia 18cc24e1d3 Add an event prefix named after the model now that events are generic 2025-04-24 13:20:09 +02:00
Jorge Manrubia e8cffd0717 Add missing test 2025-04-24 12:37:25 +02:00
Jorge Manrubia 54f4bd5144 Generalize event's cards as eventable,add collection
Lots to tidy up but this is working
2025-04-24 12:28:16 +02:00
Jorge Manrubia 38e16ab9ee Remove dummy test I had created for debugging purposes 2025-04-24 12:20:25 +02:00
Jorge Manrubia f166b30f2f Fix: dismiss mention notifications in cards and comments when reading a card 2025-04-24 12:19:20 +02:00
Jorge Manrubia d2237c2a68 Remove trace 2025-04-23 23:19:38 +02:00
Jorge Manrubia b08326ccbe Merge branch 'main' into plain-text-mentions
* main: (48 commits)
  Improve layout and truncation
  This is annoying
  Fix summary
  Remove index columns
  Same treatment for the events index
  New menu filters and navigates
  Don't test for _Added by_ events
  Indention
  @collection is always available when card scoped
  Style
  Remove check for _Added by..._ line
  The placeholder attribute is on the `house-md` element
  Duh, no before destroy commit, but this is still not right!
  No long transactions!
  Don't display published event in threads
  But feels more essentially part of the User, so list first
  Not related to the other two
  Missing controller
  Style
  Errant `bubbles` => `cards` replacement
  ...

# Conflicts:
#	app/models/card.rb
#	app/models/user.rb
#	db/schema.rb
#	db/schema_cache.yml
2025-04-23 17:24:01 +02:00
Jorge Manrubia 2545604659 Add tests 2025-04-23 17:20:04 +02:00
Jorge Manrubia f258b05b23 Delegate target to the notifiable objects 2025-04-23 16:19:50 +02:00
Jorge Manrubia 2eae58725a Remove notifications' resource relationship
Is confusing since "source" already captures the origin of the notifications. It's
needed to interpret things at rendering time, so we can query things as needed there.
2025-04-23 13:52:47 +02:00
Jorge Manrubia ab54cafd84 Inline event notifiers 2025-04-23 11:06:43 +02:00
Jorge Manrubia c3cd873588 Rename collect => create 2025-04-23 10:30:30 +02:00
Jason Zimdars 537903ba0b Don't test for _Added by_ events
Note: The join method in `event_summary.rb` inserts a space that we need to account for
2025-04-22 15:06:05 -05:00
Jason Zimdars 647971f205 Remove check for _Added by..._ line 2025-04-22 14:46:46 -05:00
David Heinemeier Hansson 3d28203224 Use singular staging resource and beef up testing 2025-04-22 14:44:55 +02:00
Jorge Manrubia 22df208f9a Render proper content for mentions, don't send mentions to yourself 2025-04-22 14:11:21 +02:00
Jorge Manrubia 8aa99e34b4 Persist notification's creator
Instead of delegating. With a polymorphic relationship, relying on a certain
attribute implies doing things like aliasing "mentioner" to "creator" or similar.
2025-04-22 13:48:43 +02:00
David Heinemeier Hansson 5ea0ec8cb4 Test and fix setting workflow to nothing 2025-04-22 13:05:39 +02:00
David Heinemeier Hansson 8e35a3de9c Test workflowing updates card stages on change 2025-04-22 13:03:31 +02:00
David Heinemeier Hansson 7a46fd0948 Stick with open/close as a consistent pair instead of active/close 2025-04-22 12:08:56 +02:00
Jorge Manrubia 4f06473405 Notifications for mentions showing up 2025-04-22 12:02:48 +02:00
David Heinemeier Hansson 22abf0ba46 Remove anemic concern
Colors are a card concern.
2025-04-22 11:56:41 +02:00
Jorge Manrubia aa3acfeaa8 Add plain text mentions 2025-04-22 11:26:56 +02:00
Jorge Manrubia b0aae3ad9e Reapply "Add a description field for cards"
This reverts commit a4cc143b09.
2025-04-21 16:45:24 +02:00
Jorge Manrubia a4cc143b09 Revert "Add a description field for cards" 2025-04-21 16:41:33 +02:00
Jorge Manrubia fb83b5e70e Merge branch 'main' into add-card-description
* main:
  Fix trailing empty line
  --skip-server in ci setup
  Enumerate all the options for logging in
  Have an empty first-run tenant too
  Convert to conventional Rails style
  Seed multiple seed accounts with basic DSL
  Stlye
  No need to run Solid Cache in development
  Use morphing to replace the card and exclude turbo frames from being replaced
  Name is already schema and UI required
  Cards have a not-null schema and collections destroy all cards on deletion
  No longer used
  Inline touch check thats only used once

# Conflicts:
#	app/views/cards/_container.html.erb
2025-04-21 16:04:06 +02:00
David Heinemeier Hansson dc2205ee79 Cards have a not-null schema and collections destroy all cards on deletion
This shouldnt be necessary. Maybe remnant of some previous design?
2025-04-21 09:18:42 +02:00
David Heinemeier Hansson 9e921b85c0 Merge branch 'main' into add-card-description 2025-04-19 20:00:43 +02:00
David Heinemeier Hansson 883a225946 Use upstreamed assert_in_body 2025-04-19 10:08:08 +02:00
David Heinemeier Hansson cacee0febb Remove anemic scope 2025-04-18 17:18:13 +02:00
David Heinemeier Hansson 7c76bdd96d Drop Scorable concern 2025-04-18 17:07:36 +02:00
David Heinemeier Hansson 1114679c20 Remove activity score columns 2025-04-18 17:05:17 +02:00
David Heinemeier Hansson 3003105ac9 Flesh out the rest of the controller tests 2025-04-18 16:16:04 +02:00
David Heinemeier Hansson f6cd21f7cb Extract default stages into something that will be created together with a new Workflow in the model 2025-04-18 16:07:01 +02:00
David Heinemeier Hansson fd21838f88 Add assert_in_body helper
Coming upstream
2025-04-18 16:06:30 +02:00
Jason Zimdars 44a5215da7 Merge branch 'main' into add-card-description
* main:
  Fix failing test (we're no longer redirecting here
  Display the empty message via CSS when there are no unread notifications
  Hide Previously Seen section when empty with CSS
2025-04-17 17:08:49 -05:00
Jason Zimdars c61fa77d6b Fix failing test (we're no longer redirecting here
See: #411
2025-04-17 17:03:18 -05:00
Jason Zimdars 04f9a0f83a Merge branch 'main' into add-card-description
* main: (33 commits)
  Run beamer accessories in production only
  Less noisy logging in production
  Inline perma to container partial
  Use card replacement for card updates too
  Extract helper method to keep partial at a uniform level of abstraction
  Remove duplicated conditional
  Style
  Note that we dont want to keep reloading these frames
  I like this even better
  Suffix qualifier is unnnecessary
  Group partials for container
  Match domain language
  Fix trailing space
  Use card rerendering instead of redirects
  Better name
  Stick with domain language
  Fix tests
  Rerender instead of redirect
  Style
  Extract partials that can be rerendered
  ...
2025-04-17 16:40:23 -05:00
David Heinemeier Hansson 7adbd8d634 Use card rerendering instead of redirects 2025-04-17 15:20:27 +02:00
David Heinemeier Hansson 06da295f44 Fix tests 2025-04-17 14:56:53 +02:00