56c4bfc04c
Merge branch 'main' into notification-index
...
* main:
Don't round up in time distance expression
Tidy Gemfile
Banner for draft state
Drafts should always use the dashed outline wherever they're displayed
Unnecessary parens
Use distance to nearest edge
Simplify overlap logic
Fix divider drag jankiness
2025-01-20 13:01:41 -06:00
536dfa65d7
Open tray on click, stub mark-as-read button
2025-01-20 13:00:56 -06:00
cd22046efe
Refactor
2025-01-19 22:27:02 -06:00
00e905dd28
New for you empty state
2025-01-17 15:37:43 -06:00
6b832876a2
Add a notifications button to the tray for reaching the index when you have no unreads
2025-01-17 15:30:33 -06:00
be14a910ba
Needed when truncating so the avatar isn't squished
2025-01-17 13:06:41 -06:00
cb6651e2a7
Style notifications index; add truncation for long notifications
2025-01-17 12:42:46 -06:00
181b7f3b64
Don't round up in time distance expression
...
e.g. 1.5 days ago is still "1 day ago", not "2 days ago".
2025-01-17 13:33:26 +00:00
29b221f65c
Banner for draft state
2025-01-16 19:21:27 -06:00
340ff19a8c
Drafts should always use the dashed outline wherever they're displayed
2025-01-16 19:14:58 -06:00
d65d8a899b
Merge pull request #209 from basecamp/drag-jankiness
...
Fix divider drag jankiness
2025-01-16 15:13:05 -06:00
fb27cee9b0
Unnecessary parens
2025-01-16 15:11:44 -06:00
8877d2e66d
Use distance to nearest edge
...
This feels the smoothest
2025-01-16 15:09:46 -06:00
dc6da76b38
Simplify overlap logic
2025-01-16 14:01:25 -06:00
af0783d8ff
Fix divider drag jankiness
2025-01-16 13:54:42 -06:00
6706802b89
Add an index view for all notifications
2025-01-16 17:48:38 +00:00
c4f50fa634
Move notifications to tray controller
2025-01-16 17:48:38 +00:00
6f8c929898
Use cache-friendly "time ago"
...
Also introduces a local time helper that we can use to format dates and
times.
2025-01-16 17:47:25 +00:00
622e340e83
positionedClass -> installedClass
2025-01-15 20:31:09 -06:00
775e29fb8e
Pull out moveDividerTo
2025-01-15 20:26:56 -06:00
40085b16d6
Before comes before After
2025-01-15 20:14:30 -06:00
3ab6ee84d0
DividerElement -> Divider
2025-01-15 20:13:18 -06:00
9b1c140eef
Clean up divider-controller
2025-01-15 20:10:54 -06:00
dac9aa9d26
Drag bubble divider
2025-01-15 17:22:25 -06:00
5ac9063a84
default_fields -> default_values
2025-01-15 16:57:02 -06:00
8d75429431
Remove old digest_params method
2025-01-15 16:45:15 -06:00
e9a085f848
Simplify filters
2025-01-15 16:27:33 -06:00
dbb3fd3b9c
Simplify
2025-01-15 12:03:56 +00:00
056d853cc8
Don't notify while bubbles are still drafted
2025-01-15 11:42:35 +00:00
782259a678
Events should track published now
...
Previously when an item was `created`, we'd track the event, update the
summary text, and broadcast the notifications. But now that we have a
draft state, we shold do all of this when it's published instead.
2025-01-15 10:58:00 +00:00
cd1e6378d0
Add drafted and published states
2025-01-15 10:58:00 +00:00
f209c23e45
Cache notification partial
2025-01-15 10:57:27 +00:00
e7819328e8
A little janky but we probably don't want to navigate when you're typing a comment
2025-01-14 17:00:32 -06:00
6a40256969
Prevent back navigation when cancelling comment edits
2025-01-14 16:57:29 -06:00
d20288f929
Don't trigger esc to go back when closing dialog
2025-01-14 16:53:38 -06:00
1f911b234b
Avoid navigating back when closing the filter dialog
2025-01-14 16:49:21 -06:00
a596d7cea7
Cancel and go back for forms with autofocused inputs
2025-01-14 16:45:29 -06:00
39ff31b14b
esc to cancel here, too
2025-01-14 16:04:41 -06:00
95f077672b
esc to navigate back to buckets index
2025-01-14 15:57:55 -06:00
f7f063ae0c
Can just use @bucket
2025-01-14 15:49:25 -06:00
32532c53cb
Add bucket link/title so you know where you are
2025-01-14 15:48:49 -06:00
b8ecfa0125
Replace notifications on read, instead of removing
...
Previously when a notification was read, we'd remove it from the list.
This will often be fine, but if there were more unread notifications
that hadn't been loaded yet (because there were too many for the initial
page) then the list could become empty when really there are still more
items to show.
So instead of removing the items when they're read, we can reload the
list with the new page of items. This should allow the older
notifications to come into view when necessary.
2025-01-14 14:23:46 +00:00
415e872a2b
Combine concerns
2025-01-14 13:57:48 +00:00
c11b5af5e0
Make Stimulus controller more generic
2025-01-14 13:37:54 +00:00
ab154f2f35
Generate notification content in a helper
2025-01-14 13:08:12 +00:00
30b58f716b
Make title a notifier attribute
2025-01-14 10:21:47 +00:00
5f88cd3900
Design for notifications
2025-01-13 20:46:51 -06:00
64795804ba
Style
2025-01-13 14:21:47 +00:00
196575c0a2
Use a job to generate notifications
2025-01-13 14:21:47 +00:00
46989f6ebe
Mark notification read when viewing the Bubble
2025-01-13 14:21:47 +00:00
Jason Zimdars