Commit Graph

564 Commits

Author SHA1 Message Date
Jason Zimdars f224656d1e Prefer helper 2025-10-16 13:29:41 -05:00
Andy Smith 72a1fa075b Merge pull request #1333 from basecamp/steps-cant-be-empty
Check for empty values before submitting
2025-10-16 11:24:03 -05:00
Andy Smith 673e74d0de Check for empty values before submitting 2025-10-16 11:07:44 -05:00
Jorge Manrubia f18cda45bd Fix: show updated values in the column form after saving
This removes the data turbo permanent attribute and instead, prevent the dialog closing
automatically (so that a page refresh does not make you lose context)

https://fizzy.37signals.com/5986089/cards/2300/
2025-10-16 16:31:32 +02:00
Jorge Manrubia 8c8dbe888e Fix assorted issues when reloading pages with morphing and the pagination system
This patches 2 problems in Turbo/idiomorph that are causing problems when reloading the pagination frames:

- No remove callback in idiomorph when removing a node that had been mapped.
- Regression introduced by https://github.com/hotwired/turbo/pull/1311, where it won't prevent the removal of frames with refresh=morph

I will upstream both patches, this is temporary.

https://fizzy.37signals.com/5986089/cards/2291
2025-10-16 13:39:16 +02:00
Andy Smith f7afd6c939 Make collection-specific keys for collapsed column state 2025-10-15 15:28:46 -05:00
Jason Zimdars 626aa0ea8a Don't animate expanding columns when restoring 2025-10-15 12:51:06 -05:00
Jason Zimdars 679b4d2c94 Focus filter input with a hotkey, adjust sizing 2025-10-13 18:04:01 -05:00
Jason Zimdars 4ab2d971f9 Merge branch 'main' into collections-filter
* main: (24 commits)
  Move load-balancer to fizzy-lb-101
  Add otel_collector accessory for load balancer
  Fix: this was getting idiomorph confused as it was being invoked on many subtree elements
  Keep column popups during page refreshes
  Don't render next link unless there is more activity
  Live updates for the collection perma
  Keep filter panel during page refreshes
  Add pagination to the list of filtered cards
  Use frame based pagination for the users timeline too
  Use frame-based pagination for the activity timeline
  Don't broadcast updates of cards unless published
  Live updates for the timeline
  Make permanent to avoid losing menu on page refreshes
  Use the new required attribute that now Lexxy supports
  Use controller to disable empty comment submit
  Dynamic height for pins based on viewport height
  Position lexxy language picker
  Replace old link with proper collection path
  No longer needed
  Prevent card bubbles getting clipped in grid layout
  ...
2025-10-02 14:26:45 -05:00
Jorge Manrubia 9293d557c8 Fix: this was getting idiomorph confused as it was being invoked on many subtree elements
See https://fizzy.37signals.com/5986089/cards/2057
2025-10-02 17:12:18 +02:00
Jorge Manrubia 6b10d23fa9 Fix: deselect collections in the collections filter 2025-10-02 14:24:57 +02:00
Jorge Manrubia 2f38cb3ecd Wire up collection filtering: it should be performed in the generic cards view 2025-10-02 10:30:32 +02:00
Jorge Manrubia 1c0a01c17a Wire up filtering logic for the timeline 2025-10-02 10:12:43 +02:00
Jorge Manrubia 0774101b0d Use the new required attribute that now Lexxy supports 2025-10-02 09:34:41 +02:00
Andy Smith 80e072f845 Use controller to disable empty comment submit 2025-10-01 16:56:55 -05:00
Andy Smith bd45eee52f Smooth out animations a bit 2025-09-30 11:07:10 -05:00
Jorge Manrubia 0347806ce1 Fix: Keep the previous filtering when navigating back from cards
https://fizzy.37signals.com/5986089/cards/1760/edit

This also adds a proper resource for filtered collections, instead of changing the URL to cards for filtering cards.
2025-09-30 15:48:56 +02:00
Jorge Manrubia 1b6b82a6cc Redirect to cards when searching by card id 2025-09-30 13:52:27 +02:00
Andy Smith 58c0314c17 Merge branch 'main' into tooltip-orient
* main: (161 commits)
  Save expanded state to localStorage
  Update seeds to use the workflow stages
  Disable autocomplete when editing columns
  Reset column form and disable autocomplete
  Remove unused job
  Fix Stream workflow stage BG
  We need the grid layout when filtering events
  Fix: proper filtering by collection in the collection perma
  Fix test
  Fix test
  Position expander menu
  Use parent layout when using with_manual_pagination
  Reinstate gap to cards list
  Fix: include collection filter in the collection perma
  Add some basic caching for the new columns approach
  Format
  Fix tests
  No need to use extra method here
  Move actions to stream templates
  Prevent recursive loop now that we have nested frames
  ...
2025-09-29 13:55:33 -05:00
Andy Smith 3bd5c660f2 Save expanded state to localStorage 2025-09-29 12:38:18 -05:00
Jorge Manrubia 12d55f20c7 Reset column form and disable autocomplete 2025-09-29 19:00:17 +02:00
Jorge Manrubia 859a016a2e No need to use extra method here 2025-09-29 13:03:54 +02:00
Jorge Manrubia d57824b951 Prevent recursive loop now that we have nested frames 2025-09-28 22:27:40 +02:00
Jorge Manrubia 72fb15dd0f Pagination working for columns
Bring pagination system from KIA that is compatible with page refreshes
2025-09-28 14:21:16 +02:00
Jorge Manrubia b5dd91f4a4 Tidy up 2025-09-28 13:32:23 +02:00
Jorge Manrubia 7209c4ced7 Remove unnecessary defensive check 2025-09-28 13:28:33 +02:00
Jorge Manrubia f0da1b483d Tidy up 2025-09-28 13:28:08 +02:00
Jorge Manrubia e670add34b Format 2025-09-28 13:26:28 +02:00
Jorge Manrubia be8fcae4c6 Use aria-controls and aria-expanded for columns 2025-09-28 13:17:10 +02:00
Jorge Manrubia 531315f253 Restore the class-based approach
aria-expanded should go on the toggle
2025-09-28 13:02:58 +02:00
Jorge Manrubia 5a90de8bcb Use aria-expanded instead of class 2025-09-28 11:31:03 +02:00
Jorge Manrubia 7a97d978f5 Rename columns 2025-09-28 11:06:40 +02:00
Andy Smith 78f72cfbd9 Reconnect drag audio after latest updates 2025-09-26 13:27:04 -05:00
Jorge Manrubia 7bfcab8459 Merge branch 'collapsing-columns' into collapsing-columns+domain
# Conflicts:
#	app/views/cards/index.html.erb
2025-09-26 19:43:56 +02:00
Andy Smith f6fe1f7ddc Add example audio files 2025-09-26 11:51:17 -05:00
Andy Smith 5d72ae8e29 Finish up preloading logic 2025-09-26 11:33:29 -05:00
Jorge Manrubia 0687c500f1 Advance when restoring URL so that the URL changes! 2025-09-26 18:20:39 +02:00
Andy Smith 88ef14ccd8 Preload various instruments 2025-09-26 11:19:39 -05:00
Jorge Manrubia 6ec394434c Make filters work with the new columns screen 2025-09-26 18:06:35 +02:00
Jorge Manrubia f5c7d3d35b Reload frames with morphing to pervent blink when re-rendering columns 2025-09-26 16:38:04 +02:00
Jorge Manrubia 5c52b6b056 More fidelity for D&D cards
- Reload source frame with morphing. E.g: to deal with pagination or with the D&D placeholder
- Decrease source counter with JS
2025-09-26 15:30:09 +02:00
Jorge Manrubia e7c92ce443 Keep columns open when D&D cards 2025-09-26 13:29:39 +02:00
Jorge Manrubia 5a7fa4e239 Drop cards in specific columns 2025-09-26 13:14:21 +02:00
Jorge Manrubia f6ad04a9e9 D&D to now now working 2025-09-26 12:33:22 +02:00
Andy Smith c6d987e95c Remove unused imports 2025-09-25 16:32:55 -05:00
Andy Smith e5654d067a Removed unused bits 2025-09-25 16:29:45 -05:00
Andy Smith f9427dac13 Extract from drag and drop 2025-09-25 16:29:13 -05:00
Andy Smith 8097e15c7e Working guitar sounds 2025-09-25 13:01:03 -05:00
Jorge Manrubia c96334ca3d Merge main into collapsing-columns branch
Resolves merge conflicts by:
- Integrating new Cards::Columns architecture from main
- Preserving collapsible columns functionality
- Maintaining stage-specific doing columns support
- Using new column-based rendering while keeping expanders

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-09-24 10:19:04 +02:00
Andy Smith 427ac5c84b Add tooltip controller 2025-09-22 15:52:30 -05:00