Jorge Manrubia
4f0cf0f5cb
Fix autosave working with the new description field
2025-04-21 17:05:35 +02:00
Jorge Manrubia
2c3ec3e806
Fix: Create new cards wasn't working
2025-04-21 17:00:25 +02:00
Jorge Manrubia
1680095266
Remove invalid "
2025-04-21 16:45:35 +02:00
Jorge Manrubia
b0aae3ad9e
Reapply "Add a description field for cards"
...
This reverts commit a4cc143b09 .
2025-04-21 16:45:24 +02:00
Jorge Manrubia
a4cc143b09
Revert "Add a description field for cards"
2025-04-21 16:41:33 +02:00
Jorge Manrubia
fb83b5e70e
Merge branch 'main' into add-card-description
...
* main:
Fix trailing empty line
--skip-server in ci setup
Enumerate all the options for logging in
Have an empty first-run tenant too
Convert to conventional Rails style
Seed multiple seed accounts with basic DSL
Stlye
No need to run Solid Cache in development
Use morphing to replace the card and exclude turbo frames from being replaced
Name is already schema and UI required
Cards have a not-null schema and collections destroy all cards on deletion
No longer used
Inline touch check thats only used once
# Conflicts:
# app/views/cards/_container.html.erb
2025-04-21 16:04:06 +02:00
David Heinemeier Hansson
55789b7a34
Merge pull request #416 from basecamp/replace-with-morph
...
Use morphing in the stream replace the card container
2025-04-21 15:40:28 +02:00
Jorge Manrubia
99dbc04e2c
Format
2025-04-21 15:20:03 +02:00
Jorge Manrubia
ffdec1cc3b
Index description too
2025-04-21 15:18:11 +02:00
Jorge Manrubia
7925cd7bf9
Extract partials
2025-04-21 14:52:21 +02:00
Jorge Manrubia
491e743c27
Place below associations
2025-04-21 14:48:07 +02:00
Jorge Manrubia
3e1a2bcc7e
Use morphing to replace the card and exclude turbo frames from being replaced
...
Reconnecting the frames result in a visible flickering.
This also prevents flickering in the avatars when replacing the card container.
2025-04-21 09:24:57 +02:00
David Heinemeier Hansson
89d1b316f0
Name is already schema and UI required
...
And we are not using these validations for display anywhere.
2025-04-21 09:21:55 +02:00
David Heinemeier Hansson
dc2205ee79
Cards have a not-null schema and collections destroy all cards on deletion
...
This shouldnt be necessary. Maybe remnant of some previous design?
2025-04-21 09:18:42 +02:00
David Heinemeier Hansson
48a6c05250
No longer used
2025-04-20 16:23:15 +02:00
David Heinemeier Hansson
d3fa62d4c2
Inline touch check thats only used once
...
Not worth loading an entire file for this.
2025-04-20 16:21:08 +02:00
David Heinemeier Hansson
ccd98f6d98
Update card.rb
2025-04-19 20:01:41 +02:00
David Heinemeier Hansson
9e921b85c0
Merge branch 'main' into add-card-description
2025-04-19 20:00:43 +02:00
David Heinemeier Hansson
78369725c4
Move card concern logic into those concerns
2025-04-18 17:18:28 +02:00
David Heinemeier Hansson
cacee0febb
Remove anemic scope
2025-04-18 17:18:13 +02:00
David Heinemeier Hansson
f368b9f9c9
Inline anemic method
2025-04-18 17:13:11 +02:00
David Heinemeier Hansson
aae6c7b1a2
Indention
2025-04-18 17:09:55 +02:00
David Heinemeier Hansson
7c76bdd96d
Drop Scorable concern
2025-04-18 17:07:36 +02:00
David Heinemeier Hansson
3eeb121ea1
Cards are no longer resized on the basis of activity scores
2025-04-18 17:00:13 +02:00
David Heinemeier Hansson
c65639a3ce
No longer used
...
Seemed to have been used for an old combobox design
2025-04-18 16:52:55 +02:00
David Heinemeier Hansson
9aef965db8
No longer used
...
I assume it was from the old bubble design
2025-04-18 16:49:36 +02:00
David Heinemeier Hansson
247524da29
Stlye
2025-04-18 16:47:53 +02:00
David Heinemeier Hansson
406c764253
Style
2025-04-18 16:46:20 +02:00
David Heinemeier Hansson
c6f363c281
Style
2025-04-18 16:42:35 +02:00
David Heinemeier Hansson
9cea403acd
Make sure that any card getting read does not empty out the notifications tray
...
Since we wont rehydrate it
2025-04-18 16:32:27 +02:00
David Heinemeier Hansson
f594bc09a0
Simplify
...
This is coming straight from the form, unlikely to blow up
2025-04-18 16:24:54 +02:00
David Heinemeier Hansson
7b0d3d033f
Fix extra space
2025-04-18 16:08:53 +02:00
David Heinemeier Hansson
f6cd21f7cb
Extract default stages into something that will be created together with a new Workflow in the model
2025-04-18 16:07:01 +02:00
David Heinemeier Hansson
1026408736
Need this for the draft header to be visible
2025-04-18 15:22:59 +02:00
David Heinemeier Hansson
f3000a02c5
Follow render_card_replacement pattern
...
And clean up the rest of the implementation a tad.
2025-04-18 15:20:38 +02:00
David Heinemeier Hansson
7395d4e034
Removing the image can also just be done as a card replacement
2025-04-18 15:14:36 +02:00
David Heinemeier Hansson
de23b4a866
Not needed for a single dependency
2025-04-18 15:10:47 +02:00
Jason Zimdars
0f3cb03bc4
Restore description field design clobbered in merge
2025-04-17 18:09:03 -05:00
Jason Zimdars
bc5035c8f3
Remove shadow on drafted cards
2025-04-17 18:08:28 -05:00
Jason Zimdars
3a823cae7d
No more yellow highlight
2025-04-17 18:08:12 -05:00
Jason Zimdars
e51dc10dc5
Remove draft comments
2025-04-17 18:07:56 -05:00
Jason Zimdars
026020c06e
Restore drafted card state
2025-04-17 18:07:39 -05:00
Jason Zimdars
44a5215da7
Merge branch 'main' into add-card-description
...
* main:
Fix failing test (we're no longer redirecting here
Display the empty message via CSS when there are no unread notifications
Hide Previously Seen section when empty with CSS
2025-04-17 17:08:49 -05:00
Jason Zimdars
e16dc859e3
Display the empty message via CSS when there are no unread notifications
2025-04-17 16:57:24 -05:00
Jason Zimdars
b37a8e3f33
Hide Previously Seen section when empty with CSS
2025-04-17 16:54:11 -05:00
Jason Zimdars
04f9a0f83a
Merge branch 'main' into add-card-description
...
* main: (33 commits)
Run beamer accessories in production only
Less noisy logging in production
Inline perma to container partial
Use card replacement for card updates too
Extract helper method to keep partial at a uniform level of abstraction
Remove duplicated conditional
Style
Note that we dont want to keep reloading these frames
I like this even better
Suffix qualifier is unnnecessary
Group partials for container
Match domain language
Fix trailing space
Use card rerendering instead of redirects
Better name
Stick with domain language
Fix tests
Rerender instead of redirect
Style
Extract partials that can be rerendered
...
2025-04-17 16:40:23 -05:00
David Heinemeier Hansson
b8775d41f5
Inline perma to container partial
...
Reveals all the container elements and perma wasnt used elsewhere.
2025-04-17 16:06:28 +02:00
David Heinemeier Hansson
0e442ac0d0
Use card replacement for card updates too
2025-04-17 15:56:56 +02:00
David Heinemeier Hansson
461c104ac2
Extract helper method to keep partial at a uniform level of abstraction
2025-04-17 15:42:07 +02:00
David Heinemeier Hansson
63b2abe020
Remove duplicated conditional
2025-04-17 15:38:47 +02:00